infrastructure/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2025-07-15 02:14:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

in dns.ParseDomain, don't allow ipv4 addresses (ipv6 addresses were already rejected)

Browse Source 
we are expecting a DNS domain name there.
also highlighted a wrong test in the smtp server.
This commit is contained in:
Mechiel Lukkien
2025-02-23 11:33:31 +01:00
parent 797c1cf9f0
commit 151729af08
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
smtpserver/server_test.go
View File

@ -530,7 +530,14 @@ func TestDelivery(t *testing.T) {
ts.run(func(client *smtpclient.Client) {
mailFrom := "remote@example.org"
rcptTo := "mjl@127.0.0.10"
rcptTo := "mjl@[127.0.0.10]"
err := client.Deliver(ctxbg, mailFrom, rcptTo, int64(len(deliverMessage)), strings.NewReader(deliverMessage), false, false, false)
ts.smtpErr(err, &smtpclient.Error{Permanent: true, Code: smtp.C550MailboxUnavail, Secode: smtp.SeAddr1UnknownDestMailbox1})
})
ts.run(func(client *smtpclient.Client) {
mailFrom := "remote@example.org"
rcptTo := "mjl@[IPv6:::1]"
err := client.Deliver(ctxbg, mailFrom, rcptTo, int64(len(deliverMessage)), strings.NewReader(deliverMessage), false, false, false)
ts.smtpErr(err, &smtpclient.Error{Permanent: true, Code: smtp.C550MailboxUnavail, Secode: smtp.SeAddr1UnknownDestMailbox1})
})