mirror of
https://github.com/mjl-/mox.git
synced 2025-07-13 12:14:37 +03:00
junk filter: fix adjusting word counts after train/untrain
after seeing some junk messages pass the filter, i investigated word counts in junkfilter.db. i had seen suspicious counts that were just around powers of two. did not make sense at the time. more investigating makes it clear: instead of setting new word counts when updating the junk filter, we were adding the new value to the current value (instead of just setting the new value). so the counts got approximately doubled when being updated. users should retrain the junk filter after this update using the "retrain" subcommand. this also adds logging for the hypothetical case where numbers would get decreased below zero (which would wrap around due to uints). and this fixes junk filter tests that were passing wrong parameters to train/untrain...
This commit is contained in:
2
ctl.go
2
ctl.go
@ -1348,6 +1348,8 @@ func servectlcmd(ctx context.Context, ctl *ctl, shutdown func()) {
|
||||
}
|
||||
}()
|
||||
|
||||
// todo: can we retrain an account without holding a write lock? perhaps by writing a junkfilter to a new location, and staying informed of message changes while we go through all messages in the account?
|
||||
|
||||
acc.WithWLock(func() {
|
||||
conf, _ := acc.Conf()
|
||||
if conf.JunkFilter == nil {
|
||||
|
Reference in New Issue
Block a user