infrastructure/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2025-07-12 17:04:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

imapserver: check for UIDNEXT overflow when adding a message to a mailbox

Browse Source 
Return an error, with instructions so a user may be able to work around the
issue.
This commit is contained in:
Mechiel Lukkien
2025-04-11 18:22:29 +02:00
parent 507ca73b96
commit 1a6d268e1d
3 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
store/account.go
View File

@ -298,6 +298,16 @@ type SpecialUse struct {
Trash bool
}
// UIDNextAdd increases the UIDNext value by n, returning an error on overflow.
func (mb *Mailbox) UIDNextAdd(n int) error {
uidnext := mb.UIDNext + UID(n)
if uidnext < mb.UIDNext {
return fmt.Errorf("uid overflow on mailbox %q (id %d): uidnext %d, adding %d; consider recreating the mailbox and copying its messages to compact", mb.Name, mb.ID, mb.UIDNext, n)
}
mb.UIDNext = uidnext
return nil
}
// CalculateCounts calculates the full current counts for messages in the mailbox.
func (mb *Mailbox) CalculateCounts(tx *bstore.Tx) (mc MailboxCounts, err error) {
q := bstore.QueryTx[Message](tx)
@ -2218,7 +2228,9 @@ func (a *Account) MessageAdd(log mlog.Log, tx *bstore.Tx, mb *Mailbox, m *Messag
}
if m.UID == 0 {
m.UID = mb.UIDNext
mb.UIDNext++
if err := mb.UIDNextAdd(1); err != nil {
return fmt.Errorf("adding uid: %v", err)
}
}
if m.ModSeq == 0 {
modseq, err := a.NextModSeq(tx)