mirror of
https://github.com/mjl-/mox.git
synced 2025-07-10 07:14:40 +03:00
initialize metric mox_panic_total with 0, so the alerting rule also catches the first panic for a label
increase() and rate() don't seem to assume a previous value of 0 when a vector gets a first value for a label. you would think that an increase() on a first-value mox_panic_total{"..."}=1 would return 1, and similar for rate(), but that doesn't appear to be the behaviour. so we just explicitly initialize the count to 0 for each possible label value. mox has more vector metrics, but panics feels like the most important, and it's too much code to initialize them all, for all combinations of label values. there is probably a better way that fixes this for all cases...
This commit is contained in:
@ -367,7 +367,7 @@ func logPanic(ctx context.Context) {
|
||||
log := xlog.WithContext(ctx)
|
||||
log.Error("recover from panic", mlog.Field("panic", x))
|
||||
debug.PrintStack()
|
||||
metrics.PanicInc("webadmin")
|
||||
metrics.PanicInc(metrics.Webadmin)
|
||||
}
|
||||
|
||||
// return IPs we may be listening on.
|
||||
|
Reference in New Issue
Block a user