Run modernize to rewrite some older go constructs to newer ones

Mostly using slice.Sort, using min/max, slices.Concat, range of int and
fmt.Appendf for byte slices instead of strings.
This commit is contained in:
Mechiel Lukkien
2025-03-06 17:33:06 +01:00
parent f6132bdbc0
commit 64f2f788b1
61 changed files with 146 additions and 232 deletions

View File

@ -202,7 +202,7 @@ func init() {
var methods []string
mt := reflect.TypeFor[webapi.Methods]()
n := mt.NumMethod()
for i := 0; i < n; i++ {
for i := range n {
methods = append(methods, mt.Method(i).Name)
}
docsIndexTmpl := htmltemplate.Must(htmltemplate.New("index").Parse(`<!doctype html>
@ -877,10 +877,7 @@ func (s server) Send(ctx context.Context, req webapi.SendRequest) (resp webapi.S
for len(base64Data) > 0 {
line := base64Data
n := len(line)
if n > 78 {
n = 78
}
n := min(len(line), 78)
line, base64Data = base64Data[:n], base64Data[n:]
_, err := p.Write([]byte(line))
xcheckf(err, "writing attachment")

View File

@ -132,11 +132,11 @@ func TestServer(t *testing.T) {
testHTTP("PUT", "/v0/Send", http.StatusMethodNotAllowed, "")
testHTTP("POST", "/v0/Send", http.StatusUnauthorized, "")
for i := 0; i < 11; i++ {
for range 11 {
// Missing auth doesn't trigger auth rate limiter.
testHTTP("POST", "/v0/Send", http.StatusUnauthorized, "")
}
for i := 0; i < 21; i++ {
for i := range 21 {
// Bad auth does.
expCode := http.StatusUnauthorized
tooMany := i >= 10