From a0bae5be553467640d9bc117ca2287d92f2b5ccc Mon Sep 17 00:00:00 2001 From: Mechiel Lukkien Date: Sun, 12 Nov 2023 11:53:39 +0100 Subject: [PATCH] for dns errors when looking up a tlsrpt record in the admin, don't make it a server error but a user error. so we don't generate alerts through prometheus. --- webadmin/admin.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webadmin/admin.go b/webadmin/admin.go index ff50017..40ad19d 100644 --- a/webadmin/admin.go +++ b/webadmin/admin.go @@ -2032,7 +2032,7 @@ func (Admin) LookupTLSRPTRecord(ctx context.Context, domain string) (record *TLS resolver := dns.StrictResolver{Pkg: "webadmin"} r, txt, err := tlsrpt.Lookup(ctx, resolver, dom) - if err != nil && (errors.Is(err, tlsrpt.ErrNoRecord) || errors.Is(err, tlsrpt.ErrMultipleRecords) || errors.Is(err, tlsrpt.ErrRecordSyntax)) { + if err != nil && (errors.Is(err, tlsrpt.ErrNoRecord) || errors.Is(err, tlsrpt.ErrMultipleRecords) || errors.Is(err, tlsrpt.ErrRecordSyntax) || errors.Is(err, tlsrpt.ErrDNS)) { errstr = err.Error() err = nil }