infrastructure/mox
1
0
Fork 0
mirror of https://github.com/mjl-/mox.git synced 2025-06-28 08:18:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

smtpserver: In localserve mode, don't reject messages "From" domain "localhost" if it doesn't resolve to an IP

Browse Source 
Mox does not look up names from the /etc/hosts file, only through DNS. But
"localhost" may not resolve through DNS, or when offline a DNS server may not
even be available. We will want deliveries to work in "mox localserve" mode.

Found by dstotijn.
This commit is contained in:
Mechiel Lukkien 2025-03-07 11:39:24 +01:00
parent 2fc75b5b7b
commit d0b241499f
No known key found for this signature in database
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
smtpserver/server.go
View File

@ -1872,7 +1872,11 @@ func (c *conn) cmdMail(p *parser) {
if err != nil { if err != nil {
c.log.Infox("temporary reject for temporary mx lookup error", err) c.log.Infox("temporary reject for temporary mx lookup error", err)
xsmtpServerErrorf(codes{smtp.C451LocalErr, smtp.SeNet4Other0}, "cannot verify mx records for mailfrom domain") xsmtpServerErrorf(codes{smtp.C451LocalErr, smtp.SeNet4Other0}, "cannot verify mx records for mailfrom domain")
} else if !valid { } else if !valid && !(Localserve && rpath.IPDomain.Domain.ASCII == "localhost") {
// We don't reject for "localhost" in Localserve mode because we only resolve
// through DNS, not an /etc/hosts file, and localhost may not resolve through DNS,
// depending on network environment.
c.log.Info("permanent reject because mailfrom domain does not accept mail") c.log.Info("permanent reject because mailfrom domain does not accept mail")
xsmtpUserErrorf(smtp.C550MailboxUnavail, smtp.SePol7SenderHasNullMX27, "mailfrom domain not configured for mail") xsmtpUserErrorf(smtp.C550MailboxUnavail, smtp.SePol7SenderHasNullMX27, "mailfrom domain not configured for mail")
} }