mirror of
https://github.com/mjl-/mox.git
synced 2025-07-14 16:54:36 +03:00

it was far down on the roadmap, but implemented earlier, because it's interesting, and to help prepare for a jmap implementation. for jmap we need to implement more client-like functionality than with just imap. internal data structures need to change. jmap has lots of other requirements, so it's already a big project. by implementing a webmail now, some of the required data structure changes become clear and can be made now, so the later jmap implementation can do things similarly to the webmail code. the webmail frontend and webmail are written together, making their interface/api much smaller and simpler than jmap. one of the internal changes is that we now keep track of per-mailbox total/unread/unseen/deleted message counts and mailbox sizes. keeping this data consistent after any change to the stored messages (through the code base) is tricky, so mox now has a consistency check that verifies the counts are correct, which runs only during tests, each time an internal account reference is closed. we have a few more internal "changes" that are propagated for the webmail frontend (that imap doesn't have a way to propagate on a connection), like changes to the special-use flags on mailboxes, and used keywords in a mailbox. more changes that will be required have revealed themselves while implementing the webmail, and will be implemented next. the webmail user interface is modeled after the mail clients i use or have used: thunderbird, macos mail, mutt; and webmails i normally only use for testing: gmail, proton, yahoo, outlook. a somewhat technical user is assumed, but still the goal is to make this webmail client easy to use for everyone. the user interface looks like most other mail clients: a list of mailboxes, a search bar, a message list view, and message details. there is a top/bottom and a left/right layout for the list/message view, default is automatic based on screen size. the panes can be resized by the user. buttons for actions are just text, not icons. clicking a button briefly shows the shortcut for the action in the bottom right, helping with learning to operate quickly. any text that is underdotted has a title attribute that causes more information to be displayed, e.g. what a button does or a field is about. to highlight potential phishing attempts, any text (anywhere in the webclient) that switches unicode "blocks" (a rough approximation to (language) scripts) within a word is underlined orange. multiple messages can be selected with familiar ui interaction: clicking while holding control and/or shift keys. keyboard navigation works with arrows/page up/down and home/end keys, and also with a few basic vi-like keys for list/message navigation. we prefer showing the text instead of html (with inlined images only) version of a message. html messages are shown in an iframe served from an endpoint with CSP headers to prevent dangerous resources (scripts, external images) from being loaded. the html is also sanitized, with javascript removed. a user can choose to load external resources (e.g. images for tracking purposes). the frontend is just (strict) typescript, no external frameworks. all incoming/outgoing data is typechecked, both the api request parameters and response types, and the data coming in over SSE. the types and checking code are generated with sherpats, which uses the api definitions generated by sherpadoc based on the Go code. so types from the backend are automatically propagated to the frontend. since there is no framework to automatically propagate properties and rerender components, changes coming in over the SSE connection are propagated explicitly with regular function calls. the ui is separated into "views", each with a "root" dom element that is added to the visible document. these views have additional functions for getting changes propagated, often resulting in the view updating its (internal) ui state (dom). we keep the frontend compilation simple, it's just a few typescript files that get compiled (combined and types stripped) into a single js file, no additional runtime code needed or complicated build processes used. the webmail is served is served from a compressed, cachable html file that includes style and the javascript, currently just over 225kb uncompressed, under 60kb compressed (not minified, including comments). we include the generated js files in the repository, to keep Go's easily buildable self-contained binaries. authentication is basic http, as with the account and admin pages. most data comes in over one long-term SSE connection to the backend. api requests signal which mailbox/search/messages are requested over the SSE connection. fetching individual messages, and making changes, are done through api calls. the operations are similar to imap, so some code has been moved from package imapserver to package store. the future jmap implementation will benefit from these changes too. more functionality will probably be moved to the store package in the future. the quickstart enables webmail on the internal listener by default (for new installs). users can enable it on the public listener if they want to. mox localserve enables it too. to enable webmail on existing installs, add settings like the following to the listeners in mox.conf, similar to AccountHTTP(S): WebmailHTTP: Enabled: true WebmailHTTPS: Enabled: true special thanks to liesbeth, gerben, andrii for early user feedback. there is plenty still to do, see the list at the top of webmail/webmail.ts. feedback welcome as always.
271 lines
6.4 KiB
Go
271 lines
6.4 KiB
Go
/*
|
|
Sherpadoc parses Go code and outputs sherpa documentation in JSON.
|
|
|
|
This documentation is provided to the sherpa HTTP handler to serve
|
|
as documentation through the _docs function.
|
|
|
|
Example:
|
|
|
|
sherpadoc Awesome >awesome.json
|
|
|
|
Sherpadoc parses Go code, finds a struct named "Awesome", and gathers
|
|
documentation:
|
|
|
|
Comments above the struct are used as section documentation. Fields
|
|
in section structs must are treated as subsections, and can in turn
|
|
contain subsections. These subsections and their methods are also
|
|
exported and documented in the sherpa API. Add a struct tag "sherpa"
|
|
to override the name of the subsection, for example `sherpa:"Another
|
|
Awesome API"`.
|
|
|
|
Comments above method names are function documentation. A synopsis
|
|
is automatically generated.
|
|
|
|
Types used as parameters or return values are added to the section
|
|
documentation where they are used. The comments above the type are
|
|
used, as well as the comments for each field in a struct. The
|
|
documented field names know about the "json" struct field tags.
|
|
|
|
More eloborate example:
|
|
|
|
sherpadoc
|
|
-title 'Awesome API by mjl' \
|
|
-replace 'pkg.Type string,example.com/some/pkg.SomeType [] string' \
|
|
path/to/awesome/code Awesome \
|
|
>awesome.json
|
|
|
|
Most common Go code patterns for API functions have been implemented
|
|
in sherpadoc, but you may run into missing support.
|
|
*/
|
|
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"flag"
|
|
"fmt"
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/mjl-/sherpadoc"
|
|
|
|
"golang.org/x/mod/modfile"
|
|
)
|
|
|
|
var (
|
|
packagePath = flag.String("package-path", ".", "of source code to parse")
|
|
replace = flag.String("replace", "", "comma-separated list of type replacements, e.g. \"somepkg.SomeType string\"")
|
|
title = flag.String("title", "", "title of the API, default is the name of the type of the main API")
|
|
adjustFunctionNames = flag.String("adjust-function-names", "", `by default, the first character of function names is turned into lower case; with "lowerWord" the first string of upper case characters is lower cased, with "none" the name is left as is`)
|
|
)
|
|
|
|
// If there is a "vendor" directory, we'll load packages from there (instead of
|
|
// through (slower) packages.Load), and we need to know the module name to resolve
|
|
// imports to paths in vendor.
|
|
var (
|
|
gomodFile *modfile.File
|
|
gomodDir string
|
|
)
|
|
|
|
type field struct {
|
|
Name string
|
|
Typewords []string
|
|
Doc string
|
|
Fields []*field
|
|
}
|
|
|
|
func (f field) TypeString() string {
|
|
t := []string{}
|
|
for _, e := range f.Typewords {
|
|
if e == "nullable" {
|
|
e = "*"
|
|
}
|
|
t = append(t, e)
|
|
}
|
|
return strings.Join(t, "")
|
|
}
|
|
|
|
type typeKind int
|
|
|
|
const (
|
|
typeStruct typeKind = iota
|
|
typeInts
|
|
typeStrings
|
|
typeBytes
|
|
)
|
|
|
|
// NamedType represents the type of a parameter or return value.
|
|
type namedType struct {
|
|
Name string
|
|
Text string
|
|
Kind typeKind
|
|
Fields []*field // For kind is typeStruct.
|
|
// For kind is typeInts
|
|
IntValues []struct {
|
|
Name string
|
|
Value int64
|
|
Docs string
|
|
}
|
|
// For kind is typeStrings
|
|
StringValues []struct {
|
|
Name string
|
|
Value string
|
|
Docs string
|
|
}
|
|
}
|
|
|
|
type function struct {
|
|
Name string
|
|
Text string
|
|
Params []sherpadoc.Arg
|
|
Returns []sherpadoc.Arg
|
|
}
|
|
|
|
// Section is an API section with docs, functions and subsections.
|
|
// Types are gathered per section, and moved up the section tree to the first common ancestor, so types are only documented once.
|
|
type section struct {
|
|
TypeName string // Name of the type for this section.
|
|
Name string // Name of the section. Either same as TypeName, or overridden with a "sherpa" struct tag.
|
|
Text string
|
|
Types []*namedType
|
|
Typeset map[string]struct{}
|
|
Functions []*function
|
|
Sections []*section
|
|
}
|
|
|
|
func check(err error, action string) {
|
|
if err != nil {
|
|
log.Fatalf("%s: %s", action, err)
|
|
}
|
|
}
|
|
|
|
func usage() {
|
|
log.Println("usage: sherpadoc [flags] section")
|
|
flag.PrintDefaults()
|
|
os.Exit(2)
|
|
}
|
|
|
|
func main() {
|
|
log.SetFlags(0)
|
|
flag.Usage = usage
|
|
flag.Parse()
|
|
args := flag.Args()
|
|
if len(args) != 1 {
|
|
usage()
|
|
}
|
|
|
|
// If vendor exists, we load packages from it.
|
|
for dir, _ := os.Getwd(); dir != "" && dir != "/"; dir = filepath.Dir(dir) {
|
|
p := filepath.Join(dir, "go.mod")
|
|
if _, err := os.Stat(p); err != nil && os.IsNotExist(err) {
|
|
continue
|
|
} else if err != nil {
|
|
log.Printf("searching for go.mod: %v", err)
|
|
break
|
|
}
|
|
|
|
if _, err := os.Stat(filepath.Join(dir, "vendor")); err != nil {
|
|
break
|
|
}
|
|
|
|
if gomod, err := os.ReadFile(p); err != nil {
|
|
log.Fatalf("reading go.mod: %s", err)
|
|
} else if mf, err := modfile.ParseLax("go.mod", gomod, nil); err != nil {
|
|
log.Fatalf("parsing go.mod: %s", err)
|
|
} else {
|
|
gomodFile = mf
|
|
gomodDir = dir
|
|
}
|
|
}
|
|
|
|
section := parseDoc(args[0], *packagePath)
|
|
if *title != "" {
|
|
section.Name = *title
|
|
}
|
|
|
|
moveTypesUp(section)
|
|
|
|
doc := sherpaSection(section)
|
|
doc.SherpaVersion = 0
|
|
doc.SherpadocVersion = sherpadoc.SherpadocVersion
|
|
|
|
err := sherpadoc.Check(doc)
|
|
check(err, "checking sherpadoc output before writing")
|
|
|
|
writeJSON(doc)
|
|
}
|
|
|
|
func writeJSON(v interface{}) {
|
|
buf, err := json.MarshalIndent(v, "", "\t")
|
|
check(err, "marshal to json")
|
|
_, err = os.Stdout.Write(buf)
|
|
check(err, "writing json to stdout")
|
|
_, err = fmt.Println()
|
|
check(err, "write to stdout")
|
|
}
|
|
|
|
type typeCount struct {
|
|
t *namedType
|
|
count int
|
|
}
|
|
|
|
// Move types used in multiple sections up to their common ancestor.
|
|
func moveTypesUp(sec *section) {
|
|
// First, the process for each child.
|
|
for _, s := range sec.Sections {
|
|
moveTypesUp(s)
|
|
}
|
|
|
|
// Count how often a type is used from here downwards.
|
|
// If more than once, move the type up to here.
|
|
counts := map[string]*typeCount{}
|
|
countTypes(counts, sec)
|
|
for _, tc := range counts {
|
|
if tc.count <= 1 {
|
|
continue
|
|
}
|
|
for _, sub := range sec.Sections {
|
|
removeType(sub, tc.t)
|
|
}
|
|
if !hasType(sec, tc.t) {
|
|
sec.Types = append(sec.Types, tc.t)
|
|
}
|
|
}
|
|
}
|
|
|
|
func countTypes(counts map[string]*typeCount, sec *section) {
|
|
for _, t := range sec.Types {
|
|
_, ok := counts[t.Name]
|
|
if !ok {
|
|
counts[t.Name] = &typeCount{t, 0}
|
|
}
|
|
counts[t.Name].count++
|
|
}
|
|
for _, subsec := range sec.Sections {
|
|
countTypes(counts, subsec)
|
|
}
|
|
}
|
|
|
|
func removeType(sec *section, t *namedType) {
|
|
types := make([]*namedType, 0, len(sec.Types))
|
|
for _, tt := range sec.Types {
|
|
if tt.Name != t.Name {
|
|
types = append(types, tt)
|
|
}
|
|
}
|
|
sec.Types = types
|
|
for _, sub := range sec.Sections {
|
|
removeType(sub, t)
|
|
}
|
|
}
|
|
|
|
func hasType(sec *section, t *namedType) bool {
|
|
for _, tt := range sec.Types {
|
|
if tt.Name == t.Name {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|