mirror of
https://github.com/mjl-/mox.git
synced 2025-06-28 01:48:15 +03:00
e7b562e3f2
The imapclient needs more changes, like more strict parsing, before it can be a generally usable IMAP client, these are a few steps towards that. - Fix a bug in the imapserver METADATA responses for TOOMANY and MAXSIZE. - Split low-level IMAP protocol handling (new Proto type) from the higher-level client command handling (existing Conn type). The idea is that some simple uses of IMAP can get by with just using these commands, while more intricate uses of IMAP (like a synchronizing client that needs to talk to all kinds of servers with different behaviours and implemented extensions) can write custom commands and read untagged responses or command completion results explicitly. The lower-level method names have clearer names now, like ReadResponse instead of Response. - Merge the untagged responses and (command completion) "Result" into a new type Response. Makes function signatures simpler. And make Response implement the error interface, and change command methods to return the Response as error if the result is NO or BAD. Simplifies error handling, and still provides the option to continue after a NO or BAD. - Add UIDSearch/MSNSearch commands, with a custom "search program", so mostly to indicate these commands exist. - More complete coverage of types for response codes, for easier handling. - Automatically handle any ENABLED or CAPABILITY untagged response or response code for IMAP command methods on type Conn. - Make difference between MSN vs UID versions of FETCH/STORE/SEARCH/COPY/MOVE/REPLACE commands more clear. The original MSN commands now have MSN prefixed to their name, so they are grouped together in the documentation. - Document which capabilities are needed for a command.
136 lines
4.8 KiB
Go
136 lines
4.8 KiB
Go
package imapserver
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mjl-/mox/imapclient"
|
|
)
|
|
|
|
func TestAppend(t *testing.T) {
|
|
testAppend(t, false)
|
|
}
|
|
|
|
func TestAppendUIDOnly(t *testing.T) {
|
|
testAppend(t, true)
|
|
}
|
|
|
|
func testAppend(t *testing.T, uidonly bool) {
|
|
defer mockUIDValidity()()
|
|
|
|
tc := start(t, uidonly) // note: with switchboard because this connection stays alive unlike tc2.
|
|
defer tc.close()
|
|
|
|
tc2 := startNoSwitchboard(t, uidonly) // note: without switchboard because this connection will break during tests.
|
|
defer tc2.closeNoWait()
|
|
|
|
tc3 := startNoSwitchboard(t, uidonly)
|
|
defer tc3.closeNoWait()
|
|
|
|
tc2.login("mjl@mox.example", password0)
|
|
tc2.client.Select("inbox")
|
|
tc.login("mjl@mox.example", password0)
|
|
tc.client.Select("inbox")
|
|
tc3.login("mjl@mox.example", password0)
|
|
|
|
tc2.transactf("bad", "append") // Missing params.
|
|
tc2.transactf("bad", `append inbox`) // Missing message.
|
|
tc2.transactf("bad", `append inbox "test"`) // Message must be literal.
|
|
|
|
// Syntax error for line ending in literal causes connection abort.
|
|
tc2.transactf("bad", "append inbox (\\Badflag) {1+}\r\nx") // Unknown flag.
|
|
tc2 = startNoSwitchboard(t, uidonly)
|
|
defer tc2.closeNoWait()
|
|
tc2.login("mjl@mox.example", password0)
|
|
tc2.client.Select("inbox")
|
|
|
|
tc2.transactf("bad", "append inbox () \"bad time\" {1+}\r\nx") // Bad time.
|
|
tc2 = startNoSwitchboard(t, uidonly)
|
|
defer tc2.closeNoWait()
|
|
tc2.login("mjl@mox.example", password0)
|
|
tc2.client.Select("inbox")
|
|
|
|
tc2.transactf("no", "append nobox (\\Seen) \" 1-Jan-2022 10:10:00 +0100\" {1}")
|
|
tc2.xcodeWord("TRYCREATE")
|
|
|
|
tc2.transactf("no", "append expungebox (\\Seen) {1}")
|
|
tc2.xcodeWord("TRYCREATE")
|
|
|
|
tc2.transactf("ok", "append inbox (\\Seen Label1 $label2) \" 1-Jan-2022 10:10:00 +0100\" {1+}\r\nx")
|
|
tc2.xuntagged(imapclient.UntaggedExists(1))
|
|
tc2.xcode(imapclient.CodeAppendUID{UIDValidity: 1, UIDs: xparseUIDRange("1")})
|
|
|
|
tc.transactf("ok", "noop")
|
|
flags := imapclient.FetchFlags{`\Seen`, "$label2", "label1"}
|
|
tc.xuntagged(imapclient.UntaggedExists(1), tc.untaggedFetch(1, 1, flags))
|
|
tc3.transactf("ok", "noop")
|
|
tc3.xuntagged() // Inbox is not selected, nothing to report.
|
|
|
|
tc2.transactf("ok", "append inbox (\\Seen) \" 1-Jan-2022 10:10:00 +0100\" UTF8 (~{47+}\r\ncontent-type: just completely invalid;;\r\n\r\ntest)")
|
|
tc2.xuntagged(imapclient.UntaggedExists(2))
|
|
tc2.xcode(imapclient.CodeAppendUID{UIDValidity: 1, UIDs: xparseUIDRange("2")})
|
|
|
|
tc2.transactf("ok", "append inbox (\\Seen) \" 1-Jan-2022 10:10:00 +0100\" UTF8 (~{31+}\r\ncontent-type: text/plain;\n\ntest)")
|
|
tc2.xuntagged(imapclient.UntaggedExists(3))
|
|
tc2.xcode(imapclient.CodeAppendUID{UIDValidity: 1, UIDs: xparseUIDRange("3")})
|
|
|
|
// Messages that we cannot parse are marked as application/octet-stream. Perhaps
|
|
// the imap client knows how to deal with them.
|
|
tc2.transactf("ok", "uid fetch 2 body")
|
|
xbs := imapclient.FetchBodystructure{
|
|
RespAttr: "BODY",
|
|
Body: imapclient.BodyTypeBasic{
|
|
MediaType: "APPLICATION",
|
|
MediaSubtype: "OCTET-STREAM",
|
|
BodyFields: imapclient.BodyFields{
|
|
Octets: 4,
|
|
},
|
|
},
|
|
}
|
|
tc2.xuntagged(tc.untaggedFetch(2, 2, xbs))
|
|
|
|
// Multiappend with two messages.
|
|
tc.transactf("ok", "noop") // Flush pending untagged responses.
|
|
tc.transactf("ok", "append inbox {6+}\r\ntest\r\n ~{6+}\r\ntost\r\n")
|
|
tc.xuntagged(imapclient.UntaggedExists(5))
|
|
tc.xcode(imapclient.CodeAppendUID{UIDValidity: 1, UIDs: xparseUIDRange("4:5")})
|
|
|
|
// Cancelled with zero-length message.
|
|
tc.transactf("no", "append inbox {6+}\r\ntest\r\n {0+}\r\n")
|
|
|
|
tclimit := startArgs(t, uidonly, false, false, true, true, "limit")
|
|
defer tclimit.close()
|
|
tclimit.login("limit@mox.example", password0)
|
|
tclimit.client.Select("inbox")
|
|
// First message of 1 byte is within limits.
|
|
tclimit.transactf("ok", "append inbox (\\Seen Label1 $label2) \" 1-Jan-2022 10:10:00 +0100\" {1+}\r\nx")
|
|
tclimit.xuntagged(imapclient.UntaggedExists(1))
|
|
// Second message would take account past limit.
|
|
tclimit.transactf("no", "append inbox (\\Seen Label1 $label2) \" 1-Jan-2022 10:10:00 +0100\" {1+}\r\nx")
|
|
tclimit.xcodeWord("OVERQUOTA")
|
|
|
|
// Empty mailbox.
|
|
if uidonly {
|
|
tclimit.transactf("ok", `uid store 1 flags (\deleted)`)
|
|
} else {
|
|
tclimit.transactf("ok", `store 1 flags (\deleted)`)
|
|
}
|
|
tclimit.transactf("ok", "expunge")
|
|
|
|
// Multiappend with first message within quota, and second message with sync
|
|
// literal causing quota error. Request should get error response immediately.
|
|
tclimit.transactf("no", "append inbox {1+}\r\nx {100000}")
|
|
tclimit.xcodeWord("OVERQUOTA")
|
|
|
|
// Again, but second message now with non-sync literal, which is fully consumed by server.
|
|
tclimit.client.WriteCommandf("", "append inbox {1+}\r\nx {4000+}")
|
|
buf := make([]byte, 4000, 4002)
|
|
for i := range buf {
|
|
buf[i] = 'x'
|
|
}
|
|
buf = append(buf, "\r\n"...)
|
|
_, err := tclimit.client.Write(buf)
|
|
tclimit.check(err, "write append message")
|
|
tclimit.response("no")
|
|
tclimit.xcodeWord("OVERQUOTA")
|
|
}
|