mirror of
https://github.com/mjl-/mox.git
synced 2025-06-27 22:28:16 +03:00
a2c79e25c1
We normally check errors for all operations. But for some cleanup calls, eg "defer file.Close()", we didn't. Now we also check and log most of those. Partially because those errors can point to some mishandling or unexpected code paths (eg file unexpected already closed). And in part to make it easier to use "errcheck" to find the real missing error checks, there is too much noise now. The log.Check function can now be used unconditionally for checking and logging about errors. It adjusts the log level if the error is caused by a network connection being closed, or a context is canceled or its deadline reached, or a socket deadline is reached.
25 lines
712 B
Go
25 lines
712 B
Go
package mlog
|
|
|
|
import (
|
|
"errors"
|
|
"net"
|
|
"syscall"
|
|
)
|
|
|
|
// In separate file because of import of syscall.
|
|
|
|
// IsClosed returns whether i/o failed, typically because the connection is closed
|
|
// or otherwise cannot be used for further i/o.
|
|
//
|
|
// Used to prevent error logging for connections that are closed.
|
|
func IsClosed(err error) bool {
|
|
return errors.Is(err, net.ErrClosed) || errors.Is(err, syscall.EPIPE) || errors.Is(err, syscall.ECONNRESET) || isRemoteTLSError(err)
|
|
}
|
|
|
|
// A remote TLS client can send a message indicating failure, this makes it back to
|
|
// us as a write error.
|
|
func isRemoteTLSError(err error) bool {
|
|
var netErr *net.OpError
|
|
return errors.As(err, &netErr) && netErr.Op == "remote error"
|
|
}
|