zeldon
/
htop
mirror of https://github.com/xzeldon/htop.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use variable-length-array instead of small dynamic allocation

This commit is contained in:
Christian Göttsche 2020-12-19 23:05:07 +01:00
parent e3862aa67e
commit 358d20687f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CommandScreen.c
View File

@ -17,9 +17,10 @@ static void CommandScreen_scan(InfoScreen* this) {
Panel_prune(panel); Panel_prune(panel);
const char* p = Process_getCommand(this->process); const char* p = Process_getCommand(this->process);
char* line = xMalloc(COLS + 1); char line[COLS + 1];
int line_offset = 0, last_spc = -1, len; int line_offset = 0, last_spc = -1, len;
for (; *p != '\0'; p++, line_offset++) { for (; *p != '\0'; p++, line_offset++) {
assert(line_offset >= 0 && (size_t)line_offset < sizeof(line));
line[line_offset] = *p; line[line_offset] = *p;
if (*p == ' ') { if (*p == ' ') {
last_spc = line_offset; last_spc = line_offset;
@ -41,7 +42,6 @@ static void CommandScreen_scan(InfoScreen* this) {
InfoScreen_addLine(this, line); InfoScreen_addLine(this, line);
} }
free(line);
Panel_setSelected(panel, idx); Panel_setSelected(panel, idx);
} }