From 6921000481d3f8e3e0fecf89df436312efaa691a Mon Sep 17 00:00:00 2001
From: Benny Baumann <BenBE@geshi.org>
Date: Tue, 15 Sep 2020 22:02:57 +0200
Subject: [PATCH] =?UTF-8?q?Barely=20ever=20seen=20any=201000=20digit=20PID?=
 =?UTF-8?q?s=20=E2=80=A6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 OpenFilesScreen.c | 4 ++--
 TraceScreen.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/OpenFilesScreen.c b/OpenFilesScreen.c
index 3e45bf85..ae32590f 100644
--- a/OpenFilesScreen.c
+++ b/OpenFilesScreen.c
@@ -52,8 +52,6 @@ void OpenFilesScreen_draw(InfoScreen* this) {
 }
 
 static OpenFiles_ProcessData* OpenFilesScreen_getProcessData(pid_t pid) {
-   char buffer[1025];
-   xSnprintf(buffer, 1024, "%d", pid);
    OpenFiles_ProcessData* pdata = xCalloc(1, sizeof(OpenFiles_ProcessData));
    OpenFiles_FileData* fdata = NULL;
    OpenFiles_Data* item = &(pdata->data);
@@ -76,6 +74,8 @@ static OpenFiles_ProcessData* OpenFilesScreen_getProcessData(pid_t pid) {
          exit(1);
       dup2(fdnull, STDERR_FILENO);
       close(fdnull);
+      char buffer[32] = {0};
+      xSnprintf(buffer, sizeof(buffer), "%d", pid);
       execlp("lsof", "lsof", "-P", "-p", buffer, "-F", NULL);
       exit(127);
    }
diff --git a/TraceScreen.c b/TraceScreen.c
index 0a3485ec..a04f9a0d 100644
--- a/TraceScreen.c
+++ b/TraceScreen.c
@@ -74,7 +74,6 @@ void TraceScreen_draw(InfoScreen* this) {
 }
 
 bool TraceScreen_forkTracer(TraceScreen* this) {
-   char buffer[1001];
    int error = pipe(this->fdpair);
    if (error == -1) return false;
    this->child = fork();
@@ -84,6 +83,7 @@ bool TraceScreen_forkTracer(TraceScreen* this) {
       dup2(this->fdpair[1], STDERR_FILENO);
       int ok = fcntl(this->fdpair[1], F_SETFL, O_NONBLOCK);
       if (ok != -1) {
+         char buffer[32] = {0};
          xSnprintf(buffer, sizeof(buffer), "%d", this->super.process->pid);
          execlp("strace", "strace", "-T", "-tt", "-s", "512", "-p", buffer, NULL);
       }