zeldon
/
htop
mirror of https://github.com/xzeldon/htop.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Linux: silence UBSAN implicit conversions 

pgrp and session might be -1

linux/LinuxProcessList.c:312:20: runtime error: implicit conversion from type 'unsigned long' of value 18446744073709551615 (64-bit, unsigned) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior linux/LinuxProcessList.c:312:20 in
linux/LinuxProcessList.c:314:23: runtime error: implicit conversion from type 'unsigned long' of value 18446744073709551615 (64-bit, unsigned) to type 'unsigned int' changed the value to 4294967295 (32-bit, unsigned)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior linux/LinuxProcessList.c:314:23 in
This commit is contained in:
Christian Göttsche 2021-01-27 15:12:15 +01:00 committed by BenBE
parent 1014e897a7
commit 7bfa466abe
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Process.h
View File

@ -76,10 +76,10 @@ typedef struct Process_ {
pid_t tgid; pid_t tgid;
/* Process group identifier */ /* Process group identifier */
unsigned int pgrp; int pgrp;
/* Session identifier */ /* Session identifier */
unsigned int session; int session;
/* Foreground group identifier of the controlling terminal */ /* Foreground group identifier of the controlling terminal */
int tpgid; int tpgid;

4
linux/LinuxProcessList.c
View File

@ -316,11 +316,11 @@ static bool LinuxProcessList_readStatFile(Process* process, openat_arg_t procFd,
location += 1; location += 1;
/* (5) pgrp - %d */ /* (5) pgrp - %d */
process->pgrp = strtoul(location, &location, 10); process->pgrp = strtol(location, &location, 10);
location += 1; location += 1;
/* (6) session - %d */ /* (6) session - %d */
process->session = strtoul(location, &location, 10); process->session = strtol(location, &location, 10);
location += 1; location += 1;
/* (7) tty_nr - %d */ /* (7) tty_nr - %d */