From b3b890f546e5054b4d9222c8efcef3a425a152ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Mon, 16 Nov 2020 16:59:01 +0100 Subject: [PATCH] Use 0 as no-match value for sortkey Field numbers start at 1, and using -1 as no-match special value triggers static analyzers using a potential negative array access. --- htop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htop.c b/htop.c index c6cd5411..1bbdd50a 100644 --- a/htop.c +++ b/htop.c @@ -139,7 +139,7 @@ static CommandLineSettings parseArguments(int argc, char** argv) { } exit(0); } - flags.sortKey = -1; + flags.sortKey = 0; for (int j = 1; j < Platform_numberOfFields; j++) { if (Process_fields[j].name == NULL) continue; @@ -148,7 +148,7 @@ static CommandLineSettings parseArguments(int argc, char** argv) { break; } } - if (flags.sortKey == -1) { + if (flags.sortKey == 0) { fprintf(stderr, "Error: invalid column \"%s\".\n", optarg); exit(1); }