zeldon
/
htop
mirror of https://github.com/xzeldon/htop.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: BenBE <BenBE@geshi.org>
This commit is contained in:
Nathan Scott 2021-08-17 15:42:10 +10:00 committed by GitHub
parent c7f634ec21
commit d5ff5c48a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Action.c
View File

@ -174,7 +174,7 @@ static Htop_Reaction actionSetSortColumn(State* st) {
char* name = NULL; char* name = NULL;
if (fields[i] >= LAST_PROCESSFIELD) { if (fields[i] >= LAST_PROCESSFIELD) {
DynamicColumn* column = Hashtable_get(dynamicColumns, fields[i]); DynamicColumn* column = Hashtable_get(dynamicColumns, fields[i]);
if (column == NULL) if (!column)
continue; continue;
name = xStrdup(column->caption ? column->caption : column->name); name = xStrdup(column->caption ? column->caption : column->name);
} else { } else {

2
pcp/PCPDynamicColumn.c
View File

@ -287,7 +287,7 @@ void PCPDynamicColumn_writeField(PCPDynamicColumn* this, const Process* proc, Ri
int PCPDynamicColumn_compareByKey(const PCPProcess* p1, const PCPProcess* p2, ProcessField key) { int PCPDynamicColumn_compareByKey(const PCPProcess* p1, const PCPProcess* p2, ProcessField key) {
const PCPDynamicColumn* column = Hashtable_get(p1->super.processList->dynamicColumns, key); const PCPDynamicColumn* column = Hashtable_get(p1->super.processList->dynamicColumns, key);
if (column == NULL) if (!column)
return -1; return -1;
size_t metric = column->id; size_t metric = column->id;