zeldon/htop
1
0
Fork 0
mirror of https://github.com/xzeldon/htop.git synced 2025-07-12 12:14:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Drop unneeded parameters to the ScreenManager constructor

Browse Source 
All calls to ScreenManager_new always pass the same first
five values, the orientation is always HORIZONTAL and the
y1 parameter is always the height of the passed-in header
struct pointer.  I think its safe to assert at this point
that no VERTICAL orientation will arrive (if it does, its
no harm in re-adding this then) - so we can remove unused
conditionals (and TODOs) based on orientation too.
This commit is contained in:
Nathan Scott
2020-11-26 16:15:09 +11:00
committed by BenBE
parent 83bf8cfad6
commit fee217551c
5 changed files with 31 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ScreenManager.h
View File

@ -16,17 +16,11 @@ in the source distribution for its full text.
#include "Vector.h"
typedef enum Orientation_ {
VERTICAL,
HORIZONTAL
} Orientation;
typedef struct ScreenManager_ {
int x1;
int y1;
int x2;
int y2;
Orientation orientation;
Vector* panels;
int panelCount;
Header* header;
@ -36,7 +30,7 @@ typedef struct ScreenManager_ {
bool allowFocusChange;
} ScreenManager;
ScreenManager* ScreenManager_new(int x1, int y1, int x2, int y2, Orientation orientation, Header* header, const Settings* settings, const State* state, bool owner);
ScreenManager* ScreenManager_new(Header* header, const Settings* settings, const State* state, bool owner);
void ScreenManager_delete(ScreenManager* this);