Commit Graph

568 Commits

Author SHA1 Message Date
Hisham Muhammad 27da00f339 Improve function prototype, helping analysis. 2014-04-24 19:50:33 -03:00
Hisham Muhammad d5b3b6d692 Add corresponding .h file. 2014-04-24 19:50:03 -03:00
Hisham Muhammad 616ee966d7 Fix out-of-bounds write. 2014-04-24 19:48:34 -03:00
Hisham Muhammad 50b701258d Make static analyzers happy. 2014-04-24 19:46:10 -03:00
Hisham Muhammad 814ce89b45 Oops, fix use of memset. 2014-04-24 19:44:41 -03:00
Hisham Muhammad 659251c501 Fix array limit. 2014-04-24 19:43:27 -03:00
Hisham Muhammad e0209da88f Support pagefaults stats. Closes #45. 2014-04-24 19:40:47 -03:00
Hisham Muhammad 4e2c2d7927 Fix resource leak. 2014-04-24 19:29:20 -03:00
Hisham Muhammad eb1cd4aca6 change swap to M for consistency. Closes #63. 2014-04-24 19:03:07 -03:00
Hisham Muhammad ab118c2dbe Update changelog items. 2014-04-24 15:10:29 -03:00
Hisham Muhammad 2f30cd1070 Boost field buffer size - crashes when trying to draw very deep UTF-8 trees
Test by nesting 30 shells
Patch from ArchLinux. Closes #65.
2014-04-24 15:08:32 -03:00
Hisham Muhammad a939cdf827 Better consistency in coloring. Closes #66.
For now rates won't be colored gray when zero; I'll think about that.
2014-04-24 15:00:09 -03:00
Hisham Muhammad 100bd10b1d Make blue text more readable. Closes #55. 2014-04-24 13:15:52 -03:00
Hisham Muhammad f86851766b Both IO_PRIO and IO_RATE had the same column heading. Closes #61. 2014-04-24 12:52:26 -03:00
Hisham Muhammad 6795d8b692 Report as an exit function. 2014-04-24 12:20:03 -03:00
Hisham Muhammad 6fbc5a31da Report this as an exit function. 2014-04-24 12:17:11 -03:00
Hisham Muhammad 446d86c7a2 Let's see if this assert makes static analyzers happier. 2014-04-24 12:16:51 -03:00
Hisham Muhammad 2fdebf6a29 Remove useless test. 2014-04-24 12:16:21 -03:00
Hisham Muhammad 34b89a9747 Add sanity checks. 2014-04-24 12:15:56 -03:00
Hisham Muhammad 823bdbae13 safer code, check result of lstat 2014-04-22 20:35:57 -03:00
Hisham Muhammad 1afbc19087 safer code, test for return of fcntl 2014-04-22 20:35:44 -03:00
Hisham Muhammad 28d4cad5fe xread may return -1. 2014-04-22 18:48:27 -03:00
Hisham Muhammad 2ee1c41274 Add .h file ref previous commit 2014-04-22 18:48:15 -03:00
Hisham Muhammad 1de8762e71 Fix display of open files.
Cleanup the code to prevent this bug from happening again.
2014-04-22 18:45:47 -03:00
Hisham Muhammad d28b281165 Fix compiler complaints. 2014-04-22 18:19:24 -03:00
Hisham Muhammad b1564c2be9 Refactor and fix resource leaks. 2014-04-22 18:19:01 -03:00
Hisham Muhammad 79e390120a Remove use of usleep, which is sadly obsolete. 2014-04-21 19:37:57 -03:00
Hisham Muhammad f239b62b90 Restrict size of read. 2014-04-21 19:18:08 -03:00
Hisham Muhammad f677843288 Restrict size of inputs on sscanf reads. 2014-04-21 19:17:57 -03:00
Hisham Muhammad 3fbd1ef76d check return of topoErr 2014-04-21 19:17:46 -03:00
Hisham Muhammad 30bafafb24 avoid strtok and reduce scope of variables. 2014-04-21 19:16:16 -03:00
Hisham Muhammad 57b393f783 shorten scope of variable. 2014-04-21 19:01:15 -03:00
Hisham Muhammad 5b30280810 shorten scope of variables. 2014-04-21 19:00:35 -03:00
Hisham Muhammad 0a4ddab2a4 Use proper format string for unsigned data. 2014-04-21 19:00:12 -03:00
Hisham Muhammad 2bf8754bc2 Remove useless assignment. 2014-04-21 18:59:52 -03:00
Hisham Muhammad f5a469b5a8 Use reentrant version to silence warnings. 2014-04-21 18:59:30 -03:00
Hisham Muhammad 4027e5ee44 goto considered harmful and confuses cppcheck. 2014-04-21 18:55:58 -03:00
Hisham Muhammad 2f0a4b3d3a Test realloc failure to make cppcheck happy 2014-04-21 18:23:34 -03:00
Hisham Muhammad 99bc23771f Fix resource leak detected by cppcheck 2014-04-21 18:23:21 -03:00
Hisham Muhammad af02749722 Merge branch 'master' of https://github.com/hishamhm/htop 2014-04-11 20:18:27 -03:00
Hisham Muhammad 4716a9857b Fix logic for skipping non-numeric directories.
Closes #42.
2014-04-11 20:17:07 -03:00
Hisham Muhammad 1ac517be52 Fix padding in large numbers. (See #40) 2014-04-10 13:22:33 -03:00
Hisham Muhammad 96858744b5 Avoid "else" trick with #ifdef, hopefully makes code easier to follow. 2014-04-09 23:14:41 -03:00
Hisham Muhammad 5d6ad853fa Support for very large numbers, now tested on a 64-bit machine. 2014-04-09 22:49:36 -03:00
Hisham Muhammad 127f847ca5 Support really large numbers on 64-bit architectures; first try. 2014-04-09 22:32:54 -03:00
Hisham Muhammad 19b438de10 Improve discoverability of the expand/collapse feature.
It is now accessible via F6 when on tree view (as a bonus, it is
now also reachable via the mouse). The function bar now dynamically
changes to reflect the toggle nature of the tree-view mode (F5)
and the F6 key serves as expand/collapse when on tree mode,
and its previous behavior of bringing up the "Sort By" menu
(which only made sense on non-tree mode). Users wishing to go to
the "Sort By" menu straight from Tree View can still do so with the
"<" and ">" keys (the top-compatible keys for sort selection).
2014-04-09 18:02:50 -03:00
Hisham Muhammad af4c412ebf Better support for Home and End keys 2014-04-09 17:47:22 -03:00
Hisham Muhammad cb297af848 Fix invalid access when highlighting basename of threads. 2014-04-09 17:43:54 -03:00
Hisham Muhammad f2e4556b5e Updated icon! 2014-04-09 14:47:58 -03:00
Hisham Muhammad 1d9e1b0118 Add missing check for return value and be more conservative in constructs to avoid future slips of this kind. 2014-04-09 14:47:32 -03:00