47e2cefe02
Update battery API to use NAN on error
2020-09-24 18:06:36 +02:00
c3952e7c20
Use strict function prototypes
...
int foo(); declares a function taking any number of arguments.
2020-09-18 12:28:40 +02:00
b992d52bcf
Increae the size of sysfs power supply path buffers
...
Resolves https://github.com/htop-dev/htop/issues/15
2020-08-28 16:57:21 +10:00
4e2b9f0965
Avoid shadowing warnings
2020-08-25 12:01:56 +02:00
a82fd262d7
Merge branch 'hishamhm-pull-960'
2020-08-20 14:19:53 +10:00
dd33444f7e
Clean up existing whitespace
2019-10-31 11:39:12 -05:00
1886117c72
Linux: fixes sysfs battery discovery
2019-09-07 15:21:04 +01:00
b064d501ae
linux/Battery.c: make sure fd is always closed
...
Detected by Coverity:
https://scan8.coverity.com/reports.htm#v13252/p10402/fileInstanceId=22093957&defectInstanceId=7543348&mergedDefectId=174180
2018-02-18 10:21:22 -03:00
b0588d90ff
parseBatInfo: check `line` for NULL before passing it to String_getToken()
2018-02-04 17:04:47 +01:00
09e241fb12
Security review: check results of snprintf.
...
Calls marked with xSnprintf shouldn't fail.
Abort program cleanly if any of them does.
2017-07-27 16:07:50 -03:00
f205f7004c
Use regular readdir since readdir_r is deprecated and newer GCC complains.
2017-07-26 15:35:39 -03:00
bb8dec1582
Cap battery at 100%.
...
Apparently invalid results can be returned by buggy drivers in old laptops,
as reported by @thukydides. See #596 .
2017-02-15 22:47:03 -02:00
bf35921abb
Optimize Strings_startWith()
...
Use strncmp() combined with a strlen() will give better performance
than a strstr in worst case. Especially when the match prefix is a
constant and not a variable.
While we are at it, replace the match() function in linux/Battery.c,
which uses a naive algorithm, with a macro that does better job by
utilizing Strings_startWith().
$ gcc --version | head -n 1
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
$ uname -m
x86_64
$ size htop.old htop.new
text data bss dec hex filename
137929 15112 3776 156817 26491 htop.old
137784 15104 3776 156664 263f8 htop.new
Signed-off-by: Kang-Che Sung <explorer09 @ gmail.com>
2016-08-11 10:49:35 +08:00
0fa03322a9
Dynamically adjust the size of line reads
...
* Dynamically adjust the size of line reads.
* Remove some more uses of fgets with arbitrary sizes.
* Fix reading of lines and width of n column.
Fixes #514 .
2016-06-19 18:55:35 -03:00
b54d2dde40
Check for failure in allocations.
2016-02-02 15:53:02 +01:00
5e602f18d5
Rename String to StringUtils.
...
Fixes building on case-insensitive filesystems where String.h gets confused with <string.h>.
From d734dacea0a10d0465dad4e95b3421511e7da112 Mon Sep 17 00:00:00 2001
From: David Hunt <dhunt@iolanthe.attlocal.net>
Date: Sat, 11 Jul 2015 20:56:31 -0500
Subject: [PATCH 1/8] Rename String to StringUtils
2015-08-19 13:45:20 -03:00
50000d808e
Silence warnings reported in #70 .
2015-02-23 03:34:06 -03:00
c2108e5a48
Another mega-patch for the refactoring process.
...
Kinda runs, but functionality from the original main loop
is still missing. Patience.
2015-01-23 03:08:21 -02:00
430c7c9a9b
Move platform-dependent parts of Linux battery meter.
2014-11-27 21:04:57 -02:00
Benny Baumann