Christian Göttsche
c150e4bde9
Enable -Wformat=2
...
Now that the global format variable Process_pidFormat is gone, enable
the compiler warning -Wformat=2.
2020-12-19 21:13:32 +01:00
Christian Göttsche
e1ce141bc3
Use size_t as len type for Meter_UpdateValues
...
Most of the time the parameter is passed to snprintf type functions
2020-12-06 16:03:44 +01:00
Benny Baumann
83bf8cfad6
Make casing of N/A consistent (majority was N/A)
2020-11-26 22:58:34 +01:00
Nathan Scott
0eb3c7589d
Merge individual Battery.[ch] files into Platform.[ch]
...
Small changes from review - keep headers sorted and keep local
variable declarations at the top of source files.
2020-11-18 10:17:33 +11:00
Nathan Scott
ea9622b8c9
Merge individual Battery.[ch] files into Platform.[ch]
...
Consistent with everything else involving platform-specific
calls from core htop code.
2020-11-18 10:17:33 +11:00
Benny Baumann
61e14d4bb2
Spacing around operators
2020-11-02 22:15:01 +01:00
Benny Baumann
0f5262917f
Make all required includes explicit
...
Information as seen by IWYU 0.12 + clang 9 on Linux
2020-10-18 20:09:05 +02:00
Benny Baumann
872e542f4e
Rename StringUtils.[ch] to XUtils.[ch]
2020-10-16 20:30:21 +02:00
Christian Göttsche
ba282cfe19
Mark Object instances const
2020-10-07 13:01:53 +02:00
Daniel Lange
079c2abf8e
Update License consistently to GPLv2 as per COPYING file
2020-10-05 10:13:12 +02:00
Christian Göttsche
7ae967a04b
Drop redundant return statements
2020-09-29 10:44:42 +02:00
Christian Göttsche
6db2d52261
Covert Meter attributes to file-local constant arrays
2020-09-29 10:44:42 +02:00
Benny Baumann
47e2cefe02
Update battery API to use NAN on error
2020-09-24 18:06:36 +02:00
Zev Weiss
a1a027b9bd
Axe automated header generation.
...
Reasoning:
- implementation was unsound -- broke down when I added a fairly
basic macro definition expanding to a struct initializer in a *.c
file.
- made it way too easy (e.g. via otherwise totally innocuous git
commands) to end up with timestamps such that it always ran
MakeHeader.py but never used its output, leading to overbuild noise
when running what should be a null 'make'.
- but mostly: it's just an awkward way of dealing with C code.
2020-09-03 11:58:58 -05:00
Daniel Flanagan
dd33444f7e
Clean up existing whitespace
2019-10-31 11:39:12 -05:00
Hisham Muhammad
09e241fb12
Security review: check results of snprintf.
...
Calls marked with xSnprintf shouldn't fail.
Abort program cleanly if any of them does.
2017-07-27 16:07:50 -03:00
Explorer09
9dea20e068
Rename Meter.setValues() functions to updateValues()
...
Rationale (copied from htop issue #471 ):
The function name "setValues" is misleading. For most OOP (object-
oriented programming) contexts, setXXX functions mean they will change
some member variables of an object into something specified in
function arguments. But in the *Meter_setValues() case, the new values
are not from the arguments, but from a hard-coded source. The caller
is not supposed to change the values[] to anything it likes, but
rather to "update" the values from the source. Hence, updateValues is
a better name for this family of functions.
2016-05-04 13:39:26 +08:00
Explorer09
99fb3070a2
Explicit "maxItems" property of meters
...
Two changes in this commit:
- All meters now explicitly specify "maxItems" property, even for just
1 item. (Exception is "container" CPU meter classes, which use
CUSTOM_METERMODE.)
- "maxItems" being 0 is now allowed. This will let bar meters and graph
meters render an empty meter.
2016-03-11 10:54:34 +08:00
David Hunt
5e602f18d5
Rename String to StringUtils.
...
Fixes building on case-insensitive filesystems where String.h gets confused with <string.h>.
From d734dacea0a10d0465dad4e95b3421511e7da112 Mon Sep 17 00:00:00 2001
From: David Hunt <dhunt@iolanthe.attlocal.net>
Date: Sat, 11 Jul 2015 20:56:31 -0500
Subject: [PATCH 1/8] Rename String to StringUtils
2015-08-19 13:45:20 -03:00
Hisham Muhammad
5c8b83405b
Merge branch 'master' into wip
...
Conflicts:
Process.c
Process.h
linux/LinuxProcess.c
linux/LinuxProcess.h
linux/LinuxProcessList.c
unsupported/Platform.c
unsupported/Platform.h
2015-03-16 03:22:33 -03:00
Hisham Muhammad
9780c312f4
Fix allocation of processes. Closes #166 .
...
Conflicts:
Process.c
Process.h
ProcessList.c
ScreenManager.c
linux/LinuxProcessList.c
2015-02-23 01:13:40 -03:00
Hisham Muhammad
c2108e5a48
Another mega-patch for the refactoring process.
...
Kinda runs, but functionality from the original main loop
is still missing. Patience.
2015-01-23 03:08:21 -02:00
Hisham Muhammad
430c7c9a9b
Move platform-dependent parts of Linux battery meter.
2014-11-27 21:04:57 -02:00
Hisham Muhammad
9eec37c432
More sanity checks.
2014-04-24 19:54:06 -03:00
Hisham Muhammad
50b701258d
Make static analyzers happy.
2014-04-24 19:46:10 -03:00
Hisham Muhammad
814ce89b45
Oops, fix use of memset.
2014-04-24 19:44:41 -03:00
Hisham Muhammad
659251c501
Fix array limit.
2014-04-24 19:43:27 -03:00
Hisham Muhammad
2fdebf6a29
Remove useless test.
2014-04-24 12:16:21 -03:00
Hisham Muhammad
b1564c2be9
Refactor and fix resource leaks.
2014-04-22 18:19:01 -03:00
Hisham Muhammad
c1e0f6e17c
BUGFIX: Fix crash when adding meters and toggling detailed CPU time.
...
See https://bugzilla.redhat.com/show_bug.cgi?id=987805 for details.
(thanks to Dawid Gajownik for the detailed analysis!)
2014-01-16 01:40:47 -02:00
Hisham Muhammad
00b324bfc1
Changes in object model: separate class objects to store vtable. Also, nicer UTF-8 display of big numbers.
2012-12-05 15:12:20 +00:00
Hisham Muhammad
58676d7001
minor style cleanups
2012-02-02 22:03:07 +00:00
Hisham Muhammad
45f7a4fc8d
Remove old memory debugging routines. We have Valgrind nowadays.
2011-12-26 22:04:29 +00:00
Hisham Muhammad
84281bdc44
major header cleanup
2011-12-26 21:35:57 +00:00
Hisham Muhammad
d1b1cbc757
cleanups and fixes, thanks to cppcheck and gcc -Wextra
2011-10-25 00:05:46 +00:00
Hisham Muhammad
300caa076e
Tempus fugit.
2011-05-26 16:35:07 +00:00
Hisham Muhammad
3fcbcbfda6
Improve battery meter support (thanks to Richard W.) Closes #3063541 .
2010-11-20 19:13:12 +00:00
Hisham Muhammad
a600d5a6e9
Tempus fugit.
2010-02-25 02:08:18 +00:00
Hisham Muhammad
02a30bfecd
warning fixes
2010-02-25 01:43:18 +00:00
Hisham Muhammad
c9e59b4a33
minor tweaks by David Weber
2010-02-22 20:54:01 +00:00
Hisham Muhammad
1371ee28a7
don't use unbounded operations
2009-06-02 04:49:26 +00:00
Hisham Muhammad
20bb68824d
updated battery meter code from Ian Hands, slightly tweaked
2009-04-27 21:48:09 +00:00
Hisham Muhammad
11931f1bc8
ACPI Battery meter
...
contributed by Ian Hands
2008-09-23 06:21:28 +00:00