Bump version, changelog for minor htop-3.0.2 release

There have been too many bugs reported in vim_mode, and
the proposed fixes are increasingly fragile - hence we
have decided to back it out for now.  For reference:

   https://github.com/htop-dev/htop/issues/69
   https://github.com/htop-dev/htop/pull/37
   https://github.com/htop-dev/htop/pull/106

The whitespace changes also arrived in commit 12805f61d
not sure what that was about, but backed out as well.

.github/workflows/ci.yml

@@ -40,20 +40,20 @@ jobs:
     - name: Distcheck
       run: make distcheck DISTCHECK_CONFIGURE_FLAGS=--enable-werror
 
-  build-ubuntu-latest-hwloc:
+  build-ubuntu-latest-full-featured:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
     - name: Install Dependencies
-      run: sudo apt-get install libncursesw5-dev libhwloc-dev
+      run: sudo apt-get install libncursesw5-dev libhwloc-dev libnl-3-dev libnl-genl-3-dev
     - name: Bootstrap
       run: ./autogen.sh
     - name: Configure
-      run: ./configure --enable-werror --enable-hwloc
+      run: ./configure --enable-werror --enable-openvz --enable-cgroup --enable-vserver --enable-ancient-vserver --enable-taskstats --enable-unicode --enable-linux-affinity --enable-hwloc --enable-setuid --enable-delayacct
     - name: Build
       run: make
     - name: Distcheck
-      run: make distcheck DISTCHECK_CONFIGURE_FLAGS='--enable-werror --enable-hwloc'
+      run: make distcheck DISTCHECK_CONFIGURE_FLAGS='--enable-werror --enable-openvz --enable-cgroup --enable-vserver --enable-ancient-vserver --enable-taskstats --enable-unicode --enable-linux-affinity --enable-hwloc --enable-setuid --enable-delayacct'
 
   whitespace_check:
     runs-on: ubuntu-latest

.gitignore

@@ -39,5 +39,4 @@ libtool
 ltmain.sh
 m4/
 missing
-scripts/MakeHeader.py
 stamp-h1

.travis.yml

@@ -5,6 +5,7 @@ compiler:
   - gcc
 
 os:
+  - freebsd
   - linux
   - osx
 

Action.c

@@ -30,38 +30,6 @@ in the source distribution for its full text.
 #include <sys/param.h>
 #include <sys/time.h>
 
-/*{
-
-#include "IncSet.h"
-#include "Settings.h"
-#include "Header.h"
-#include "UsersTable.h"
-#include "ProcessList.h"
-#include "Panel.h"
-
-typedef enum {
-   HTOP_OK = 0x00,
-   HTOP_REFRESH = 0x01,
-   HTOP_RECALCULATE = 0x03, // implies HTOP_REFRESH
-   HTOP_SAVE_SETTINGS = 0x04,
-   HTOP_KEEP_FOLLOWING = 0x08,
-   HTOP_QUIT = 0x10,
-   HTOP_REDRAW_BAR = 0x20,
-   HTOP_UPDATE_PANELHDR = 0x41, // implies HTOP_REFRESH
-} Htop_Reaction;
-
-typedef Htop_Reaction (*Htop_Action)();
-
-typedef struct State_ {
-   Settings* settings;
-   UsersTable* ut;
-   ProcessList* pl;
-   Panel* panel;
-   Header* header;
-} State;
-
-}*/
-
 Object* Action_pickFromVector(State* st, Panel* list, int x, bool followProcess) {
    Panel* panel = st->panel;
    Header* header = st->header;
@@ -320,6 +288,7 @@ static Htop_Reaction actionSetAffinity(State* st) {
    if (!affinity1) return HTOP_OK;
    int width;
    Panel* affinityPanel = AffinityPanel_new(st->pl, affinity1, &width);
+   width += 1; /* we add a gap between the panels */
    Affinity_delete(affinity1);
 
    void* set = Action_pickFromVector(st, affinityPanel, width, true);

Action.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Action
 #define HEADER_Action
 /*
@@ -9,13 +7,11 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-
-#include "IncSet.h"
-#include "Settings.h"
 #include "Header.h"
-#include "UsersTable.h"
-#include "ProcessList.h"
 #include "Panel.h"
+#include "ProcessList.h"
+#include "Settings.h"
+#include "UsersTable.h"
 
 typedef enum {
    HTOP_OK = 0x00,
@@ -38,20 +34,14 @@ typedef struct State_ {
    Header* header;
 } State;
 
+Object* Action_pickFromVector(State* st, Panel* list, int x, bool followProcess);
 
-extern Object* Action_pickFromVector(State* st, Panel* list, int x, bool followProcess);
+bool Action_setUserOnly(const char* userName, uid_t* userId);
 
-// ----------------------------------------
+Htop_Reaction Action_setSortKey(Settings* settings, ProcessField sortKey);
 
-extern bool Action_setUserOnly(const char* userName, uid_t* userId);
+Htop_Reaction Action_follow(State* st);
 
-extern Htop_Reaction Action_setSortKey(Settings* settings, ProcessField sortKey);
-
-// ----------------------------------------
-
-extern Htop_Reaction Action_follow(State* st);
-
-
-extern void Action_setBindings(Htop_Action* keys);
+void Action_setBindings(Htop_Action* keys);
 
 #endif

Affinity.c

@@ -21,18 +21,6 @@ in the source distribution for its full text.
 #include <sched.h>
 #endif
 
-/*{
-#include "Process.h"
-#include "ProcessList.h"
-
-typedef struct Affinity_ {
-   ProcessList* pl;
-   int size;
-   int used;
-   int* cpus;
-} Affinity;
-
-}*/
 
 Affinity* Affinity_new(ProcessList* pl) {
    Affinity* this = xCalloc(1, sizeof(Affinity));

Affinity.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Affinity
 #define HEADER_Affinity
 /*
@@ -10,15 +8,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#ifdef HAVE_LIBHWLOC
-#if __linux__
-#define HTOP_HWLOC_CPUBIND_FLAG HWLOC_CPUBIND_THREAD
-#else
-#define HTOP_HWLOC_CPUBIND_FLAG HWLOC_CPUBIND_PROCESS
-#endif
-#elif HAVE_LINUX_AFFINITY
-#endif
-
 #include "Process.h"
 #include "ProcessList.h"
 
@@ -29,24 +18,17 @@ typedef struct Affinity_ {
    int* cpus;
 } Affinity;
 
+Affinity* Affinity_new(ProcessList* pl);
 
-extern Affinity* Affinity_new(ProcessList* pl);
+void Affinity_delete(Affinity* this);
 
-extern void Affinity_delete(Affinity* this);
+void Affinity_add(Affinity* this, int id);
 
-extern void Affinity_add(Affinity* this, int id);
+#if defined(HAVE_LIBHWLOC) || defined(HAVE_LINUX_AFFINITY)
 
-#ifdef HAVE_LIBHWLOC
+Affinity* Affinity_get(Process* proc, ProcessList* pl);
 
-extern Affinity* Affinity_get(Process* proc, ProcessList* pl);
-
-extern bool Affinity_set(Process* proc, Arg arg);
-
-#elif HAVE_LINUX_AFFINITY
-
-extern Affinity* Affinity_get(Process* proc, ProcessList* pl);
-
-extern bool Affinity_set(Process* proc, Arg arg);
+bool Affinity_set(Process* proc, Arg arg);
 
 #endif
 

AffinityPanel.c

@@ -17,17 +17,10 @@ in the source distribution for its full text.
 #include <hwloc.h>
 #endif
 
-/*{
-#include "Panel.h"
-#include "Affinity.h"
-#include "ProcessList.h"
-
-}*/
-
 typedef struct MaskItem_ {
    Object super;
    const char* text;
-   const char* indent;
+   const char* indent; /* used also as an condition whether this is a tree node */
    int value; /* tri-state: 0 - off, 1 - some set, 2 - all set */
    int sub_tree; /* tri-state: 0 - no sub-tree, 1 - open sub-tree, 2 - closed sub-tree */
    Vector *children;
@@ -55,20 +48,21 @@ static void MaskItem_delete(Object* cast) {
 static void MaskItem_display(Object* cast, RichString* out) {
    MaskItem* this = (MaskItem*)cast;
    assert (this != NULL);
+   RichString_append(out, CRT_colors[CHECK_BOX], "[");
    if (this->value == 2)
-      RichString_append(out, CRT_colors[CHECK_MARK], CRT_checkStr[CHECK_STR_FULL]);
+      RichString_append(out, CRT_colors[CHECK_MARK], "x");
    else if (this->value == 1)
-      RichString_append(out, CRT_colors[CHECK_MARK], CRT_checkStr[CHECK_STR_PARTIAL]);
+      RichString_append(out, CRT_colors[CHECK_MARK], "o");
    else
-      RichString_append(out, CRT_colors[CHECK_MARK], CRT_checkStr[CHECK_STR_NONE]);
+      RichString_append(out, CRT_colors[CHECK_MARK], " ");
+   RichString_append(out, CRT_colors[CHECK_BOX], "]");
    RichString_append(out, CRT_colors[CHECK_TEXT], " ");
-   if (this->indent)
+   if (this->indent) {
       RichString_append(out, CRT_colors[PROCESS_TREE], this->indent);
-   if (this->sub_tree) {
       RichString_append(out, CRT_colors[PROCESS_TREE],
-                        this->sub_tree == 1
-                        ? CRT_collapStr[COLLAP_STR_OPEN]
-                        : CRT_collapStr[COLLAP_STR_CLOSED]);
+                        this->sub_tree == 2
+                        ? CRT_treeStr[TREE_STR_OPEN]
+                        : CRT_treeStr[TREE_STR_SHUT]);
       RichString_append(out, CRT_colors[CHECK_TEXT], " ");
    }
    RichString_append(out, CRT_colors[CHECK_TEXT], this->text);
@@ -84,7 +78,7 @@ static ObjectClass MaskItem_class = {
 static MaskItem* MaskItem_newMask(const char* text, const char* indent, hwloc_bitmap_t cpuset, bool owner) {
    MaskItem* this = AllocThis(MaskItem);
    this->text = xStrdup(text);
-   this->indent = xStrdup(indent);
+   this->indent = xStrdup(indent); /* nonnull for tree node */
    this->value = 0;
    this->ownCpuset = owner;
    this->cpuset = cpuset;
@@ -98,7 +92,7 @@ static MaskItem* MaskItem_newMask(const char* text, const char* indent, hwloc_bi
 static MaskItem* MaskItem_newSingleton(const char* text, int cpu, bool isSet) {
    MaskItem* this = AllocThis(MaskItem);
    this->text = xStrdup(text);
-   this->indent = NULL;
+   this->indent = NULL; /* not a tree node */
    this->sub_tree = 0;
    this->children = Vector_new(Class(MaskItem), true, DEFAULT_SIZE);
 
@@ -260,7 +254,7 @@ static HandlerResult AffinityPanel_eventHandler(Panel* super, int ch) {
 
 static MaskItem *AffinityPanel_addObject(AffinityPanel* this, hwloc_obj_t obj, unsigned indent, MaskItem *parent) {
    const char* type_name = hwloc_obj_type_string(obj->type);
-   const char* index_prefix = " #";
+   const char* index_prefix = "#";
    unsigned depth = obj->depth;
    unsigned index = obj->logical_index;
    size_t off = 0, left = 10 * depth;
@@ -279,14 +273,13 @@ static MaskItem *AffinityPanel_addObject(AffinityPanel* this, hwloc_obj_t obj, u
          size_t len = strlen(&indent_buf[off]);
          off += len, left -= len;
       }
-      xSnprintf(&indent_buf[off], left, "%s%s ",
-             obj->next_sibling ? CRT_treeStr[TREE_STR_RTEE] : CRT_treeStr[TREE_STR_BEND],
-             CRT_treeStr[TREE_STR_HORZ]);
+      xSnprintf(&indent_buf[off], left, "%s",
+             obj->next_sibling ? CRT_treeStr[TREE_STR_RTEE] : CRT_treeStr[TREE_STR_BEND]);
       size_t len = strlen(&indent_buf[off]);
       off += len, left -= len;
    }
 
-   xSnprintf(buf, 64, "%s%s%u", type_name, index_prefix, index);
+   xSnprintf(buf, 64, "%s %s%u", type_name, index_prefix, index);
 
    MaskItem *item = MaskItem_newMask(buf, indent_buf, obj->complete_cpuset, false);
    if (parent)
@@ -302,8 +295,8 @@ static MaskItem *AffinityPanel_addObject(AffinityPanel* this, hwloc_obj_t obj, u
          item->sub_tree = 2;
    }
 
-   /* "[x] " + "|- " * depth + ("[+] ")? + name */
-   unsigned width = (CRT_utf8 ? 2 : 4) + 3 * depth + (item->sub_tree ? (CRT_utf8 ? 2 : 4) : 0) + strlen(buf);
+   /* "[x] " + "|- " * depth + ("- ")?(if root node) + name */
+   unsigned width = 4 + 3 * depth + (2 * !depth) + strlen(buf);
    if (width > this->width)
       this->width = width;
 
@@ -352,7 +345,9 @@ Panel* AffinityPanel_new(ProcessList* pl, Affinity* affinity, int* width) {
    Panel_init(super, 1, 1, 1, 1, Class(MaskItem), false, FunctionBar_new(AffinityPanelFunctions, AffinityPanelKeys, AffinityPanelEvents));
 
    this->pl = pl;
-   this->width = 15;
+   /* defaults to 15, this also includes the gap between the panels,
+    * but this will be added by the caller */
+   this->width = 14;
 
    this->cpuids   = Vector_new(Class(MaskItem), true, DEFAULT_SIZE);
 
@@ -373,9 +368,9 @@ Panel* AffinityPanel_new(ProcessList* pl, Affinity* affinity, int* width) {
    for (int i = 0; i < pl->cpuCount; i++) {
       char number[16];
       xSnprintf(number, 9, "CPU %d", Settings_cpuId(pl->settings, i));
-      unsigned width = 4 + strlen(number);
-      if (width > this->width)
-         this->width = width;
+      unsigned cpu_width = 4 + strlen(number);
+      if (cpu_width > this->width)
+         this->width = cpu_width;
 
       bool isSet = false;
       if (curCpu < affinity->used && affinity->cpus[curCpu] == i) {

AffinityPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_AffinityPanel
 #define HEADER_AffinityPanel
 /*
@@ -9,32 +7,14 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#ifdef HAVE_LIBHWLOC
-#endif
-
 #include "Panel.h"
 #include "Affinity.h"
 #include "ProcessList.h"
 
-
-
-#ifdef HAVE_LIBHWLOC
-
-#endif
-
-
-#ifdef HAVE_LIBHWLOC
-
-#endif
-
-#ifdef HAVE_LIBHWLOC
-
-#endif
-
 extern PanelClass AffinityPanel_class;
 
-extern Panel* AffinityPanel_new(ProcessList* pl, Affinity* affinity, int* width);
+Panel* AffinityPanel_new(ProcessList* pl, Affinity* affinity, int* width);
 
-extern Affinity* AffinityPanel_getAffinity(Panel* super, ProcessList* pl);
+Affinity* AffinityPanel_getAffinity(Panel* super, ProcessList* pl);
 
 #endif

AvailableColumnsPanel.c

@@ -16,15 +16,6 @@ in the source distribution for its full text.
 #include <ctype.h>
 #include <string.h>
 
-/*{
-#include "Panel.h"
-
-typedef struct AvailableColumnsPanel_ {
-   Panel super;
-   Panel* columns;
-} AvailableColumnsPanel;
-
-}*/
 
 static const char* const AvailableColumnsFunctions[] = {"      ", "      ", "      ", "      ", "Add   ", "      ", "      ", "      ", "      ", "Done  ", NULL};
 

AvailableColumnsPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_AvailableColumnsPanel
 #define HEADER_AvailableColumnsPanel
 /*
@@ -16,9 +14,8 @@ typedef struct AvailableColumnsPanel_ {
    Panel* columns;
 } AvailableColumnsPanel;
 
-
 extern PanelClass AvailableColumnsPanel_class;
 
-extern AvailableColumnsPanel* AvailableColumnsPanel_new(Panel* columns);
+AvailableColumnsPanel* AvailableColumnsPanel_new(Panel* columns);
 
 #endif

AvailableMetersPanel.c

@@ -16,23 +16,6 @@ in the source distribution for its full text.
 #include <assert.h>
 #include <stdlib.h>
 
-/*{
-#include "Settings.h"
-#include "Panel.h"
-#include "ScreenManager.h"
-#include "ProcessList.h"
-
-typedef struct AvailableMetersPanel_ {
-   Panel super;
-   ScreenManager* scr;
-
-   Settings* settings;
-   Header* header;
-   Panel* leftPanel;
-   Panel* rightPanel;
-} AvailableMetersPanel;
-
-}*/
 
 static void AvailableMetersPanel_delete(Object* object) {
    Panel* super = (Panel*) object;

AvailableMetersPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_AvailableMetersPanel
 #define HEADER_AvailableMetersPanel
 /*
@@ -24,9 +22,8 @@ typedef struct AvailableMetersPanel_ {
    Panel* rightPanel;
 } AvailableMetersPanel;
 
-
 extern PanelClass AvailableMetersPanel_class;
 
-extern AvailableMetersPanel* AvailableMetersPanel_new(Settings* settings, Header* header, Panel* leftMeters, Panel* rightMeters, ScreenManager* scr, ProcessList* pl);
+AvailableMetersPanel* AvailableMetersPanel_new(Settings* settings, Header* header, Panel* leftMeters, Panel* rightMeters, ScreenManager* scr, ProcessList* pl);
 
 #endif

BatteryMeter.c

@@ -18,15 +18,6 @@ This meter written by Ian P. Hands (iphands@gmail.com, ihands@redhat.com).
 #include <string.h>
 #include <stdlib.h>
 
-/*{
-#include "Meter.h"
-
-typedef enum ACPresence_ {
-   AC_ABSENT,
-   AC_PRESENT,
-   AC_ERROR
-} ACPresence;
-}*/
 
 int BatteryMeter_attributes[] = {
    BATTERY

BatteryMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_BatteryMeter
 #define HEADER_BatteryMeter
 /*

CPUMeter.c

@@ -16,35 +16,10 @@ in the source distribution for its full text.
 #include <string.h>
 #include <math.h>
 
-/*{
-#include "Meter.h"
-
-typedef enum {
-   CPU_METER_NICE = 0,
-   CPU_METER_NORMAL = 1,
-   CPU_METER_KERNEL = 2,
-   CPU_METER_IRQ = 3,
-   CPU_METER_SOFTIRQ = 4,
-   CPU_METER_STEAL = 5,
-   CPU_METER_GUEST = 6,
-   CPU_METER_IOWAIT = 7,
-   CPU_METER_FREQUENCY = 8,
-   CPU_METER_ITEMCOUNT = 9, // number of entries in this enum
-} CPUMeterValues;
-
-}*/
-
 int CPUMeter_attributes[] = {
    CPU_NICE, CPU_NORMAL, CPU_SYSTEM, CPU_IRQ, CPU_SOFTIRQ, CPU_STEAL, CPU_GUEST, CPU_IOWAIT
 };
 
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
 static void CPUMeter_init(Meter* this) {
    int cpu = this->param;
    if (this->pl->cpuCount > 1) {
@@ -65,18 +40,12 @@ static void CPUMeter_updateValues(Meter* this, char* buffer, int size) {
    memset(this->values, 0, sizeof(double) * CPU_METER_ITEMCOUNT);
    double percent = Platform_setCPUValues(this, cpu);
    if (this->pl->settings->showCPUFrequency) {
-      /* Initial frequency is in MHz. Emit it as GHz if it's larger than 1000MHz */
       double cpuFrequency = this->values[CPU_METER_FREQUENCY];
-      char unit = 'M';
       char cpuFrequencyBuffer[16];
       if (cpuFrequency < 0) {
          xSnprintf(cpuFrequencyBuffer, sizeof(cpuFrequencyBuffer), "N/A");
       } else {
-         if (cpuFrequency > 1000) {
-            cpuFrequency /= 1000;
-            unit = 'G';
-         }
-         xSnprintf(cpuFrequencyBuffer, sizeof(cpuFrequencyBuffer), "%.3f%cHz", cpuFrequency, unit);
+         xSnprintf(cpuFrequencyBuffer, sizeof(cpuFrequencyBuffer), "%.0fMHz", cpuFrequency);
       }
       if (this->pl->settings->showCPUUsage) {
          xSnprintf(buffer, size, "%5.1f%% %s", percent, cpuFrequencyBuffer);

CPUMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_CPUMeter
 #define HEADER_CPUMeter
 /*
@@ -24,16 +22,8 @@ typedef enum {
    CPU_METER_ITEMCOUNT = 9, // number of entries in this enum
 } CPUMeterValues;
 
-
 extern int CPUMeter_attributes[];
 
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
 extern MeterClass CPUMeter_class;
 
 extern MeterClass AllCPUsMeter_class;

CRT.c

@@ -39,128 +39,6 @@ in the source distribution for its full text.
 #define ColorPairGrayBlack ColorPair(Magenta,Magenta)
 #define ColorIndexGrayBlack ColorIndex(Magenta,Magenta)
 
-#define KEY_WHEELUP KEY_F(20)
-#define KEY_WHEELDOWN KEY_F(21)
-#define KEY_RECLICK KEY_F(22)
-
-//#link curses
-
-/*{
-#include <stdbool.h>
-
-typedef enum TreeStr_ {
-   TREE_STR_HORZ,
-   TREE_STR_VERT,
-   TREE_STR_RTEE,
-   TREE_STR_BEND,
-   TREE_STR_TEND,
-   TREE_STR_OPEN,
-   TREE_STR_SHUT,
-   TREE_STR_COUNT
-} TreeStr;
-
-typedef enum CheckStr_ {
-   CHECK_STR_NONE,
-   CHECK_STR_PARTIAL,
-   CHECK_STR_FULL,
-   CHECK_STR_COUNT
-} CheckStr;
-
-typedef enum CollapStr_ {
-   COLLAP_STR_OPEN,
-   COLLAP_STR_CLOSED,
-   COLLAP_STR_COUNT
-} CollapStr;
-
-typedef enum ColorSchemes_ {
-   COLORSCHEME_DEFAULT = 0,
-   COLORSCHEME_MONOCHROME = 1,
-   COLORSCHEME_BLACKONWHITE = 2,
-   COLORSCHEME_LIGHTTERMINAL = 3,
-   COLORSCHEME_MIDNIGHT = 4,
-   COLORSCHEME_BLACKNIGHT = 5,
-   COLORSCHEME_BROKENGRAY = 6,
-   LAST_COLORSCHEME = 7,
-} ColorSchemes;
-
-typedef enum ColorElements_ {
-   RESET_COLOR,
-   DEFAULT_COLOR,
-   FUNCTION_BAR,
-   FUNCTION_KEY,
-   FAILED_SEARCH,
-   PANEL_HEADER_FOCUS,
-   PANEL_HEADER_UNFOCUS,
-   PANEL_SELECTION_FOCUS,
-   PANEL_SELECTION_FOLLOW,
-   PANEL_SELECTION_UNFOCUS,
-   LARGE_NUMBER,
-   METER_TEXT,
-   METER_VALUE,
-   LED_COLOR,
-   UPTIME,
-   BATTERY,
-   TASKS_RUNNING,
-   SWAP,
-   PROCESS,
-   PROCESS_SHADOW,
-   PROCESS_TAG,
-   PROCESS_MEGABYTES,
-   PROCESS_TREE,
-   PROCESS_R_STATE,
-   PROCESS_D_STATE,
-   PROCESS_BASENAME,
-   PROCESS_HIGH_PRIORITY,
-   PROCESS_LOW_PRIORITY,
-   PROCESS_THREAD,
-   PROCESS_THREAD_BASENAME,
-   BAR_BORDER,
-   BAR_SHADOW,
-   GRAPH_1,
-   GRAPH_2,
-   MEMORY_USED,
-   MEMORY_BUFFERS,
-   MEMORY_BUFFERS_TEXT,
-   MEMORY_CACHE,
-   LOAD,
-   LOAD_AVERAGE_FIFTEEN,
-   LOAD_AVERAGE_FIVE,
-   LOAD_AVERAGE_ONE,
-   CHECK_MARK,
-   CHECK_TEXT,
-   CLOCK,
-   HELP_BOLD,
-   HOSTNAME,
-   CPU_NICE,
-   CPU_NICE_TEXT,
-   CPU_NORMAL,
-   CPU_SYSTEM,
-   CPU_IOWAIT,
-   CPU_IRQ,
-   CPU_SOFTIRQ,
-   CPU_STEAL,
-   CPU_GUEST,
-   PRESSURE_STALL_TEN,
-   PRESSURE_STALL_SIXTY,
-   PRESSURE_STALL_THREEHUNDRED,
-   ZFS_MFU,
-   ZFS_MRU,
-   ZFS_ANON,
-   ZFS_HEADER,
-   ZFS_OTHER,
-   ZFS_COMPRESSED,
-   ZFS_RATIO,
-   LAST_COLORELEMENT
-} ColorElements;
-
-extern void CRT_fatalError(const char* note) __attribute__ ((noreturn));
-
-extern void CRT_handleSIGSEGV(int sgn);
-
-#define KEY_ALT(x) (KEY_F(64 - 26) + (x - 'A'))
-
-}*/
-
 const char *CRT_treeStrAscii[TREE_STR_COUNT] = {
    "-", // TREE_STR_HORZ
    "|", // TREE_STR_VERT
@@ -171,17 +49,6 @@ const char *CRT_treeStrAscii[TREE_STR_COUNT] = {
    "-", // TREE_STR_SHUT
 };
 
-const char *CRT_checkStrAscii[CHECK_STR_COUNT] = {
-   "[ ]", // CHECK_STR_NONE
-   "[o]", // CHECK_STR_PARTIAL
-   "[x]", // CHECK_STR_FULL
-};
-
-const char *CRT_collapStrAscii[COLLAP_STR_COUNT] = {
-   "[-]", // COLLAP_STR_OPEN
-   "[+]", // COLLAP_STR_CLOSED
-};
-
 #ifdef HAVE_LIBNCURSESW
 
 const char *CRT_treeStrUtf8[TREE_STR_COUNT] = {
@@ -190,31 +57,18 @@ const char *CRT_treeStrUtf8[TREE_STR_COUNT] = {
    "\xe2\x94\x9c", // TREE_STR_RTEE ├
    "\xe2\x94\x94", // TREE_STR_BEND └
    "\xe2\x94\x8c", // TREE_STR_TEND ┌
-   "+",            // TREE_STR_OPEN +
+   "+",            // TREE_STR_OPEN +, TODO use 🮯 'BOX DRAWINGS LIGHT HORIZONTAL
+                   // WITH VERTICAL STROKE' (U+1FBAF, "\xf0\x9f\xae\xaf") when
+                   // Unicode 13 is common
    "\xe2\x94\x80", // TREE_STR_SHUT ─
 };
 
-const char *CRT_checkStrUtf8[CHECK_STR_COUNT] = {
-   "\xe2\x98\x90", // CHECK_STR_NONE    ☐
-   "\xe2\x98\x92", // CHECK_STR_PARTIAL ☒
-   "\xe2\x98\x91", // CHECK_STR_FULL    ☑
-};
-
-const char *CRT_collapStrUtf8[COLLAP_STR_COUNT] = {
-   "\xe2\x8a\x9f", // COLLAP_STR_OPEN   ⊟
-   "\xe2\x8a\x9e", // COLLAP_STR_CLOSED ⊞
-};
+bool CRT_utf8 = false;
 
 #endif
 
-bool CRT_utf8 = false;
-
 const char **CRT_treeStr = CRT_treeStrAscii;
 
-const char **CRT_checkStr = CRT_checkStrAscii;
-
-const char **CRT_collapStr = CRT_collapStrAscii;
-
 static bool CRT_hasColors;
 
 int CRT_delay = 0;
@@ -267,7 +121,8 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = A_BOLD,
       [HELP_BOLD] = A_BOLD | ColorPair(Cyan,Black),
       [CLOCK] = A_BOLD,
-      [CHECK_MARK] = A_BOLD | ColorPair(Cyan,Black),
+      [CHECK_BOX] = ColorPair(Cyan,Black),
+      [CHECK_MARK] = A_BOLD,
       [CHECK_TEXT] = A_NORMAL,
       [HOSTNAME] = A_BOLD,
       [CPU_NICE] = ColorPair(Blue,Black),
@@ -335,7 +190,8 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = A_BOLD,
       [HELP_BOLD] = A_BOLD,
       [CLOCK] = A_BOLD,
-      [CHECK_MARK] = A_BOLD,
+      [CHECK_BOX] = A_BOLD,
+      [CHECK_MARK] = A_NORMAL,
       [CHECK_TEXT] = A_NORMAL,
       [HOSTNAME] = A_BOLD,
       [CPU_NICE] = A_NORMAL,
@@ -403,6 +259,7 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = ColorPair(Black,White),
       [HELP_BOLD] = ColorPair(Blue,White),
       [CLOCK] = ColorPair(Black,White),
+      [CHECK_BOX] = ColorPair(Blue,White),
       [CHECK_MARK] = ColorPair(Black,White),
       [CHECK_TEXT] = ColorPair(Black,White),
       [HOSTNAME] = ColorPair(Black,White),
@@ -471,6 +328,7 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = ColorPair(White,Black),
       [HELP_BOLD] = ColorPair(Blue,Black),
       [CLOCK] = ColorPair(White,Black),
+      [CHECK_BOX] = ColorPair(Blue,Black),
       [CHECK_MARK] = ColorPair(Black,Black),
       [CHECK_TEXT] = ColorPair(Black,Black),
       [HOSTNAME] = ColorPair(White,Black),
@@ -539,7 +397,8 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = A_BOLD | ColorPair(White,Blue),
       [HELP_BOLD] = A_BOLD | ColorPair(Cyan,Blue),
       [CLOCK] = ColorPair(White,Blue),
-      [CHECK_MARK] = A_BOLD | ColorPair(Cyan,Blue),
+      [CHECK_BOX] = ColorPair(Cyan,Blue),
+      [CHECK_MARK] = A_BOLD | ColorPair(White,Blue),
       [CHECK_TEXT] = A_NORMAL | ColorPair(White,Blue),
       [HOSTNAME] = ColorPair(White,Blue),
       [CPU_NICE] = A_BOLD | ColorPair(Cyan,Blue),
@@ -607,6 +466,7 @@ int CRT_colorSchemes[LAST_COLORSCHEME][LAST_COLORELEMENT] = {
       [LOAD] = A_BOLD,
       [HELP_BOLD] = A_BOLD | ColorPair(Cyan,Black),
       [CLOCK] = ColorPair(Green,Black),
+      [CHECK_BOX] = ColorPair(Green,Black),
       [CHECK_MARK] = A_BOLD | ColorPair(Green,Black),
       [CHECK_TEXT] = ColorPair(Cyan,Black),
       [HOSTNAME] = ColorPair(Green,Black),
@@ -686,18 +546,13 @@ void CRT_restorePrivileges() {
 
 #else
 
-/* Turn setuid operations into NOPs */
-
-#ifndef CRT_dropPrivileges
-#define CRT_dropPrivileges()
-#define CRT_restorePrivileges()
-#endif
+// In this case, the setuid operations are defined as macros in CRT.h
 
 #endif
 
 // TODO: pass an instance of Settings instead.
 
-void CRT_init(int delay, int colorScheme) {
+void CRT_init(int delay, int colorScheme, bool allowUnicode) {
    initscr();
    noecho();
    CRT_delay = delay;
@@ -763,14 +618,20 @@ void CRT_init(int delay, int colorScheme) {
    setlocale(LC_CTYPE, "");
 
 #ifdef HAVE_LIBNCURSESW
-   if(strcmp(nl_langinfo(CODESET), "UTF-8") == 0) {
+   if (allowUnicode && strcmp(nl_langinfo(CODESET), "UTF-8") == 0)
       CRT_utf8 = true;
-      CRT_treeStr = CRT_treeStrUtf8;
-      CRT_checkStr = CRT_checkStrUtf8;
-      CRT_collapStr = CRT_collapStrUtf8;
-   }
+   else
+      CRT_utf8 = false;
+#else
+   (void) allowUnicode;
 #endif
 
+   CRT_treeStr =
+#ifdef HAVE_LIBNCURSESW
+      CRT_utf8 ? CRT_treeStrUtf8 :
+#endif
+      CRT_treeStrAscii;
+
 #if NCURSES_MOUSE_VERSION > 1
    mousemask(BUTTON1_RELEASED | BUTTON4_PRESSED | BUTTON5_PRESSED, NULL);
 #else

CRT.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_CRT
 #define HEADER_CRT
 /*
@@ -9,33 +7,12 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#if HAVE_SETUID_ENABLED
-#endif
-
-#define ColorIndex(i,j) ((7-i)*8+j)
-
-#define ColorPair(i,j) COLOR_PAIR(ColorIndex(i,j))
-
-#define Black COLOR_BLACK
-#define Red COLOR_RED
-#define Green COLOR_GREEN
-#define Yellow COLOR_YELLOW
-#define Blue COLOR_BLUE
-#define Magenta COLOR_MAGENTA
-#define Cyan COLOR_CYAN
-#define White COLOR_WHITE
-
-#define ColorPairGrayBlack ColorPair(Magenta,Magenta)
-#define ColorIndexGrayBlack ColorIndex(Magenta,Magenta)
+#include <stdbool.h>
 
 #define KEY_WHEELUP   KEY_F(20)
 #define KEY_WHEELDOWN KEY_F(21)
 #define KEY_RECLICK   KEY_F(22)
 
-//#link curses
-
-#include <stdbool.h>
-
 typedef enum TreeStr_ {
    TREE_STR_HORZ,
    TREE_STR_VERT,
@@ -47,19 +24,6 @@ typedef enum TreeStr_ {
    TREE_STR_COUNT
 } TreeStr;
 
-typedef enum CheckStr_ {
-   CHECK_STR_NONE,
-   CHECK_STR_PARTIAL,
-   CHECK_STR_FULL,
-   CHECK_STR_COUNT
-} CheckStr;
-
-typedef enum CollapStr_ {
-   COLLAP_STR_OPEN,
-   COLLAP_STR_CLOSED,
-   COLLAP_STR_COUNT
-} CollapStr;
-
 typedef enum ColorSchemes_ {
    COLORSCHEME_DEFAULT = 0,
    COLORSCHEME_MONOCHROME = 1,
@@ -114,6 +78,7 @@ typedef enum ColorElements_ {
    LOAD_AVERAGE_FIFTEEN,
    LOAD_AVERAGE_FIVE,
    LOAD_AVERAGE_ONE,
+   CHECK_BOX,
    CHECK_MARK,
    CHECK_TEXT,
    CLOCK,
@@ -141,37 +106,25 @@ typedef enum ColorElements_ {
    LAST_COLORELEMENT
 } ColorElements;
 
-extern void CRT_fatalError(const char* note) __attribute__ ((noreturn));
+void CRT_fatalError(const char* note) __attribute__ ((noreturn));
 
-extern void CRT_handleSIGSEGV(int sgn);
+void CRT_handleSIGSEGV(int sgn);
 
 #define KEY_ALT(x) (KEY_F(64 - 26) + (x - 'A'))
 
 
 extern const char *CRT_treeStrAscii[TREE_STR_COUNT];
 
-extern const char *CRT_checkStrAscii[CHECK_STR_COUNT];
-
-extern const char *CRT_collapStrAscii[COLLAP_STR_COUNT];
-
 #ifdef HAVE_LIBNCURSESW
 
 extern const char *CRT_treeStrUtf8[TREE_STR_COUNT];
 
-extern const char *CRT_checkStrUtf8[CHECK_STR_COUNT];
-
-extern const char *CRT_collapStrUtf8[COLLAP_STR_COUNT];
+extern bool CRT_utf8;
 
 #endif
 
-extern bool CRT_utf8;
-
 extern const char **CRT_treeStr;
 
-extern const char **CRT_checkStr;
-
-extern const char **CRT_collapStr;
-
 extern int CRT_delay;
 
 extern int* CRT_colors;
@@ -186,19 +139,15 @@ extern int CRT_scrollWheelVAmount;
 
 extern char* CRT_termType;
 
-// TODO move color scheme to Settings, perhaps?
-
 extern int CRT_colorScheme;
 
 extern void *backtraceArray[128];
 
 #if HAVE_SETUID_ENABLED
 
-#define DIE(msg) do { CRT_done(); fprintf(stderr, msg); exit(1); } while(0)
+void CRT_dropPrivileges();
 
-extern void CRT_dropPrivileges();
-
-extern void CRT_restorePrivileges();
+void CRT_restorePrivileges();
 
 #else
 
@@ -211,20 +160,18 @@ extern void CRT_restorePrivileges();
 
 #endif
 
-// TODO: pass an instance of Settings instead.
+void CRT_init(int delay, int colorScheme, bool allowUnicode);
 
-extern void CRT_init(int delay, int colorScheme);
+void CRT_done();
 
-extern void CRT_done();
+void CRT_fatalError(const char* note);
 
-extern void CRT_fatalError(const char* note);
+int CRT_readKey();
 
-extern int CRT_readKey();
+void CRT_disableDelay();
 
-extern void CRT_disableDelay();
+void CRT_enableDelay();
 
-extern void CRT_enableDelay();
-
-extern void CRT_setColors(int colorScheme);
+void CRT_setColors(int colorScheme);
 
 #endif

CategoriesPanel.c

@@ -17,22 +17,6 @@ in the source distribution for its full text.
 #include <assert.h>
 #include <stdlib.h>
 
-/*{
-#include "Panel.h"
-#include "Settings.h"
-#include "ScreenManager.h"
-#include "ProcessList.h"
-
-typedef struct CategoriesPanel_ {
-   Panel super;
-   ScreenManager* scr;
-
-   Settings* settings;
-   Header* header;
-   ProcessList* pl;
-} CategoriesPanel;
-
-}*/
 
 static const char* const CategoriesFunctions[] = {"      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "Done  ", NULL};
 

CategoriesPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_CategoriesPanel
 #define HEADER_CategoriesPanel
 /*
@@ -23,11 +21,10 @@ typedef struct CategoriesPanel_ {
    ProcessList* pl;
 } CategoriesPanel;
 
-
-extern void CategoriesPanel_makeMetersPage(CategoriesPanel* this);
+void CategoriesPanel_makeMetersPage(CategoriesPanel* this);
 
 extern PanelClass CategoriesPanel_class;
 
-extern CategoriesPanel* CategoriesPanel_new(ScreenManager* scr, Settings* settings, Header* header, ProcessList* pl);
+CategoriesPanel* CategoriesPanel_new(ScreenManager* scr, Settings* settings, Header* header, ProcessList* pl);
 
 #endif

ChangeLog

@@ -1,3 +1,27 @@
+What's new in version 3.0.2
+
+* BUGFIX: Drop 'vim_mode' - several issues, needs rethink
+* BUGFIX: fix regression in -u optional-argument handling
+* Build system rework to remove python, header generation
+  (thanks to Zev Weiss and Hugo Musso Gualandi)
+* BUGFIX: report nice level correctly on Solaris
+  (thanks to Dominik Hassler)
+* CI, code quality improvements
+  (thanks to Tobias Kortkamp, Christian Hesse, Benny Baumann)
+
+What's new in version 3.0.1
+
+* Coverity fixes, CI improvements, documentation updates
+* BUGFIX: Fix early exit with longer sysfs battery paths
+* BUGFIX: Improve OOM output, fix sorting
+  (thanks to Christian Göttsche)
+* Rework check buttons and tree open/closed
+  (thanks to Bert Wesarg)
+* Add -U/--no-unicode option to disable unicode
+  (thanks to Christian Hesse)
+* Improvements to the affinity panel
+  (thanks to Bert Wesarg)
+
 What's new in version 3.0.0
 
 * New maintainers - after a prolonged period of inactivity
@@ -5,7 +29,6 @@ What's new in version 3.0.0
   of community maintainers have volunteered to take over a
   fork at https://htop.dev and https://github.com/htop-dev
   to keep the project going.
-
 * Support ZFS ARC statistics
   (thanks to Ross Williams)
 * Support more than 2 smaller CPU meter columns

CheckItem.c

@@ -12,17 +12,6 @@ in the source distribution for its full text.
 #include <assert.h>
 #include <stdlib.h>
 
-/*{
-#include "Object.h"
-
-typedef struct CheckItem_ {
-   Object super;
-   char* text;
-   bool* ref;
-   bool value;
-} CheckItem;
-
-}*/
 
 static void CheckItem_delete(Object* cast) {
    CheckItem* this = (CheckItem*)cast;
@@ -35,11 +24,12 @@ static void CheckItem_delete(Object* cast) {
 static void CheckItem_display(Object* cast, RichString* out) {
    CheckItem* this = (CheckItem*)cast;
    assert (this != NULL);
+   RichString_write(out, CRT_colors[CHECK_BOX], "[");
    if (CheckItem_get(this))
-      RichString_append(out, CRT_colors[CHECK_MARK], CRT_checkStr[CHECK_STR_FULL]);
+      RichString_append(out, CRT_colors[CHECK_MARK], "x");
    else
-      RichString_append(out, CRT_colors[CHECK_MARK], CRT_checkStr[CHECK_STR_NONE]);
-   RichString_append(out, CRT_colors[CHECK_TEXT], " ");
+      RichString_append(out, CRT_colors[CHECK_MARK], " ");
+   RichString_append(out, CRT_colors[CHECK_BOX], "] ");
    RichString_append(out, CRT_colors[CHECK_TEXT], this->text);
 }
 

CheckItem.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_CheckItem
 #define HEADER_CheckItem
 /*
@@ -18,15 +16,14 @@ typedef struct CheckItem_ {
    bool value;
 } CheckItem;
 
-
 extern ObjectClass CheckItem_class;
 
-extern CheckItem* CheckItem_newByRef(char* text, bool* ref);
+CheckItem* CheckItem_newByRef(char* text, bool* ref);
 
-extern CheckItem* CheckItem_newByVal(char* text, bool value);
+CheckItem* CheckItem_newByVal(char* text, bool value);
 
-extern void CheckItem_set(CheckItem* this, bool value);
+void CheckItem_set(CheckItem* this, bool value);
 
-extern bool CheckItem_get(CheckItem* this);
+bool CheckItem_get(CheckItem* this);
 
 #endif

ClockMeter.c

@@ -11,9 +11,6 @@ in the source distribution for its full text.
 
 #include <time.h>
 
-/*{
-#include "Meter.h"
-}*/
 
 int ClockMeter_attributes[] = {
    CLOCK

ClockMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ClockMeter
 #define HEADER_ClockMeter
 /*

ColorsPanel.c

@@ -20,19 +20,6 @@ in the source distribution for its full text.
 // * Add a define in CRT.h that matches the order of the array
 // * Add the colors in CRT_setColors
 
-/*{
-#include "Panel.h"
-#include "Settings.h"
-#include "ScreenManager.h"
-
-typedef struct ColorsPanel_ {
-   Panel super;
-
-   Settings* settings;
-   ScreenManager* scr;
-} ColorsPanel;
-
-}*/
 
 static const char* const ColorsFunctions[] = {"      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "Done  ", NULL};
 

ColorsPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ColorsPanel
 #define HEADER_ColorsPanel
 /*
@@ -9,12 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-// TO ADD A NEW SCHEME:
-// * Increment the size of bool check in ColorsPanel.h
-// * Add the entry in the ColorSchemeNames array below in the file
-// * Add a define in CRT.h that matches the order of the array
-// * Add the colors in CRT_setColors
-
 #include "Panel.h"
 #include "Settings.h"
 #include "ScreenManager.h"
@@ -26,9 +18,8 @@ typedef struct ColorsPanel_ {
    ScreenManager* scr;
 } ColorsPanel;
 
-
 extern PanelClass ColorsPanel_class;
 
-extern ColorsPanel* ColorsPanel_new(Settings* settings, ScreenManager* scr);
+ColorsPanel* ColorsPanel_new(Settings* settings, ScreenManager* scr);
 
 #endif

ColumnsPanel.c

@@ -16,18 +16,6 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <ctype.h>
 
-/*{
-#include "Panel.h"
-#include "Settings.h"
-
-typedef struct ColumnsPanel_ {
-   Panel super;
-
-   Settings* settings;
-   bool moving;
-} ColumnsPanel;
-
-}*/
 
 static const char* const ColumnsFunctions[] = {"      ", "      ", "      ", "      ", "      ", "      ", "MoveUp", "MoveDn", "Remove", "Done  ", NULL};
 

ColumnsPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ColumnsPanel
 #define HEADER_ColumnsPanel
 /*
@@ -19,13 +17,12 @@ typedef struct ColumnsPanel_ {
    bool moving;
 } ColumnsPanel;
 
-
 extern PanelClass ColumnsPanel_class;
 
-extern ColumnsPanel* ColumnsPanel_new(Settings* settings);
+ColumnsPanel* ColumnsPanel_new(Settings* settings);
 
-extern int ColumnsPanel_fieldNameToIndex(const char* name);
+int ColumnsPanel_fieldNameToIndex(const char* name);
 
-extern void ColumnsPanel_update(Panel* super);
+void ColumnsPanel_update(Panel* super);
 
 #endif

DisplayOptionsPanel.c

@@ -14,19 +14,6 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <string.h>
 
-/*{
-#include "Panel.h"
-#include "Settings.h"
-#include "ScreenManager.h"
-
-typedef struct DisplayOptionsPanel_ {
-   Panel super;
-
-   Settings* settings;
-   ScreenManager* scr;
-} DisplayOptionsPanel;
-
-}*/
 
 static const char* const DisplayOptionsFunctions[] = {"      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "Done  ", NULL};
 

DisplayOptionsPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_DisplayOptionsPanel
 #define HEADER_DisplayOptionsPanel
 /*
@@ -20,9 +18,8 @@ typedef struct DisplayOptionsPanel_ {
    ScreenManager* scr;
 } DisplayOptionsPanel;
 
-
 extern PanelClass DisplayOptionsPanel_class;
 
-extern DisplayOptionsPanel* DisplayOptionsPanel_new(Settings* settings, ScreenManager* scr);
+DisplayOptionsPanel* DisplayOptionsPanel_new(Settings* settings, ScreenManager* scr);
 
 #endif

EnvScreen.c

@@ -11,13 +11,6 @@
 #include <string.h>
 #include <unistd.h>
 
-/*{
-#include "InfoScreen.h"
-
-typedef struct EnvScreen_ {
-   InfoScreen super;
-} EnvScreen;
-}*/
 
 InfoScreenClass EnvScreen_class = {
    .super = {
@@ -44,7 +37,7 @@ void EnvScreen_draw(InfoScreen* this) {
 
 void EnvScreen_scan(InfoScreen* this) {
    Panel* panel = this->display;
-   int idx = MAX(Panel_getSelectedIndex(panel), 0);
+   int idx = MAXIMUM(Panel_getSelectedIndex(panel), 0);
 
    Panel_prune(panel);
 

EnvScreen.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_EnvScreen
 #define HEADER_EnvScreen
 
@@ -11,12 +9,12 @@ typedef struct EnvScreen_ {
 
 extern InfoScreenClass EnvScreen_class;
 
-extern EnvScreen* EnvScreen_new(Process* process);
+EnvScreen* EnvScreen_new(Process* process);
 
-extern void EnvScreen_delete(Object* this);
+void EnvScreen_delete(Object* this);
 
-extern void EnvScreen_draw(InfoScreen* this);
+void EnvScreen_draw(InfoScreen* this);
 
-extern void EnvScreen_scan(InfoScreen* this);
+void EnvScreen_scan(InfoScreen* this);
 
 #endif

FunctionBar.c

@@ -14,19 +14,6 @@ in the source distribution for its full text.
 #include <string.h>
 #include <stdlib.h>
 
-/*{
-
-#include <stdbool.h>
-
-typedef struct FunctionBar_ {
-   int size;
-   char** functions;
-   char** keys;
-   int* events;
-   bool staticData;
-} FunctionBar;
-
-}*/
 
 static const char* const FunctionBar_FKeys[] = {"F1", "F2", "F3", "F4", "F5", "F6", "F7", "F8", "F9", "F10", NULL};
 

FunctionBar.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_FunctionBar
 #define HEADER_FunctionBar
 /*
@@ -9,7 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-
 #include <stdbool.h>
 
 typedef struct FunctionBar_ {
@@ -20,20 +17,18 @@ typedef struct FunctionBar_ {
    bool staticData;
 } FunctionBar;
 
+FunctionBar* FunctionBar_newEnterEsc(const char* enter, const char* esc);
 
+FunctionBar* FunctionBar_new(const char* const* functions, const char* const* keys, const int* events);
 
-extern FunctionBar* FunctionBar_newEnterEsc(const char* enter, const char* esc);
+void FunctionBar_delete(FunctionBar* this);
 
-extern FunctionBar* FunctionBar_new(const char* const* functions, const char* const* keys, const int* events);
+void FunctionBar_setLabel(FunctionBar* this, int event, const char* text);
 
-extern void FunctionBar_delete(FunctionBar* this);
+void FunctionBar_draw(const FunctionBar* this, char* buffer);
 
-extern void FunctionBar_setLabel(FunctionBar* this, int event, const char* text);
+void FunctionBar_drawAttr(const FunctionBar* this, char* buffer, int attr);
 
-extern void FunctionBar_draw(const FunctionBar* this, char* buffer);
-
-extern void FunctionBar_drawAttr(const FunctionBar* this, char* buffer, int attr);
-
-extern int FunctionBar_synthesizeEvent(const FunctionBar* this, int pos);
+int FunctionBar_synthesizeEvent(const FunctionBar* this, int pos);
 
 #endif

Hashtable.c

@@ -11,26 +11,6 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <assert.h>
 
-/*{
-#include <stdbool.h>
-
-typedef struct Hashtable_ Hashtable;
-
-typedef void(*Hashtable_PairFunction)(int, void*, void*);
-
-typedef struct HashtableItem {
-   unsigned int key;
-   void* value;
-   struct HashtableItem* next;
-} HashtableItem;
-
-struct Hashtable_ {
-   int size;
-   HashtableItem** buckets;
-   int items;
-   bool owner;
-};
-}*/
 
 #ifdef DEBUG
 

Hashtable.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Hashtable
 #define HEADER_Hashtable
 /*
@@ -30,20 +28,20 @@ struct Hashtable_ {
 
 #ifdef DEBUG
 
-extern int Hashtable_count(Hashtable* this);
+int Hashtable_count(Hashtable* this);
 
 #endif
 
-extern Hashtable* Hashtable_new(int size, bool owner);
+Hashtable* Hashtable_new(int size, bool owner);
 
-extern void Hashtable_delete(Hashtable* this);
+void Hashtable_delete(Hashtable* this);
 
-extern void Hashtable_put(Hashtable* this, unsigned int key, void* value);
+void Hashtable_put(Hashtable* this, unsigned int key, void* value);
 
-extern void* Hashtable_remove(Hashtable* this, unsigned int key);
+void* Hashtable_remove(Hashtable* this, unsigned int key);
 
-extern void* Hashtable_get(Hashtable* this, unsigned int key);
+void* Hashtable_get(Hashtable* this, unsigned int key);
 
-extern void Hashtable_foreach(Hashtable* this, Hashtable_PairFunction f, void* userData);
+void Hashtable_foreach(Hashtable* this, Hashtable_PairFunction f, void* userData);
 
 #endif

Header.c

@@ -16,30 +16,6 @@ in the source distribution for its full text.
 #include <string.h>
 #include <stdlib.h>
 
-/*{
-#include "Meter.h"
-#include "Settings.h"
-#include "Vector.h"
-
-typedef struct Header_ {
-   Vector** columns;
-   Settings* settings;
-   struct ProcessList_* pl;
-   int nrColumns;
-   int pad;
-   int height;
-} Header;
-
-}*/
-
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
-#ifndef Header_forEachColumn
-#define Header_forEachColumn(this_, i_) for (int (i_)=0; (i_) < (this_)->nrColumns; ++(i_))
-#endif
-
 Header* Header_new(struct ProcessList_* pl, Settings* settings, int nrColumns) {
    Header* this = xCalloc(1, sizeof(Header));
    this->columns = xCalloc(nrColumns, sizeof(Vector*));
@@ -211,7 +187,7 @@ int Header_calculateHeight(Header* this) {
          Meter* meter = (Meter*) Vector_get(meters, i);
          height += meter->h;
       }
-      maxHeight = MAX(maxHeight, height);
+      maxHeight = MAXIMUM(maxHeight, height);
    }
    this->height = maxHeight;
    this->pad = pad;

Header.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Header
 #define HEADER_Header
 /*
@@ -22,39 +20,32 @@ typedef struct Header_ {
    int height;
 } Header;
 
-
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
-#ifndef Header_forEachColumn
 #define Header_forEachColumn(this_, i_) for (int (i_)=0; (i_) < (this_)->nrColumns; ++(i_))
-#endif
 
-extern Header* Header_new(struct ProcessList_* pl, Settings* settings, int nrColumns);
+Header* Header_new(struct ProcessList_* pl, Settings* settings, int nrColumns);
 
-extern void Header_delete(Header* this);
+void Header_delete(Header* this);
 
-extern void Header_populateFromSettings(Header* this);
+void Header_populateFromSettings(Header* this);
 
-extern void Header_writeBackToSettings(const Header* this);
+void Header_writeBackToSettings(const Header* this);
 
-extern MeterModeId Header_addMeterByName(Header* this, char* name, int column);
+MeterModeId Header_addMeterByName(Header* this, char* name, int column);
 
-extern void Header_setMode(Header* this, int i, MeterModeId mode, int column);
+void Header_setMode(Header* this, int i, MeterModeId mode, int column);
 
-extern Meter* Header_addMeterByClass(Header* this, MeterClass* type, int param, int column);
+Meter* Header_addMeterByClass(Header* this, MeterClass* type, int param, int column);
 
-extern int Header_size(Header* this, int column);
+int Header_size(Header* this, int column);
 
-extern char* Header_readMeterName(Header* this, int i, int column);
+char* Header_readMeterName(Header* this, int i, int column);
 
-extern MeterModeId Header_readMeterMode(Header* this, int i, int column);
+MeterModeId Header_readMeterMode(Header* this, int i, int column);
 
-extern void Header_reinit(Header* this);
+void Header_reinit(Header* this);
 
-extern void Header_draw(const Header* this);
+void Header_draw(const Header* this);
 
-extern int Header_calculateHeight(Header* this);
+int Header_calculateHeight(Header* this);
 
 #endif

HostnameMeter.c

@@ -11,9 +11,6 @@ in the source distribution for its full text.
 
 #include <unistd.h>
 
-/*{
-#include "Meter.h"
-}*/
 
 int HostnameMeter_attributes[] = {
    HOSTNAME

HostnameMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_HostnameMeter
 #define HEADER_HostnameMeter
 /*

IncSet.c

@@ -7,45 +7,11 @@ in the source distribution for its full text.
 
 #include "IncSet.h"
 #include "StringUtils.h"
-#include "Panel.h"
 #include "ListItem.h"
 #include "CRT.h"
 #include <string.h>
 #include <stdlib.h>
 
-/*{
-
-#include "FunctionBar.h"
-#include "Panel.h"
-#include <stdbool.h>
-
-#define INCMODE_MAX 40
-
-typedef enum {
-   INC_SEARCH = 0,
-   INC_FILTER = 1
-} IncType;
-
-#define IncSet_filter(inc_) (inc_->filtering ? inc_->modes[INC_FILTER].buffer : NULL)
-
-typedef struct IncMode_ {
-   char buffer[INCMODE_MAX+1];
-   int index;
-   FunctionBar* bar;
-   bool isFilter;
-} IncMode;
-
-typedef struct IncSet_ {
-   IncMode modes[2];
-   IncMode* active;
-   FunctionBar* defaultBar;
-   bool filtering;
-   bool found;
-} IncSet;
-
-typedef const char* (*IncMode_GetPanelValue)(Panel*, int);
-
-}*/
 
 static void IncMode_reset(IncMode* mode) {
    mode->index = 0;

IncSet.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_IncSet
 #define HEADER_IncSet
 /*
@@ -9,7 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-
 #include "FunctionBar.h"
 #include "Panel.h"
 #include <stdbool.h>
@@ -40,25 +37,24 @@ typedef struct IncSet_ {
 
 typedef const char* (*IncMode_GetPanelValue)(Panel*, int);
 
+void IncSet_reset(IncSet* this, IncType type);
 
-extern void IncSet_reset(IncSet* this, IncType type);
+IncSet* IncSet_new(FunctionBar* bar);
 
-extern IncSet* IncSet_new(FunctionBar* bar);
+void IncSet_delete(IncSet* this);
 
-extern void IncSet_delete(IncSet* this);
+bool IncSet_next(IncSet* this, IncType type, Panel* panel, IncMode_GetPanelValue getPanelValue);
 
-extern bool IncSet_next(IncSet* this, IncType type, Panel* panel, IncMode_GetPanelValue getPanelValue);
+bool IncSet_prev(IncSet* this, IncType type, Panel* panel, IncMode_GetPanelValue getPanelValue);
 
-extern bool IncSet_prev(IncSet* this, IncType type, Panel* panel, IncMode_GetPanelValue getPanelValue);
+bool IncSet_handleKey(IncSet* this, int ch, Panel* panel, IncMode_GetPanelValue getPanelValue, Vector* lines);
 
-extern bool IncSet_handleKey(IncSet* this, int ch, Panel* panel, IncMode_GetPanelValue getPanelValue, Vector* lines);
+const char* IncSet_getListItemValue(Panel* panel, int i);
 
-extern const char* IncSet_getListItemValue(Panel* panel, int i);
+void IncSet_activate(IncSet* this, IncType type, Panel* panel);
 
-extern void IncSet_activate(IncSet* this, IncType type, Panel* panel);
+void IncSet_drawBar(IncSet* this);
 
-extern void IncSet_drawBar(IncSet* this);
-
-extern int IncSet_synthesizeEvent(IncSet* this, int x);
+int IncSet_synthesizeEvent(IncSet* this, int x);
 
 #endif

InfoScreen.c

@@ -13,42 +13,6 @@
 #include <unistd.h>
 #include <stdarg.h>
 
-/*{
-#include "Process.h"
-#include "Panel.h"
-#include "FunctionBar.h"
-#include "IncSet.h"
-
-typedef struct InfoScreen_ InfoScreen;
-
-typedef void(*InfoScreen_Scan)(InfoScreen*);
-typedef void(*InfoScreen_Draw)(InfoScreen*);
-typedef void(*InfoScreen_OnErr)(InfoScreen*);
-typedef bool(*InfoScreen_OnKey)(InfoScreen*, int);
-
-typedef struct InfoScreenClass_ {
-   ObjectClass super;
-   const InfoScreen_Scan scan;
-   const InfoScreen_Draw draw;
-   const InfoScreen_OnErr onErr;
-   const InfoScreen_OnKey onKey;
-} InfoScreenClass;
-
-#define As_InfoScreen(this_)          ((InfoScreenClass*)(((InfoScreen*)(this_))->super.klass))
-#define InfoScreen_scan(this_)        As_InfoScreen(this_)->scan((InfoScreen*)(this_))
-#define InfoScreen_draw(this_)        As_InfoScreen(this_)->draw((InfoScreen*)(this_))
-#define InfoScreen_onErr(this_)       As_InfoScreen(this_)->onErr((InfoScreen*)(this_))
-#define InfoScreen_onKey(this_, ch_)  As_InfoScreen(this_)->onKey((InfoScreen*)(this_), ch_)
-
-struct InfoScreen_ {
-   Object super;
-   Process* process;
-   Panel* display;
-   FunctionBar* bar;
-   IncSet* inc;
-   Vector* lines;
-};
-}*/
 
 static const char* const InfoScreenFunctions[] = {"Search ", "Filter ", "Refresh", "Done   ", NULL};
 
@@ -80,7 +44,7 @@ void InfoScreen_drawTitled(InfoScreen* this, const char* fmt, ...) {
    va_start(ap, fmt);
    attrset(CRT_colors[METER_TEXT]);
    mvhline(0, 0, ' ', COLS);
-   wmove(stdscr, 0, 0);
+   (void) wmove(stdscr, 0, 0);
    vw_printw(stdscr, fmt, ap);
    attrset(CRT_colors[DEFAULT_COLOR]);
    this->display->needsRedraw = true;

InfoScreen.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_InfoScreen
 #define HEADER_InfoScreen
 
@@ -38,16 +36,16 @@ struct InfoScreen_ {
    Vector* lines;
 };
 
-extern InfoScreen* InfoScreen_init(InfoScreen* this, Process* process, FunctionBar* bar, int height, const char* panelHeader);
+InfoScreen* InfoScreen_init(InfoScreen* this, Process* process, FunctionBar* bar, int height, const char* panelHeader);
 
-extern InfoScreen* InfoScreen_done(InfoScreen* this);
+InfoScreen* InfoScreen_done(InfoScreen* this);
 
-extern void InfoScreen_drawTitled(InfoScreen* this, const char* fmt, ...);
+void InfoScreen_drawTitled(InfoScreen* this, const char* fmt, ...);
 
-extern void InfoScreen_addLine(InfoScreen* this, const char* line);
+void InfoScreen_addLine(InfoScreen* this, const char* line);
 
-extern void InfoScreen_appendLine(InfoScreen* this, const char* line);
+void InfoScreen_appendLine(InfoScreen* this, const char* line);
 
-extern void InfoScreen_run(InfoScreen* this);
+void InfoScreen_run(InfoScreen* this);
 
 #endif

ListItem.c

@@ -15,17 +15,6 @@ in the source distribution for its full text.
 #include <assert.h>
 #include <stdlib.h>
 
-/*{
-#include "Object.h"
-
-typedef struct ListItem_ {
-   Object super;
-   char* value;
-   int key;
-   bool moving;
-} ListItem;
-
-}*/
 
 static void ListItem_delete(Object* cast) {
    ListItem* this = (ListItem*)cast;

ListItem.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ListItem
 #define HEADER_ListItem
 /*
@@ -18,15 +16,14 @@ typedef struct ListItem_ {
    bool moving;
 } ListItem;
 
-
 extern ObjectClass ListItem_class;
 
-extern ListItem* ListItem_new(const char* value, int key);
+ListItem* ListItem_new(const char* value, int key);
 
-extern void ListItem_append(ListItem* this, const char* text);
+void ListItem_append(ListItem* this, const char* text);
 
-extern const char* ListItem_getRef(ListItem* this);
+const char* ListItem_getRef(ListItem* this);
 
-extern long ListItem_compare(const void* cast1, const void* cast2);
+long ListItem_compare(const void* cast1, const void* cast2);
 
 #endif

LoadAverageMeter.c

@@ -10,9 +10,6 @@ in the source distribution for its full text.
 #include "CRT.h"
 #include "Platform.h"
 
-/*{
-#include "Meter.h"
-}*/
 
 int LoadAverageMeter_attributes[] = {
    LOAD_AVERAGE_ONE, LOAD_AVERAGE_FIVE, LOAD_AVERAGE_FIFTEEN

LoadAverageMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_LoadAverageMeter
 #define HEADER_LoadAverageMeter
 /*

Macros.h

@@ -0,0 +1,16 @@
+#ifndef HEADER_Macros
+#define HEADER_Macros
+
+#ifndef MINIMUM
+#define MINIMUM(a, b)		((a) < (b) ? (a) : (b))
+#endif
+
+#ifndef MAXIMUM
+#define MAXIMUM(a, b)		((a) > (b) ? (a) : (b))
+#endif
+
+#ifndef CLAMP
+#define CLAMP(x, low, high)	(((x) > (high)) ? (high) : MAXIMUM(x, low))
+#endif
+
+#endif

MainPanel.c

@@ -13,25 +13,6 @@ in the source distribution for its full text.
 
 #include <stdlib.h>
 
-/*{
-#include "Panel.h"
-#include "Action.h"
-#include "Settings.h"
-
-typedef struct MainPanel_ {
-   Panel super;
-   State* state;
-   IncSet* inc;
-   Htop_Action *keys;
-   pid_t pidSearch;
-} MainPanel;
-
-typedef bool(*MainPanel_ForeachProcessFn)(Process*, Arg);
-
-#define MainPanel_getFunctionBar(this_) (((Panel*)(this_))->defaultBar)
-
-}*/
-
 static const char* const MainFunctions[]  = {"Help   ", "Setup  ", "Search ", "Filter ", "Tree   ", "SortBy ", "Nice - ", "Nice + ", "Kill   ", "Quit   ", NULL};
 
 void MainPanel_updateTreeFunctions(MainPanel* this, bool mode) {

MainPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_MainPanel
 #define HEADER_MainPanel
 /*
@@ -10,9 +8,9 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#include "Panel.h"
 #include "Action.h"
-#include "Settings.h"
+#include "IncSet.h"
+#include "Panel.h"
 
 typedef struct MainPanel_ {
    Panel super;
@@ -26,23 +24,22 @@ typedef bool(*MainPanel_ForeachProcessFn)(Process*, Arg);
 
 #define MainPanel_getFunctionBar(this_) (((Panel*)(this_))->defaultBar)
 
+void MainPanel_updateTreeFunctions(MainPanel* this, bool mode);
 
-extern void MainPanel_updateTreeFunctions(MainPanel* this, bool mode);
+void MainPanel_pidSearch(MainPanel* this, int ch);
 
-extern void MainPanel_pidSearch(MainPanel* this, int ch);
+int MainPanel_selectedPid(MainPanel* this);
 
-extern int MainPanel_selectedPid(MainPanel* this);
+const char* MainPanel_getValue(MainPanel* this, int i);
 
-extern const char* MainPanel_getValue(MainPanel* this, int i);
-
-extern bool MainPanel_foreachProcess(MainPanel* this, MainPanel_ForeachProcessFn fn, Arg arg, bool* wasAnyTagged);
+bool MainPanel_foreachProcess(MainPanel* this, MainPanel_ForeachProcessFn fn, Arg arg, bool* wasAnyTagged);
 
 extern PanelClass MainPanel_class;
 
-extern MainPanel* MainPanel_new();
+MainPanel* MainPanel_new();
 
-extern void MainPanel_setState(MainPanel* this, State* state);
+void MainPanel_setState(MainPanel* this, State* state);
 
-extern void MainPanel_delete(Object* object);
+void MainPanel_delete(Object* object);
 
 #endif

Makefile.am

@@ -5,7 +5,7 @@ AUTOMAKE_OPTIONS = subdir-objects
 bin_PROGRAMS = htop
 
 dist_man_MANS = htop.1
-EXTRA_DIST = $(dist_man_MANS) htop.desktop htop.png scripts/MakeHeader.py \
+EXTRA_DIST = $(dist_man_MANS) htop.desktop htop.png \
 install-sh autogen.sh missing
 applicationsdir = $(datadir)/applications
 applications_DATA = htop.desktop
@@ -29,14 +29,12 @@ InfoScreen.c XAlloc.c
 myhtopheaders = AvailableColumnsPanel.h AvailableMetersPanel.h \
 CategoriesPanel.h CheckItem.h ClockMeter.h ColorsPanel.h ColumnsPanel.h \
 CPUMeter.h CRT.h MainPanel.h DisplayOptionsPanel.h FunctionBar.h \
-Hashtable.h Header.h htop.h ListItem.h LoadAverageMeter.h MemoryMeter.h \
+Hashtable.h Header.h ListItem.h LoadAverageMeter.h MemoryMeter.h \
 BatteryMeter.h Meter.h MetersPanel.h Object.h Panel.h ProcessList.h RichString.h \
 ScreenManager.h Settings.h SignalsPanel.h StringUtils.h SwapMeter.h \
 TasksMeter.h UptimeMeter.h TraceScreen.h UsersTable.h Vector.h Process.h \
 AffinityPanel.h HostnameMeter.h OpenFilesScreen.h Affinity.h IncSet.h Action.h \
-EnvScreen.h InfoScreen.h XAlloc.h
-
-all_platform_headers =
+EnvScreen.h InfoScreen.h XAlloc.h Macros.h
 
 # Linux
 # -----
@@ -54,11 +52,9 @@ linux_platform_headers = \
 	zfs/ZfsCompressedArcMeter.h \
 	zfs/ZfsArcStats.h
 
-all_platform_headers += $(linux_platform_headers)
-
 if HTOP_LINUX
 AM_LDFLAGS += -rdynamic
-myhtopplatsources = linux/Platform.c linux/IOPriorityPanel.c linux/IOPriority.c \
+myhtopplatsources = linux/Platform.c linux/IOPriorityPanel.c \
 linux/LinuxProcess.c linux/LinuxProcessList.c linux/LinuxCRT.c linux/Battery.c \
 linux/PressureStallMeter.c \
 zfs/ZfsArcMeter.c zfs/ZfsCompressedArcMeter.c zfs/ZfsArcStats.c
@@ -80,8 +76,6 @@ freebsd_platform_headers = \
 	zfs/ZfsArcStats.h \
 	zfs/openzfs_sysctl.h
 
-all_platform_headers += $(freebsd_platform_headers)
-
 if HTOP_FREEBSD
 myhtopplatsources = freebsd/Platform.c freebsd/FreeBSDProcessList.c \
 freebsd/FreeBSDProcess.c freebsd/FreeBSDCRT.c freebsd/Battery.c \
@@ -100,8 +94,6 @@ dragonflybsd_platform_headers = \
 	dragonflybsd/DragonFlyBSDCRT.h \
 	dragonflybsd/Battery.h
 
-all_platform_headers += $(dragonflybsd_platform_headers)
-
 if HTOP_DRAGONFLYBSD
 AM_LDFLAGS += -lkvm -lkinfo -lexecinfo
 myhtopplatsources = dragonflybsd/Platform.c dragonflybsd/DragonFlyBSDProcessList.c \
@@ -120,8 +112,6 @@ openbsd_platform_headers = \
 	openbsd/OpenBSDCRT.h \
 	openbsd/Battery.h
 
-all_platform_headers += $(openbsd_platform_headers)
-
 if HTOP_OPENBSD
 myhtopplatsources = openbsd/Platform.c openbsd/OpenBSDProcessList.c \
 openbsd/OpenBSDProcess.c openbsd/OpenBSDCRT.c openbsd/Battery.c
@@ -143,8 +133,6 @@ darwin_platform_headers = \
 	zfs/ZfsArcStats.h \
 	zfs/openzfs_sysctl.h
 
-all_platform_headers += $(darwin_platform_headers)
-
 if HTOP_DARWIN
 AM_LDFLAGS += -framework IOKit -framework CoreFoundation
 myhtopplatsources = darwin/Platform.c darwin/DarwinProcess.c \
@@ -167,8 +155,6 @@ solaris_platform_headers = \
 	zfs/ZfsCompressedArcMeter.h \
 	zfs/ZfsArcStats.h
 
-all_platform_headers += $(solaris_platform_headers)
-
 if HTOP_SOLARIS
 myhtopplatsources = solaris/Platform.c \
 solaris/SolarisProcess.c solaris/SolarisProcessList.c \
@@ -188,8 +174,6 @@ unsupported_platform_headers = \
 	unsupported/UnsupportedCRT.h \
 	unsupported/Battery.h
 
-all_platform_headers += $(unsupported_platform_headers)
-
 if HTOP_UNSUPPORTED
 myhtopplatsources = unsupported/Platform.c \
 unsupported/UnsupportedProcess.c unsupported/UnsupportedProcessList.c \
@@ -200,19 +184,9 @@ endif
 
 # ----
 
-SUFFIXES = .h
-
-BUILT_SOURCES = $(myhtopheaders) $(myhtopplatheaders)
 htop_SOURCES  = $(myhtopheaders) $(myhtopplatheaders) $(myhtopsources) $(myhtopplatsources)
 nodist_htop_SOURCES = config.h
 
-.PHONY: htop-headers clean-htop-headers
-
-htop-headers: $(myhtopheaders) $(all_platform_headers)
-
-clean-htop-headers:
-	-rm -f $(myhtopheaders) $(all_platform_headers)
-
 target:
 	echo $(htop_SOURCES)
 
@@ -225,9 +199,6 @@ debug:
 coverage:
 	$(MAKE) all CFLAGS="" AM_CPPFLAGS="-fprofile-arcs -ftest-coverage -DDEBUG" LDFLAGS="-lgcov"
 
-.c.h:
-	./scripts/MakeHeader.py $<
-
 cppcheck:
 	cppcheck -q -v . --enable=all -DHAVE_CGROUP -DHAVE_OPENVZ -DHAVE_TASKSTATS
 

MemoryMeter.c

@@ -16,9 +16,6 @@ in the source distribution for its full text.
 #include <sys/param.h>
 #include <assert.h>
 
-/*{
-#include "Meter.h"
-}*/
 
 int MemoryMeter_attributes[] = {
    MEMORY_USED, MEMORY_BUFFERS, MEMORY_CACHE

MemoryMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_MemoryMeter
 #define HEADER_MemoryMeter
 /*

Meter.c

@@ -11,7 +11,6 @@ in the source distribution for its full text.
 #include "Object.h"
 #include "CRT.h"
 #include "StringUtils.h"
-#include "ListItem.h"
 #include "Settings.h"
 
 #include <math.h>
@@ -19,108 +18,11 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <stdarg.h>
 #include <assert.h>
-#include <sys/time.h>
-
-#define METER_BUFFER_LEN 256
 
 #define GRAPH_DELAY (DEFAULT_DELAY/2)
 
 #define GRAPH_HEIGHT 4 /* Unit: rows (lines) */
 
-/*{
-#include "ListItem.h"
-
-#include <sys/time.h>
-
-typedef struct Meter_ Meter;
-
-typedef void(*Meter_Init)(Meter*);
-typedef void(*Meter_Done)(Meter*);
-typedef void(*Meter_UpdateMode)(Meter*, int);
-typedef void(*Meter_UpdateValues)(Meter*, char*, int);
-typedef void(*Meter_Draw)(Meter*, int, int, int);
-
-typedef struct MeterClass_ {
-   ObjectClass super;
-   const Meter_Init init;
-   const Meter_Done done;
-   const Meter_UpdateMode updateMode;
-   const Meter_Draw draw;
-   const Meter_UpdateValues updateValues;
-   const int defaultMode;
-   const double total;
-   const int* attributes;
-   const char* name;
-   const char* uiName;
-   const char* caption;
-   const char* description;
-   const char maxItems;
-   char curItems;
-} MeterClass;
-
-#define As_Meter(this_)                ((MeterClass*)((this_)->super.klass))
-#define Meter_initFn(this_)            As_Meter(this_)->init
-#define Meter_init(this_)              As_Meter(this_)->init((Meter*)(this_))
-#define Meter_done(this_)              As_Meter(this_)->done((Meter*)(this_))
-#define Meter_updateModeFn(this_)      As_Meter(this_)->updateMode
-#define Meter_updateMode(this_, m_)    As_Meter(this_)->updateMode((Meter*)(this_), m_)
-#define Meter_drawFn(this_)            As_Meter(this_)->draw
-#define Meter_doneFn(this_)            As_Meter(this_)->done
-#define Meter_updateValues(this_, buf_, sz_) \
-                                       As_Meter(this_)->updateValues((Meter*)(this_), buf_, sz_)
-#define Meter_defaultMode(this_)       As_Meter(this_)->defaultMode
-#define Meter_getItems(this_)          As_Meter(this_)->curItems
-#define Meter_setItems(this_, n_)      As_Meter(this_)->curItems = (n_)
-#define Meter_attributes(this_)        As_Meter(this_)->attributes
-#define Meter_name(this_)              As_Meter(this_)->name
-#define Meter_uiName(this_)            As_Meter(this_)->uiName
-
-struct Meter_ {
-   Object super;
-   Meter_Draw draw;
-
-   char* caption;
-   int mode;
-   int param;
-   void* drawData;
-   int h;
-   struct ProcessList_* pl;
-   double* values;
-   double total;
-};
-
-typedef struct MeterMode_ {
-   Meter_Draw draw;
-   const char* uiName;
-   int h;
-} MeterMode;
-
-typedef enum {
-   CUSTOM_METERMODE = 0,
-   BAR_METERMODE,
-   TEXT_METERMODE,
-   GRAPH_METERMODE,
-   LED_METERMODE,
-   LAST_METERMODE
-} MeterModeId;
-
-typedef struct GraphData_ {
-   struct timeval time;
-   double values[METER_BUFFER_LEN];
-} GraphData;
-
-}*/
-
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-#ifndef CLAMP
-#define CLAMP(x,low,high) (((x)>(high))?(high):(((x)<(low))?(low):(x)))
-#endif
-
 MeterClass Meter_class = {
    .super = {
       .extends = Class(Object)

Meter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Meter
 #define HEADER_Meter
 /*
@@ -9,16 +7,11 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#define METER_BUFFER_LEN 256
-
-#define GRAPH_DELAY (DEFAULT_DELAY/2)
-
-#define GRAPH_HEIGHT 4 /* Unit: rows (lines) */
-
 #include "ListItem.h"
-
 #include <sys/time.h>
 
+#define METER_BUFFER_LEN 256
+
 typedef struct Meter_ Meter;
 
 typedef void(*Meter_Init)(Meter*);
@@ -96,54 +89,22 @@ typedef struct GraphData_ {
    double values[METER_BUFFER_LEN];
 } GraphData;
 
-
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-#ifndef CLAMP
-#define CLAMP(x,low,high) (((x)>(high))?(high):(((x)<(low))?(low):(x)))
-#endif
-
 extern MeterClass Meter_class;
 
-extern Meter* Meter_new(struct ProcessList_* pl, int param, MeterClass* type);
+Meter* Meter_new(struct ProcessList_* pl, int param, MeterClass* type);
 
-extern int Meter_humanUnit(char* buffer, unsigned long int value, int size);
+int Meter_humanUnit(char* buffer, unsigned long int value, int size);
 
-extern void Meter_delete(Object* cast);
+void Meter_delete(Object* cast);
 
-extern void Meter_setCaption(Meter* this, const char* caption);
+void Meter_setCaption(Meter* this, const char* caption);
 
-extern void Meter_setMode(Meter* this, int modeIndex);
+void Meter_setMode(Meter* this, int modeIndex);
 
-extern ListItem* Meter_toListItem(Meter* this, bool moving);
-
-/* ---------- TextMeterMode ---------- */
-
-/* ---------- BarMeterMode ---------- */
-
-/* ---------- GraphMeterMode ---------- */
-
-#ifdef HAVE_LIBNCURSESW
-
-#define PIXPERROW_UTF8 4
-#endif
-
-#define PIXPERROW_ASCII 2
-
-/* ---------- LEDMeterMode ---------- */
-
-#ifdef HAVE_LIBNCURSESW
-
-#endif
+ListItem* Meter_toListItem(Meter* this, bool moving);
 
 extern MeterMode* Meter_modes[];
 
-/* Blank meter */
-
 extern int BlankMeter_attributes[];
 
 extern MeterClass BlankMeter_class;

MetersPanel.c

@@ -11,25 +11,6 @@ in the source distribution for its full text.
 #include <assert.h>
 #include "CRT.h"
 
-/*{
-#include "Panel.h"
-#include "Settings.h"
-#include "ScreenManager.h"
-
-typedef struct MetersPanel_ MetersPanel;
-
-struct MetersPanel_ {
-   Panel super;
-
-   Settings* settings;
-   Vector* meters;
-   ScreenManager* scr;
-   MetersPanel* leftNeighbor;
-   MetersPanel* rightNeighbor;
-   bool moving;
-};
-
-}*/
 
 // Note: In code the meters are known to have bar/text/graph "Modes", but in UI
 // we call them "Styles".

MetersPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_MetersPanel
 #define HEADER_MetersPanel
 /*
@@ -26,18 +24,10 @@ struct MetersPanel_ {
    bool moving;
 };
 
-
-// Note: In code the meters are known to have bar/text/graph "Modes", but in UI
-// we call them "Styles".
-// We avoid UTF-8 arrows ← → here as they might display full-width on Chinese
-// terminals, breaking our aligning.
-// In <http://unicode.org/reports/tr11/>, arrows (U+2019..U+2199) are
-// considered "Ambiguous characters".
-
-extern void MetersPanel_setMoving(MetersPanel* this, bool moving);
+void MetersPanel_setMoving(MetersPanel* this, bool moving);
 
 extern PanelClass MetersPanel_class;
 
-extern MetersPanel* MetersPanel_new(Settings* settings, const char* header, Vector* meters, ScreenManager* scr);
+MetersPanel* MetersPanel_new(Settings* settings, const char* header, Vector* meters, ScreenManager* scr);
 
 #endif

Object.c

@@ -8,46 +8,6 @@ in the source distribution for its full text.
 
 #include "Object.h"
 
-/*{
-#include "RichString.h"
-#include "XAlloc.h"
-
-typedef struct Object_ Object;
-
-typedef void(*Object_Display)(Object*, RichString*);
-typedef long(*Object_Compare)(const void*, const void*);
-typedef void(*Object_Delete)(Object*);
-
-#define Object_getClass(obj_)         ((Object*)(obj_))->klass
-#define Object_setClass(obj_, class_) Object_getClass(obj_) = (ObjectClass*) class_
-
-#define Object_delete(obj_)           Object_getClass(obj_)->delete((Object*)(obj_))
-#define Object_displayFn(obj_)        Object_getClass(obj_)->display
-#define Object_display(obj_, str_)    Object_getClass(obj_)->display((Object*)(obj_), str_)
-#define Object_compare(obj_, other_)  Object_getClass(obj_)->compare((const void*)(obj_), other_)
-
-#define Class(class_)                 ((ObjectClass*)(&(class_ ## _class)))
-
-#define AllocThis(class_) (class_*) xMalloc(sizeof(class_)); Object_setClass(this, Class(class_));
-
-typedef struct ObjectClass_ {
-   const void* extends;
-   const Object_Display display;
-   const Object_Delete delete;
-   const Object_Compare compare;
-} ObjectClass;
-
-struct Object_ {
-   ObjectClass* klass;
-};
-
-typedef union {
-   int i;
-   void* v;
-} Arg;
-
-}*/
-
 ObjectClass Object_class = {
    .extends = NULL
 };

Object.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Object
 #define HEADER_Object
 /*
@@ -12,6 +10,7 @@ in the source distribution for its full text.
 
 #include "RichString.h"
 #include "XAlloc.h"
+#include "Macros.h"
 
 typedef struct Object_ Object;
 
@@ -47,12 +46,11 @@ typedef union {
    void* v;
 } Arg;
 
-
 extern ObjectClass Object_class;
 
 #ifdef DEBUG
 
-extern bool Object_isA(Object* o, const ObjectClass* klass);
+bool Object_isA(Object* o, const ObjectClass* klass);
 
 #endif
 

OpenFilesScreen.c

@@ -23,30 +23,6 @@ in the source distribution for its full text.
 #include <sys/types.h>
 #include <sys/wait.h>
 
-/*{
-#include "InfoScreen.h"
-
-typedef struct OpenFiles_Data_ {
-   char* data[256];
-} OpenFiles_Data;
-
-typedef struct OpenFiles_ProcessData_ {
-   OpenFiles_Data data;
-   int error;
-   struct OpenFiles_FileData_* files;
-} OpenFiles_ProcessData;
-
-typedef struct OpenFiles_FileData_ {
-   OpenFiles_Data data;
-   struct OpenFiles_FileData_* next;
-} OpenFiles_FileData;
-
-typedef struct OpenFilesScreen_ {
-   InfoScreen super;
-   pid_t pid;
-} OpenFilesScreen;
-
-}*/
 
 InfoScreenClass OpenFilesScreen_class = {
    .super = {

OpenFilesScreen.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_OpenFilesScreen
 #define HEADER_OpenFilesScreen
 /*
@@ -31,15 +29,14 @@ typedef struct OpenFilesScreen_ {
    pid_t pid;
 } OpenFilesScreen;
 
-
 extern InfoScreenClass OpenFilesScreen_class;
 
-extern OpenFilesScreen* OpenFilesScreen_new(Process* process);
+OpenFilesScreen* OpenFilesScreen_new(Process* process);
 
-extern void OpenFilesScreen_delete(Object* this);
+void OpenFilesScreen_delete(Object* this);
 
-extern void OpenFilesScreen_draw(InfoScreen* this);
+void OpenFilesScreen_draw(InfoScreen* this);
 
-extern void OpenFilesScreen_scan(InfoScreen* this);
+void OpenFilesScreen_scan(InfoScreen* this);
 
 #endif

Panel.c

@@ -19,72 +19,6 @@ in the source distribution for its full text.
 #include <string.h>
 #include <assert.h>
 
-//#link curses
-
-/*{
-#include "Object.h"
-#include "Vector.h"
-#include "FunctionBar.h"
-
-typedef struct Panel_ Panel;
-
-typedef enum HandlerResult_ {
-   HANDLED     = 0x01,
-   IGNORED     = 0x02,
-   BREAK_LOOP  = 0x04,
-   REDRAW      = 0x08,
-   RESCAN      = 0x10,
-   SYNTH_KEY   = 0x20,
-} HandlerResult;
-
-#define EVENT_SET_SELECTED -1
-
-#define EVENT_HEADER_CLICK(x_) (-10000 + x_)
-#define EVENT_IS_HEADER_CLICK(ev_) (ev_ >= -10000 && ev_ <= -9000)
-#define EVENT_HEADER_CLICK_GET_X(ev_) (ev_ + 10000)
-
-typedef HandlerResult(*Panel_EventHandler)(Panel*, int);
-
-typedef struct PanelClass_ {
-   const ObjectClass super;
-   const Panel_EventHandler eventHandler;
-} PanelClass;
-
-#define As_Panel(this_)                ((PanelClass*)((this_)->super.klass))
-#define Panel_eventHandlerFn(this_)    As_Panel(this_)->eventHandler
-#define Panel_eventHandler(this_, ev_) As_Panel(this_)->eventHandler((Panel*)(this_), ev_)
-
-struct Panel_ {
-   Object super;
-   int x, y, w, h;
-   WINDOW* window;
-   Vector* items;
-   int selected;
-   int oldSelected;
-   int selectedLen;
-   void* eventHandlerState;
-   int scrollV;
-   short scrollH;
-   bool needsRedraw;
-   FunctionBar* currentBar;
-   FunctionBar* defaultBar;
-   RichString header;
-   int selectionColor;
-};
-
-#define Panel_setDefaultBar(this_) do{ (this_)->currentBar = (this_)->defaultBar; }while(0)
-
-}*/
-
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
-#define KEY_CTRL(l) ((l)-'A'+1)
-
 PanelClass Panel_class = {
    .super = {
       .extends = Class(Object),
@@ -290,7 +224,7 @@ void Panel_draw(Panel* this, bool focus) {
       mvhline(y, x, ' ', this->w);
       if (scrollH < headerLen) {
          RichString_printoffnVal(this->header, y, x, scrollH,
-            MIN(headerLen - scrollH, this->w));
+            MINIMUM(headerLen - scrollH, this->w));
       }
       attrset(CRT_colors[RESET_COLOR]);
       y++;
@@ -301,7 +235,7 @@ void Panel_draw(Panel* this, bool focus) {
       this->scrollV = 0;
       this->needsRedraw = true;
    } else if (this->scrollV >= size) {
-      this->scrollV = MAX(size - 1, 0);
+      this->scrollV = MAXIMUM(size - 1, 0);
       this->needsRedraw = true;
    }
    // ensure selection is on screen
@@ -314,7 +248,7 @@ void Panel_draw(Panel* this, bool focus) {
    }
 
    int first = this->scrollV;
-   int upTo = MIN(first + h, size);
+   int upTo = MINIMUM(first + h, size);
 
    int selectionColor = focus
                  ? this->selectionColor
@@ -328,7 +262,7 @@ void Panel_draw(Panel* this, bool focus) {
          RichString_begin(item);
          Object_display(itemObj, &item);
          int itemLen = RichString_sizeVal(item);
-         int amt = MIN(itemLen - scrollH, this->w);
+         int amt = MINIMUM(itemLen - scrollH, this->w);
          bool selected = (i == this->selected);
          if (selected) {
             attrset(selectionColor);
@@ -363,13 +297,13 @@ void Panel_draw(Panel* this, bool focus) {
       mvhline(y+ this->oldSelected - first, x+0, ' ', this->w);
       if (scrollH < oldLen)
          RichString_printoffnVal(old, y+this->oldSelected - first, x,
-            scrollH, MIN(oldLen - scrollH, this->w));
+            scrollH, MINIMUM(oldLen - scrollH, this->w));
       attrset(selectionColor);
       mvhline(y+this->selected - first, x+0, ' ', this->w);
       RichString_setAttr(&new, selectionColor);
       if (scrollH < newLen)
          RichString_printoffnVal(new, y+this->selected - first, x,
-            scrollH, MIN(newLen - scrollH, this->w));
+            scrollH, MINIMUM(newLen - scrollH, this->w));
       attrset(CRT_colors[RESET_COLOR]);
       RichString_end(new);
       RichString_end(old);
@@ -404,7 +338,7 @@ bool Panel_onKey(Panel* this, int key) {
    case KEY_LEFT:
    case KEY_CTRL('B'):
       if (this->scrollH > 0) {
-         this->scrollH -= MAX(CRT_scrollHAmount, 0);
+         this->scrollH -= MAXIMUM(CRT_scrollHAmount, 0);
          this->needsRedraw = true;
       }
       break;
@@ -415,12 +349,12 @@ bool Panel_onKey(Panel* this, int key) {
       break;
    case KEY_PPAGE:
       this->selected -= (this->h - 1);
-      this->scrollV = MAX(0, this->scrollV - this->h + 1);
+      this->scrollV = MAXIMUM(0, this->scrollV - this->h + 1);
       this->needsRedraw = true;
       break;
    case KEY_NPAGE:
       this->selected += (this->h - 1);
-      this->scrollV = MAX(0, MIN(Vector_size(this->items) - this->h,
+      this->scrollV = MAXIMUM(0, MINIMUM(Vector_size(this->items) - this->h,
                                  this->scrollV + this->h - 1));
       this->needsRedraw = true;
       break;
@@ -452,7 +386,7 @@ bool Panel_onKey(Panel* this, int key) {
       break;
    case KEY_CTRL('E'):
    case '$':
-      this->scrollH = MAX(this->selectedLen - this->w, 0);
+      this->scrollH = MAXIMUM(this->selectedLen - this->w, 0);
       this->needsRedraw = true;
       break;
    default:

Panel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Panel
 #define HEADER_Panel
 /*
@@ -9,8 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-//#link curses
-
 #include "Object.h"
 #include "Vector.h"
 #include "FunctionBar.h"
@@ -63,66 +59,58 @@ struct Panel_ {
 
 #define Panel_setDefaultBar(this_) do{ (this_)->currentBar = (this_)->defaultBar; }while(0)
 
-
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-#ifndef MAX
-#define MAX(a,b) ((a)>(b)?(a):(b))
-#endif
-
 #define KEY_CTRL(l) ((l)-'A'+1)
 
 extern PanelClass Panel_class;
 
-extern Panel* Panel_new(int x, int y, int w, int h, bool owner, ObjectClass* type, FunctionBar* fuBar);
+Panel* Panel_new(int x, int y, int w, int h, bool owner, ObjectClass* type, FunctionBar* fuBar);
 
-extern void Panel_delete(Object* cast);
+void Panel_delete(Object* cast);
 
-extern void Panel_init(Panel* this, int x, int y, int w, int h, ObjectClass* type, bool owner, FunctionBar* fuBar);
+void Panel_init(Panel* this, int x, int y, int w, int h, ObjectClass* type, bool owner, FunctionBar* fuBar);
 
-extern void Panel_done(Panel* this);
+void Panel_done(Panel* this);
 
-extern void Panel_setSelectionColor(Panel* this, int color);
+void Panel_setSelectionColor(Panel* this, int color);
 
-extern RichString* Panel_getHeader(Panel* this);
+RichString* Panel_getHeader(Panel* this);
 
-extern void Panel_setHeader(Panel* this, const char* header);
+void Panel_setHeader(Panel* this, const char* header);
 
-extern void Panel_move(Panel* this, int x, int y);
+void Panel_move(Panel* this, int x, int y);
 
-extern void Panel_resize(Panel* this, int w, int h);
+void Panel_resize(Panel* this, int w, int h);
 
-extern void Panel_prune(Panel* this);
+void Panel_prune(Panel* this);
 
-extern void Panel_add(Panel* this, Object* o);
+void Panel_add(Panel* this, Object* o);
 
-extern void Panel_insert(Panel* this, int i, Object* o);
+void Panel_insert(Panel* this, int i, Object* o);
 
-extern void Panel_set(Panel* this, int i, Object* o);
+void Panel_set(Panel* this, int i, Object* o);
 
-extern Object* Panel_get(Panel* this, int i);
+Object* Panel_get(Panel* this, int i);
 
-extern Object* Panel_remove(Panel* this, int i);
+Object* Panel_remove(Panel* this, int i);
 
-extern Object* Panel_getSelected(Panel* this);
+Object* Panel_getSelected(Panel* this);
 
-extern void Panel_moveSelectedUp(Panel* this);
+void Panel_moveSelectedUp(Panel* this);
 
-extern void Panel_moveSelectedDown(Panel* this);
+void Panel_moveSelectedDown(Panel* this);
 
-extern int Panel_getSelectedIndex(Panel* this);
+int Panel_getSelectedIndex(Panel* this);
 
-extern int Panel_size(Panel* this);
+int Panel_size(Panel* this);
 
-extern void Panel_setSelected(Panel* this, int selected);
+void Panel_setSelected(Panel* this, int selected);
 
-extern void Panel_draw(Panel* this, bool focus);
+void Panel_draw(Panel* this, bool focus);
 
-extern void Panel_splice(Panel *this, Vector* from);
+void Panel_splice(Panel *this, Vector* from);
 
-extern bool Panel_onKey(Panel* this, int key);
+bool Panel_onKey(Panel* this, int key);
 
-extern HandlerResult Panel_selectByTyping(Panel* this, int ch);
+HandlerResult Panel_selectByTyping(Panel* this, int ch);
 
 #endif

Process.c

@@ -21,7 +21,6 @@ in the source distribution for its full text.
 #include <sys/resource.h>
 #include <sys/param.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <signal.h>
@@ -37,169 +36,8 @@ in the source distribution for its full text.
 #include <sys/sysmacros.h>
 #endif
 
-#ifdef __ANDROID__
-#define SYS_ioprio_get __NR_ioprio_get
-#define SYS_ioprio_set __NR_ioprio_set
-#endif
-
-// On Linux, this works only with glibc 2.1+. On earlier versions
-// the behavior is similar to have a hardcoded page size.
-#ifndef PAGE_SIZE
-#define PAGE_SIZE ( sysconf(_SC_PAGESIZE) )
-#endif
-#define PAGE_SIZE_KB ( PAGE_SIZE / ONE_K )
-
-/*{
-#include "Object.h"
-
-#include <sys/types.h>
-
-#define PROCESS_FLAG_IO 0x0001
-
-typedef enum ProcessFields {
-   NULL_PROCESSFIELD = 0,
-   PID = 1,
-   COMM = 2,
-   STATE = 3,
-   PPID = 4,
-   PGRP = 5,
-   SESSION = 6,
-   TTY_NR = 7,
-   TPGID = 8,
-   MINFLT = 10,
-   MAJFLT = 12,
-   PRIORITY = 18,
-   NICE = 19,
-   STARTTIME = 21,
-   PROCESSOR = 38,
-   M_SIZE = 39,
-   M_RESIDENT = 40,
-   ST_UID = 46,
-   PERCENT_CPU = 47,
-   PERCENT_MEM = 48,
-   USER = 49,
-   TIME = 50,
-   NLWP = 51,
-   TGID = 52,
-} ProcessField;
-
-typedef struct ProcessPidColumn_ {
-   int id;
-   const char* label;
-} ProcessPidColumn;
-
-typedef struct Process_ {
-   Object super;
-
-   struct Settings_* settings;
-
-   unsigned long long int time;
-   pid_t pid;
-   pid_t ppid;
-   pid_t tgid;
-   char* comm;
-   int commLen;
-   int indent;
-
-   int basenameOffset;
-   bool updated;
-
-   char state;
-   bool tag;
-   bool showChildren;
-   bool show;
-   unsigned int pgrp;
-   unsigned int session;
-   unsigned int tty_nr;
-   int tpgid;
-   uid_t st_uid;
-   unsigned long int flags;
-   int processor;
-
-   float percent_cpu;
-   float percent_mem;
-   char* user;
-
-   long int priority;
-   long int nice;
-   long int nlwp;
-   char starttime_show[8];
-   time_t starttime_ctime;
-
-   long m_size;
-   long m_resident;
-
-   int exit_signal;
-
-   unsigned long int minflt;
-   unsigned long int majflt;
-   #ifdef DEBUG
-   long int itrealvalue;
-   unsigned long int vsize;
-   long int rss;
-   unsigned long int rlim;
-   unsigned long int startcode;
-   unsigned long int endcode;
-   unsigned long int startstack;
-   unsigned long int kstkesp;
-   unsigned long int kstkeip;
-   unsigned long int signal;
-   unsigned long int blocked;
-   unsigned long int sigignore;
-   unsigned long int sigcatch;
-   unsigned long int wchan;
-   unsigned long int nswap;
-   unsigned long int cnswap;
-   #endif
-
-} Process;
-
-typedef struct ProcessFieldData_ {
-   const char* name;
-   const char* title;
-   const char* description;
-   int flags;
-} ProcessFieldData;
-
-// Implemented in platform-specific code:
-void Process_writeField(Process* this, RichString* str, ProcessField field);
-long Process_compare(const void* v1, const void* v2);
-void Process_delete(Object* cast);
-bool Process_isThread(Process* this);
-extern ProcessFieldData Process_fields[];
-extern ProcessPidColumn Process_pidColumns[];
-extern char Process_pidFormat[20];
-
-typedef Process*(*Process_New)(struct Settings_*);
-typedef void (*Process_WriteField)(Process*, RichString*, ProcessField);
-
-typedef struct ProcessClass_ {
-   const ObjectClass super;
-   const Process_WriteField writeField;
-} ProcessClass;
-
-#define As_Process(this_)              ((ProcessClass*)((this_)->super.klass))
-
-#define Process_getParentPid(process_)    (process_->tgid == process_->pid ? process_->ppid : process_->tgid)
-
-#define Process_isChildOf(process_, pid_) (process_->tgid == pid_ || (process_->tgid == process_->pid && process_->ppid == pid_))
-
-#define Process_sortState(state) ((state) == 'I' ? 0x100 : (state))
-
-}*/
-
 static int Process_getuid = -1;
 
-#define ONE_K 1024L
-#define ONE_M (ONE_K * ONE_K)
-#define ONE_G (ONE_M * ONE_K)
-#define ONE_T ((long long)ONE_G * ONE_K)
-
-#define ONE_DECIMAL_K 1000L
-#define ONE_DECIMAL_M (ONE_DECIMAL_K * ONE_DECIMAL_K)
-#define ONE_DECIMAL_G (ONE_DECIMAL_M * ONE_DECIMAL_K)
-#define ONE_DECIMAL_T ((long long)ONE_DECIMAL_G * ONE_DECIMAL_K)
-
 char Process_pidFormat[20] = "%7d ";
 
 static char Process_titleBuffer[20][20];

Process.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Process
 #define HEADER_Process
 /*
@@ -10,10 +8,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#ifdef MAJOR_IN_MKDEV
-#elif defined(MAJOR_IN_SYSMACROS)
-#endif
-
 #ifdef __ANDROID__
 #define SYS_ioprio_get __NR_ioprio_get
 #define SYS_ioprio_set __NR_ioprio_set
@@ -175,36 +169,36 @@ typedef struct ProcessClass_ {
 
 extern char Process_pidFormat[20];
 
-extern void Process_setupColumnWidths();
+void Process_setupColumnWidths();
 
-extern void Process_humanNumber(RichString* str, unsigned long number, bool coloring);
+void Process_humanNumber(RichString* str, unsigned long number, bool coloring);
 
-extern void Process_colorNumber(RichString* str, unsigned long long number, bool coloring);
+void Process_colorNumber(RichString* str, unsigned long long number, bool coloring);
 
-extern void Process_printTime(RichString* str, unsigned long long totalHundredths);
+void Process_printTime(RichString* str, unsigned long long totalHundredths);
 
-extern void Process_outputRate(RichString* str, char* buffer, int n, double rate, int coloring);
+void Process_outputRate(RichString* str, char* buffer, int n, double rate, int coloring);
 
-extern void Process_writeField(Process* this, RichString* str, ProcessField field);
+void Process_writeField(Process* this, RichString* str, ProcessField field);
 
-extern void Process_display(Object* cast, RichString* out);
+void Process_display(Object* cast, RichString* out);
 
-extern void Process_done(Process* this);
+void Process_done(Process* this);
 
 extern ProcessClass Process_class;
 
-extern void Process_init(Process* this, struct Settings_* settings);
+void Process_init(Process* this, struct Settings_* settings);
 
-extern void Process_toggleTag(Process* this);
+void Process_toggleTag(Process* this);
 
-extern bool Process_setPriority(Process* this, int priority);
+bool Process_setPriority(Process* this, int priority);
 
-extern bool Process_changePriorityBy(Process* this, Arg delta);
+bool Process_changePriorityBy(Process* this, Arg delta);
 
-extern bool Process_sendSignal(Process* this, Arg sgn);
+bool Process_sendSignal(Process* this, Arg sgn);
 
-extern long Process_pidCompare(const void* v1, const void* v2);
+long Process_pidCompare(const void* v1, const void* v2);
 
-extern long Process_compare(const void* v1, const void* v2);
+long Process_compare(const void* v1, const void* v2);
 
 #endif

ProcessList.c

@@ -14,75 +14,12 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <string.h>
 
-/*{
-#include "Vector.h"
-#include "Hashtable.h"
-#include "UsersTable.h"
-#include "Panel.h"
-#include "Process.h"
-#include "Settings.h"
 
-#ifdef HAVE_LIBHWLOC
-#include <hwloc.h>
-#endif
-
-#ifndef MAX_NAME
-#define MAX_NAME 128
-#endif
-
-#ifndef MAX_READ
-#define MAX_READ 2048
-#endif
-
-typedef struct ProcessList_ {
-   Settings* settings;
-
-   Vector* processes;
-   Vector* processes2;
-   Hashtable* processTable;
-   UsersTable* usersTable;
-
-   Panel* panel;
-   int following;
-   uid_t userId;
-   const char* incFilter;
-   Hashtable* pidWhiteList;
-
-   #ifdef HAVE_LIBHWLOC
-   hwloc_topology_t topology;
-   bool topologyOk;
-   #endif
-
-   int totalTasks;
-   int runningTasks;
-   int userlandThreads;
-   int kernelThreads;
-
-   unsigned long long int totalMem;
-   unsigned long long int usedMem;
-   unsigned long long int freeMem;
-   unsigned long long int sharedMem;
-   unsigned long long int buffersMem;
-   unsigned long long int cachedMem;
-   unsigned long long int totalSwap;
-   unsigned long long int usedSwap;
-   unsigned long long int freeSwap;
-
-   int cpuCount;
-
-} ProcessList;
-
-ProcessList* ProcessList_new(UsersTable* ut, Hashtable* pidWhiteList, uid_t userId);
-void ProcessList_delete(ProcessList* pl);
-void ProcessList_goThroughEntries(ProcessList* pl);
-
-}*/
-
-ProcessList* ProcessList_init(ProcessList* this, ObjectClass* klass, UsersTable* usersTable, Hashtable* pidWhiteList, uid_t userId) {
+ProcessList* ProcessList_init(ProcessList* this, ObjectClass* klass, UsersTable* usersTable, Hashtable* pidMatchList, uid_t userId) {
    this->processes = Vector_new(klass, true, DEFAULT_SIZE);
    this->processTable = Hashtable_new(140, false);
    this->usersTable = usersTable;
-   this->pidWhiteList = pidWhiteList;
+   this->pidMatchList = pidMatchList;
    this->userId = userId;
 
    // tree-view auxiliary buffer
@@ -317,7 +254,7 @@ void ProcessList_rebuildPanel(ProcessList* this) {
       if ( (!p->show)
          || (this->userId != (uid_t) -1 && (p->st_uid != this->userId))
          || (incFilter && !(String_contains_i(p->comm, incFilter)))
-         || (this->pidWhiteList && !Hashtable_get(this->pidWhiteList, p->tgid)) )
+         || (this->pidMatchList && !Hashtable_get(this->pidMatchList, p->tgid)) )
          hidden = true;
 
       if (!hidden) {

ProcessList.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ProcessList
 #define HEADER_ProcessList
 /*
@@ -40,7 +38,7 @@ typedef struct ProcessList_ {
    int following;
    uid_t userId;
    const char* incFilter;
-   Hashtable* pidWhiteList;
+   Hashtable* pidMatchList;
 
    #ifdef HAVE_LIBHWLOC
    hwloc_topology_t topology;
@@ -66,37 +64,37 @@ typedef struct ProcessList_ {
 
 } ProcessList;
 
-ProcessList* ProcessList_new(UsersTable* ut, Hashtable* pidWhiteList, uid_t userId);
+ProcessList* ProcessList_new(UsersTable* ut, Hashtable* pidMatchList, uid_t userId);
 void ProcessList_delete(ProcessList* pl);
 void ProcessList_goThroughEntries(ProcessList* pl);
 
 
-extern ProcessList* ProcessList_init(ProcessList* this, ObjectClass* klass, UsersTable* usersTable, Hashtable* pidWhiteList, uid_t userId);
+ProcessList* ProcessList_init(ProcessList* this, ObjectClass* klass, UsersTable* usersTable, Hashtable* pidMatchList, uid_t userId);
 
-extern void ProcessList_done(ProcessList* this);
+void ProcessList_done(ProcessList* this);
 
-extern void ProcessList_setPanel(ProcessList* this, Panel* panel);
+void ProcessList_setPanel(ProcessList* this, Panel* panel);
 
-extern void ProcessList_printHeader(ProcessList* this, RichString* header);
+void ProcessList_printHeader(ProcessList* this, RichString* header);
 
-extern void ProcessList_add(ProcessList* this, Process* p);
+void ProcessList_add(ProcessList* this, Process* p);
 
-extern void ProcessList_remove(ProcessList* this, Process* p);
+void ProcessList_remove(ProcessList* this, Process* p);
 
-extern Process* ProcessList_get(ProcessList* this, int idx);
+Process* ProcessList_get(ProcessList* this, int idx);
 
-extern int ProcessList_size(ProcessList* this);
+int ProcessList_size(ProcessList* this);
 
-extern void ProcessList_sort(ProcessList* this);
+void ProcessList_sort(ProcessList* this);
 
-extern ProcessField ProcessList_keyAt(ProcessList* this, int at);
+ProcessField ProcessList_keyAt(ProcessList* this, int at);
 
-extern void ProcessList_expandTree(ProcessList* this);
+void ProcessList_expandTree(ProcessList* this);
 
-extern void ProcessList_rebuildPanel(ProcessList* this);
+void ProcessList_rebuildPanel(ProcessList* this);
 
-extern Process* ProcessList_getProcess(ProcessList* this, pid_t pid, bool* preExisting, Process_New constructor);
+Process* ProcessList_getProcess(ProcessList* this, pid_t pid, bool* preExisting, Process_New constructor);
 
-extern void ProcessList_scan(ProcessList* this);
+void ProcessList_scan(ProcessList* this);
 
 #endif

README

@@ -1,13 +1,13 @@
-![htop](https://htop.dev)
+# [![htop](htop.png)](https://htop.dev)
 
 [![CI](https://github.com/htop-dev/htop/workflows/CI/badge.svg)](https://github.com/htop-dev/htop/actions)
-[![Coverity Scan Build Status](https://scan.coverity.com/projects/21617/badge.svg)](https://scan.coverity.com/projects/21617)
+[![Coverity Scan Build Status](https://scan.coverity.com/projects/21665/badge.svg)](https://scan.coverity.com/projects/21665)
 [![Mailing List](https://img.shields.io/badge/Mailing%20List-htop-blue.svg)](https://groups.io/g/htop)
 [![IRC #htop](https://img.shields.io/badge/IRC-htop-blue.svg)](https://webchat.freenode.net/#htop)
 [![Github Release](https://img.shields.io/github/release/htop-dev/htop.svg)](https://github.com/htop-dev/htop/releases/latest)
+[![Download](https://api.bintray.com/packages/htop/source/htop/images/download.svg)](https://bintray.com/htop/source/htop/_latestVersion)
 
-Introduction
-------------
+## Introduction
 
 `htop` is a cross-platform interactive process viewer.
 It requires `ncurses`.
@@ -15,20 +15,23 @@ It requires `ncurses`.
 For more information and details on how to contribute to `htop`
 visit [htop.dev](https://htop.dev).
 
-Build instructions
-------------------
+## Build instructions
 
 This program is distributed as a standard autotools-based package.
-For detailed instructions see the [INSTALL](/INSTALL) file, which
+For detailed instructions see the `INSTALL` file, which
 is created after `./autogen.sh` is run.
 
 When compiling from a [release tarball](https://github.com/htop-dev/htop/releases/), run:
 
-    ./configure && make
+~~~ shell
+./configure && make
+~~~
 
 For compiling sources downloaded from the Git repository, run:
 
-    ./autogen.sh && ./configure && make
+~~~ shell
+./autogen.sh && ./configure && make
+~~~
 
 By default `make install` will install into `/usr/local`, for changing
 the path use `./configure --prefix=/some/path`.

RichString.c

@@ -7,66 +7,11 @@ in the source distribution for its full text.
 
 #include "RichString.h"
 #include "XAlloc.h"
+#include "Macros.h"
 
 #include <stdlib.h>
 #include <string.h>
 
-#define RICHSTRING_MAXLEN 350
-
-/*{
-#include "config.h"
-#include <ctype.h>
-
-#include <assert.h>
-#ifdef HAVE_NCURSESW_CURSES_H
-#include <ncursesw/curses.h>
-#elif HAVE_NCURSES_NCURSES_H
-#include <ncurses/ncurses.h>
-#elif HAVE_NCURSES_CURSES_H
-#include <ncurses/curses.h>
-#elif HAVE_NCURSES_H
-#include <ncurses.h>
-#elif HAVE_CURSES_H
-#include <curses.h>
-#endif
-
-#ifdef HAVE_LIBNCURSESW
-#include <wctype.h>
-#endif
-
-#define RichString_size(this) ((this)->chlen)
-#define RichString_sizeVal(this) ((this).chlen)
-
-#define RichString_begin(this) RichString (this); memset(&this, 0, sizeof(RichString)); (this).chptr = (this).chstr;
-#define RichString_beginAllocated(this) memset(&this, 0, sizeof(RichString)); (this).chptr = (this).chstr;
-#define RichString_end(this) RichString_prune(&(this));
-
-#ifdef HAVE_LIBNCURSESW
-#define RichString_printVal(this, y, x) mvadd_wchstr(y, x, (this).chptr)
-#define RichString_printoffnVal(this, y, x, off, n) mvadd_wchnstr(y, x, (this).chptr + off, n)
-#define RichString_getCharVal(this, i) ((this).chptr[i].chars[0] & 255)
-#define RichString_setChar(this, at, ch) do{ (this)->chptr[(at)] = (CharType) { .chars = { ch, 0 } }; } while(0)
-#define CharType cchar_t
-#else
-#define RichString_printVal(this, y, x) mvaddchstr(y, x, (this).chptr)
-#define RichString_printoffnVal(this, y, x, off, n) mvaddchnstr(y, x, (this).chptr + off, n)
-#define RichString_getCharVal(this, i) ((this).chptr[i])
-#define RichString_setChar(this, at, ch) do{ (this)->chptr[(at)] = ch; } while(0)
-#define CharType chtype
-#endif
-
-typedef struct RichString_ {
-   int chlen;
-   CharType* chptr;
-   CharType chstr[RICHSTRING_MAXLEN+1];
-} RichString;
-
-}*/
-
-#ifndef CLAMP
-#define CLAMP(x,low,high) (((x)>(high))?(high):(((x)<(low))?(low):(x)))
-#endif
-
 #define charBytes(n) (sizeof(CharType) * (n))
 
 static void RichString_extendLen(RichString* this, int len) {

RichString.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_RichString
 #define HEADER_RichString
 /*
@@ -9,7 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#define RICHSTRING_MAXLEN 350
 
 #include "config.h"
 #include <ctype.h>
@@ -52,43 +49,36 @@ in the source distribution for its full text.
 #define CharType chtype
 #endif
 
+#define RICHSTRING_MAXLEN 350
+
 typedef struct RichString_ {
    int chlen;
    CharType* chptr;
    CharType chstr[RICHSTRING_MAXLEN+1];
 } RichString;
 
-
-#ifndef CLAMP
-#define CLAMP(x,low,high) (((x)>(high))?(high):(((x)<(low))?(low):(x)))
-#endif
-
-#define charBytes(n) (sizeof(CharType) * (n))
-
-#define RichString_setLen(this, len) do{ if(len < RICHSTRING_MAXLEN && this->chlen < RICHSTRING_MAXLEN) { RichString_setChar(this,len,0); this->chlen=len; } else RichString_extendLen(this,len); }while(0)
-
 #ifdef HAVE_LIBNCURSESW
 
-extern void RichString_setAttrn(RichString* this, int attrs, int start, int finish);
+void RichString_setAttrn(RichString* this, int attrs, int start, int finish);
 
-extern int RichString_findChar(RichString* this, char c, int start);
+int RichString_findChar(RichString* this, char c, int start);
 
 #else
 
-extern void RichString_setAttrn(RichString* this, int attrs, int start, int finish);
+void RichString_setAttrn(RichString* this, int attrs, int start, int finish);
 
-extern int RichString_findChar(RichString* this, char c, int start);
+int RichString_findChar(RichString* this, char c, int start);
 
 #endif
 
-extern void RichString_prune(RichString* this);
+void RichString_prune(RichString* this);
 
-extern void RichString_setAttr(RichString* this, int attrs);
+void RichString_setAttr(RichString* this, int attrs);
 
-extern void RichString_append(RichString* this, int attrs, const char* data);
+void RichString_append(RichString* this, int attrs, const char* data);
 
-extern void RichString_appendn(RichString* this, int attrs, const char* data, int len);
+void RichString_appendn(RichString* this, int attrs, const char* data, int len);
 
-extern void RichString_write(RichString* this, int attrs, const char* data);
+void RichString_write(RichString* this, int attrs, const char* data);
 
 #endif

ScreenManager.c

@@ -16,33 +16,6 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <stdbool.h>
 
-/*{
-#include "FunctionBar.h"
-#include "Vector.h"
-#include "Header.h"
-#include "Settings.h"
-#include "Panel.h"
-
-typedef enum Orientation_ {
-   VERTICAL,
-   HORIZONTAL
-} Orientation;
-
-typedef struct ScreenManager_ {
-   int x1;
-   int y1;
-   int x2;
-   int y2;
-   Orientation orientation;
-   Vector* panels;
-   int panelCount;
-   const Header* header;
-   const Settings* settings;
-   bool owner;
-   bool allowFocusChange;
-} ScreenManager;
-
-}*/
 
 ScreenManager* ScreenManager_new(int x1, int y1, int x2, int y2, Orientation orientation, const Header* header, const Settings* settings, bool owner) {
    ScreenManager* this;
@@ -190,22 +163,6 @@ void ScreenManager_run(ScreenManager* this, Panel** lastFocus, int* lastKey) {
       set_escdelay(25);
       ch = getch();
 
-      if (this->settings->vimMode) {
-         switch (ch) {
-            case 'h': ch = KEY_LEFT; break;
-            case 'j': ch = KEY_DOWN; break;
-            case 'k': ch = KEY_UP; break;
-            case 'l': ch = KEY_RIGHT; break;
-            case KEY_LEFT: ch = 'h'; break;
-            case KEY_DOWN: ch = 'j'; break;
-            case KEY_UP: ch = 'k'; break;
-            case KEY_RIGHT: ch = 'l'; break;
-            case 'K': ch = 'k'; break;
-            case 'J': ch = 'K'; break;
-            case 'L': ch = 'l'; break;
-         }
-      }
-
       HandlerResult result = IGNORED;
       if (ch == KEY_MOUSE && this->settings->enableMouse) {
          ch = ERR;

ScreenManager.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_ScreenManager
 #define HEADER_ScreenManager
 /*
@@ -9,7 +7,6 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-#include "FunctionBar.h"
 #include "Vector.h"
 #include "Header.h"
 #include "Settings.h"
@@ -34,19 +31,18 @@ typedef struct ScreenManager_ {
    bool allowFocusChange;
 } ScreenManager;
 
+ScreenManager* ScreenManager_new(int x1, int y1, int x2, int y2, Orientation orientation, const Header* header, const Settings* settings, bool owner);
 
-extern ScreenManager* ScreenManager_new(int x1, int y1, int x2, int y2, Orientation orientation, const Header* header, const Settings* settings, bool owner);
+void ScreenManager_delete(ScreenManager* this);
 
-extern void ScreenManager_delete(ScreenManager* this);
+int ScreenManager_size(ScreenManager* this);
 
-extern int ScreenManager_size(ScreenManager* this);
+void ScreenManager_add(ScreenManager* this, Panel* item, int size);
 
-extern void ScreenManager_add(ScreenManager* this, Panel* item, int size);
+Panel* ScreenManager_remove(ScreenManager* this, int idx);
 
-extern Panel* ScreenManager_remove(ScreenManager* this, int idx);
+void ScreenManager_resize(ScreenManager* this, int x1, int y1, int x2, int y2);
 
-extern void ScreenManager_resize(ScreenManager* this, int x1, int y1, int x2, int y2);
-
-extern void ScreenManager_run(ScreenManager* this, Panel** lastFocus, int* lastKey);
+void ScreenManager_run(ScreenManager* this, Panel** lastFocus, int* lastKey);
 
 #endif

Settings.c

@@ -17,64 +17,6 @@ in the source distribution for its full text.
 #include <string.h>
 #include <unistd.h>
 
-#define DEFAULT_DELAY 15
-
-/*{
-#include "Process.h"
-#include <stdbool.h>
-
-typedef struct {
-   int len;
-   char** names;
-   int* modes;
-} MeterColumnSettings;
-
-typedef struct Settings_ {
-   char* filename;
-
-   MeterColumnSettings columns[2];
-
-   ProcessField* fields;
-   int flags;
-   int colorScheme;
-   int delay;
-
-   int cpuCount;
-   int direction;
-   ProcessField sortKey;
-
-   bool countCPUsFromZero;
-   bool detailedCPUTime;
-   bool showCPUUsage;
-   bool showCPUFrequency;
-   bool treeView;
-   bool showProgramPath;
-   bool hideThreads;
-   bool shadowOtherUsers;
-   bool showThreadNames;
-   bool hideKernelThreads;
-   bool hideUserlandThreads;
-   bool highlightBaseName;
-   bool highlightMegabytes;
-   bool highlightThreads;
-   bool updateProcessNames;
-   bool accountGuestInCPUMeter;
-   bool headerMargin;
-   bool enableMouse;
-   bool vimMode;
-   #ifdef HAVE_LIBHWLOC
-   bool topologyAffinity;
-   #endif
-
-   bool changed;
-} Settings;
-
-#ifndef Settings_cpuId
-#define Settings_cpuId(settings, cpu) ((settings)->countCPUsFromZero ? (cpu) : (cpu)+1)
-#endif
-
-}*/
-
 void Settings_delete(Settings* this) {
    free(this->filename);
    free(this->fields);
@@ -121,7 +63,6 @@ static void Settings_defaultMeters(Settings* this) {
       this->columns[i].modes = xCalloc(sizes[i], sizeof(int));
       this->columns[i].len = sizes[i];
    }
-
    int r = 0;
    if (this->cpuCount > 8) {
       this->columns[0].names[0] = xStrdup("LeftCPUs2");
@@ -141,7 +82,6 @@ static void Settings_defaultMeters(Settings* this) {
    this->columns[0].modes[1] = BAR_METERMODE;
    this->columns[0].names[2] = xStrdup("Swap");
    this->columns[0].modes[2] = BAR_METERMODE;
-
    this->columns[1].names[r] = xStrdup("Tasks");
    this->columns[1].modes[r++] = TEXT_METERMODE;
    this->columns[1].names[r] = xStrdup("LoadAverage");
@@ -172,13 +112,11 @@ static void readFields(ProcessField* fields, int* flags, const char* line) {
 
 static bool Settings_read(Settings* this, const char* fileName) {
    FILE* fd;
-
    CRT_dropPrivileges();
    fd = fopen(fileName, "r");
    CRT_restorePrivileges();
    if (!fd)
       return false;
-
    bool didReadMeters = false;
    bool didReadFields = false;
    for (;;) {
@@ -257,8 +195,6 @@ static bool Settings_read(Settings* this, const char* fileName) {
       } else if (String_eq(option[0], "right_meter_modes")) {
          Settings_readMeterModes(this, option[1], 1);
          didReadMeters = true;
-      } else if (String_eq(option[0], "vim_mode")) {
-         this->vimMode = atoi(option[1]);
       #ifdef HAVE_LIBHWLOC
       } else if (String_eq(option[0], "topology_affinity")) {
          this->topologyAffinity = !!atoi(option[1]);
@@ -342,7 +278,6 @@ bool Settings_write(Settings* this) {
    fprintf(fd, "left_meter_modes="); writeMeterModes(this, fd, 0);
    fprintf(fd, "right_meters="); writeMeters(this, fd, 1);
    fprintf(fd, "right_meter_modes="); writeMeterModes(this, fd, 1);
-   fprintf(fd, "vim_mode=%d\n", (int) this->vimMode);
    #ifdef HAVE_LIBHWLOC
    fprintf(fd, "topology_affinity=%d\n", (int) this->topologyAffinity);
    #endif
@@ -351,7 +286,6 @@ bool Settings_write(Settings* this) {
 }
 
 Settings* Settings_new(int cpuCount) {
-
    Settings* this = xCalloc(1, sizeof(Settings));
 
    this->sortKey = PERCENT_CPU;
@@ -375,7 +309,6 @@ Settings* Settings_new(int cpuCount) {
    #ifdef HAVE_LIBHWLOC
    this->topologyAffinity = false;
    #endif
-
    this->fields = xCalloc(Platform_numberOfFields+1, sizeof(ProcessField));
    // TODO: turn 'fields' into a Vector,
    // (and ProcessFields into proper objects).
@@ -406,7 +339,6 @@ Settings* Settings_new(int cpuCount) {
          htopDir = String_cat(home, "/.config/htop");
       }
       legacyDotfile = String_cat(home, "/.htoprc");
-
       CRT_dropPrivileges();
       (void) mkdir(configDir, 0700);
       (void) mkdir(htopDir, 0700);

Settings.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Settings
 #define HEADER_Settings
 /*
@@ -22,7 +20,6 @@ typedef struct {
 
 typedef struct Settings_ {
    char* filename;
-
    MeterColumnSettings columns[2];
 
    ProcessField* fields;
@@ -52,7 +49,6 @@ typedef struct Settings_ {
    bool accountGuestInCPUMeter;
    bool headerMargin;
    bool enableMouse;
-   bool vimMode;
    #ifdef HAVE_LIBHWLOC
    bool topologyAffinity;
    #endif
@@ -60,17 +56,14 @@ typedef struct Settings_ {
    bool changed;
 } Settings;
 
-#ifndef Settings_cpuId
 #define Settings_cpuId(settings, cpu) ((settings)->countCPUsFromZero ? (cpu) : (cpu)+1)
-#endif
 
+void Settings_delete(Settings* this);
 
-extern void Settings_delete(Settings* this);
+bool Settings_write(Settings* this);
 
-extern bool Settings_write(Settings* this);
+Settings* Settings_new(int cpuCount);
 
-extern Settings* Settings_new(int cpuCount);
-
-extern void Settings_invertSortOrder(Settings* this);
+void Settings_invertSortOrder(Settings* this);
 
 #endif

SignalsPanel.c

@@ -18,14 +18,6 @@ in the source distribution for its full text.
 
 #include <ctype.h>
 
-/*{
-
-typedef struct SignalItem_ {
-   const char* name;
-   int number;
-} SignalItem;
-
-}*/
 
 Panel* SignalsPanel_new() {
    Panel* this = Panel_new(1, 1, 1, 1, true, Class(ListItem), FunctionBar_newEnterEsc("Send   ", "Cancel "));

SignalsPanel.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_SignalsPanel
 #define HEADER_SignalsPanel
 /*
@@ -9,13 +7,11 @@ Released under the GNU GPL, see the COPYING file
 in the source distribution for its full text.
 */
 
-
 typedef struct SignalItem_ {
    const char* name;
    int number;
 } SignalItem;
 
-
-extern Panel* SignalsPanel_new();
+Panel* SignalsPanel_new();
 
 #endif

StringUtils.c

@@ -14,18 +14,6 @@ in the source distribution for its full text.
 #include <strings.h>
 #include <stdlib.h>
 
-/*{
-#include <stdio.h>
-
-#define String_startsWith(s, match) (strncmp((s),(match),strlen(match)) == 0)
-#define String_contains_i(s1, s2) (strcasestr(s1, s2) != NULL)
-}*/
-
-/*
- * String_startsWith gives better performance if strlen(match) can be computed
- * at compile time (e.g. when they are immutable string literals). :)
- */
-
 char* String_cat(const char* s1, const char* s2) {
    int l1 = strlen(s1);
    int l2 = strlen(s2);

StringUtils.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_StringUtils
 #define HEADER_StringUtils
 /*
@@ -19,18 +17,18 @@ in the source distribution for its full text.
  * at compile time (e.g. when they are immutable string literals). :)
  */
 
-extern char* String_cat(const char* s1, const char* s2);
+char* String_cat(const char* s1, const char* s2);
 
-extern char* String_trim(const char* in);
+char* String_trim(const char* in);
 
-extern int String_eq(const char* s1, const char* s2);
+int String_eq(const char* s1, const char* s2);
 
-extern char** String_split(const char* s, char sep, int* n);
+char** String_split(const char* s, char sep, int* n);
 
-extern void String_freeArray(char** s);
+void String_freeArray(char** s);
 
-extern char* String_getToken(const char* line, const unsigned short int numMatch);
+char* String_getToken(const char* line, const unsigned short int numMatch);
 
-extern char* String_readLine(FILE* fd);
+char* String_readLine(FILE* fd);
 
 #endif

SwapMeter.c

@@ -16,9 +16,6 @@ in the source distribution for its full text.
 #include <sys/param.h>
 #include <assert.h>
 
-/*{
-#include "Meter.h"
-}*/
 
 int SwapMeter_attributes[] = {
    SWAP

SwapMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_SwapMeter
 #define HEADER_SwapMeter
 /*

TasksMeter.c

@@ -10,9 +10,6 @@ in the source distribution for its full text.
 #include "Platform.h"
 #include "CRT.h"
 
-/*{
-#include "Meter.h"
-}*/
 
 int TasksMeter_attributes[] = {
    CPU_SYSTEM, PROCESS_THREAD, PROCESS, TASKS_RUNNING
@@ -23,7 +20,7 @@ static void TasksMeter_updateValues(Meter* this, char* buffer, int len) {
    this->values[0] = pl->kernelThreads;
    this->values[1] = pl->userlandThreads;
    this->values[2] = pl->totalTasks - pl->kernelThreads - pl->userlandThreads;
-   this->values[3] = MIN(pl->runningTasks, pl->cpuCount);
+   this->values[3] = MINIMUM(pl->runningTasks, pl->cpuCount);
    if (pl->totalTasks > this->total) {
       this->total = pl->totalTasks;
    }

TasksMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_TasksMeter
 #define HEADER_TasksMeter
 /*

TraceScreen.c

@@ -8,7 +8,6 @@ in the source distribution for its full text.
 #include "TraceScreen.h"
 
 #include "CRT.h"
-#include "InfoScreen.h"
 #include "ProcessList.h"
 #include "ListItem.h"
 #include "IncSet.h"
@@ -27,21 +26,6 @@ in the source distribution for its full text.
 #include <sys/wait.h>
 #include <signal.h>
 
-/*{
-#include "InfoScreen.h"
-
-typedef struct TraceScreen_ {
-   InfoScreen super;
-   bool tracing;
-   int fdpair[2];
-   int child;
-   FILE* strace;
-   int fd_strace;
-   bool contLine;
-   bool follow;
-} TraceScreen;
-
-}*/
 
 static const char* const TraceScreenFunctions[] = {"Search ", "Filter ", "AutoScroll ", "Stop Tracing   ", "Done   ", NULL};
 

TraceScreen.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_TraceScreen
 #define HEADER_TraceScreen
 /*
@@ -25,16 +23,16 @@ typedef struct TraceScreen_ {
 
 extern InfoScreenClass TraceScreen_class;
 
-extern TraceScreen* TraceScreen_new(Process* process);
+TraceScreen* TraceScreen_new(Process* process);
 
-extern void TraceScreen_delete(Object* cast);
+void TraceScreen_delete(Object* cast);
 
-extern void TraceScreen_draw(InfoScreen* this);
+void TraceScreen_draw(InfoScreen* this);
 
-extern bool TraceScreen_forkTracer(TraceScreen* this);
+bool TraceScreen_forkTracer(TraceScreen* this);
 
-extern void TraceScreen_updateTrace(InfoScreen* super);
+void TraceScreen_updateTrace(InfoScreen* super);
 
-extern bool TraceScreen_onKey(InfoScreen* super, int ch);
+bool TraceScreen_onKey(InfoScreen* super, int ch);
 
 #endif

UptimeMeter.c

@@ -9,9 +9,6 @@ in the source distribution for its full text.
 #include "Platform.h"
 #include "CRT.h"
 
-/*{
-#include "Meter.h"
-}*/
 
 int UptimeMeter_attributes[] = {
    UPTIME

UptimeMeter.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_UptimeMeter
 #define HEADER_UptimeMeter
 /*

UsersTable.c

@@ -18,13 +18,6 @@ in the source distribution for its full text.
 #include <stdlib.h>
 #include <assert.h>
 
-/*{
-#include "Hashtable.h"
-
-typedef struct UsersTable_ {
-   Hashtable* users;
-} UsersTable;
-}*/
 
 UsersTable* UsersTable_new() {
    UsersTable* this;

UsersTable.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_UsersTable
 #define HEADER_UsersTable
 /*
@@ -15,12 +13,12 @@ typedef struct UsersTable_ {
    Hashtable* users;
 } UsersTable;
 
-extern UsersTable* UsersTable_new();
+UsersTable* UsersTable_new();
 
-extern void UsersTable_delete(UsersTable* this);
+void UsersTable_delete(UsersTable* this);
 
-extern char* UsersTable_getRef(UsersTable* this, unsigned int uid);
+char* UsersTable_getRef(UsersTable* this, unsigned int uid);
 
-extern void UsersTable_foreach(UsersTable* this, Hashtable_PairFunction f, void* userData);
+void UsersTable_foreach(UsersTable* this, Hashtable_PairFunction f, void* userData);
 
 #endif

Vector.c

@@ -12,25 +12,6 @@ in the source distribution for its full text.
 #include <string.h>
 #include <stdbool.h>
 
-/*{
-#include "Object.h"
-
-#define swap(a_,x_,y_) do{ void* tmp_ = a_[x_]; a_[x_] = a_[y_]; a_[y_] = tmp_; }while(0)
-
-#ifndef DEFAULT_SIZE
-#define DEFAULT_SIZE -1
-#endif
-
-typedef struct Vector_ {
-   Object **array;
-   ObjectClass* type;
-   int arraySize;
-   int growthRate;
-   int items;
-   bool owner;
-} Vector;
-
-}*/
 
 Vector* Vector_new(ObjectClass* type, bool owner, int size) {
    Vector* this;
@@ -280,7 +261,7 @@ inline Object* Vector_get(Vector* this, int idx) {
 
 #else
 
-#define Vector_get(v_, idx_) ((v_)->array[idx_])
+// In this case, Vector_get is defined as a macro in vector.h
 
 #endif
 
@@ -293,7 +274,7 @@ inline int Vector_size(Vector* this) {
 
 #else
 
-#define Vector_size(v_) ((v_)->items)
+// In this case, Vector_size is defined as a macro in vector.h
 
 #endif
 

Vector.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Vector
 #define HEADER_Vector
 /*
@@ -26,43 +24,37 @@ typedef struct Vector_ {
    bool owner;
 } Vector;
 
+Vector* Vector_new(ObjectClass* type, bool owner, int size);
 
-extern Vector* Vector_new(ObjectClass* type, bool owner, int size);
-
-extern void Vector_delete(Vector* this);
+void Vector_delete(Vector* this);
 
 #ifdef DEBUG
 
-extern int Vector_count(Vector* this);
+int Vector_count(Vector* this);
 
 #endif
 
-extern void Vector_prune(Vector* this);
+void Vector_prune(Vector* this);
 
-// If I were to use only one sorting algorithm for both cases, it would probably be this one:
-/*
+void Vector_quickSort(Vector* this);
 
-*/
+void Vector_insertionSort(Vector* this);
 
-extern void Vector_quickSort(Vector* this);
+void Vector_insert(Vector* this, int idx, void* data_);
 
-extern void Vector_insertionSort(Vector* this);
+Object* Vector_take(Vector* this, int idx);
 
-extern void Vector_insert(Vector* this, int idx, void* data_);
+Object* Vector_remove(Vector* this, int idx);
 
-extern Object* Vector_take(Vector* this, int idx);
+void Vector_moveUp(Vector* this, int idx);
 
-extern Object* Vector_remove(Vector* this, int idx);
+void Vector_moveDown(Vector* this, int idx);
 
-extern void Vector_moveUp(Vector* this, int idx);
-
-extern void Vector_moveDown(Vector* this, int idx);
-
-extern void Vector_set(Vector* this, int idx, void* data_);
+void Vector_set(Vector* this, int idx, void* data_);
 
 #ifdef DEBUG
 
-extern Object* Vector_get(Vector* this, int idx);
+Object* Vector_get(Vector* this, int idx);
 
 #else
 
@@ -72,7 +64,7 @@ extern Object* Vector_get(Vector* this, int idx);
 
 #ifdef DEBUG
 
-extern int Vector_size(Vector* this);
+int Vector_size(Vector* this);
 
 #else
 
@@ -80,13 +72,9 @@ extern int Vector_size(Vector* this);
 
 #endif
 
-/*
+void Vector_add(Vector* this, void* data_);
 
-*/
-
-extern void Vector_add(Vector* this, void* data_);
-
-extern int Vector_indexOf(Vector* this, void* search_, Object_Compare compare);
+int Vector_indexOf(Vector* this, void* search_, Object_Compare compare);
 
 void Vector_splice(Vector* this, Vector* from);
 

XAlloc.c

@@ -8,11 +8,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-/*{
-#include <err.h>
-#include <assert.h>
-#include <stdlib.h>
-}*/
 
 void fail() {
    curs_set(1);

XAlloc.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_XAlloc
 #define HEADER_XAlloc
 
@@ -11,13 +9,13 @@
 #include <assert.h>
 #include <stdlib.h>
 
-extern void fail(void);
+void fail(void);
 
-extern void* xMalloc(size_t size);
+void* xMalloc(size_t size);
 
-extern void* xCalloc(size_t nmemb, size_t size);
+void* xCalloc(size_t nmemb, size_t size);
 
-extern void* xRealloc(void* ptr, size_t size);
+void* xRealloc(void* ptr, size_t size);
 
 #undef xAsprintf
 
@@ -38,9 +36,9 @@ extern void* xRealloc(void* ptr, size_t size);
 #endif
 #if (__has_attribute(nonnull) || \
     ((__GNUC__ > 3) || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)))
-extern char* xStrdup_(const char* str) __attribute__((nonnull));
+char* xStrdup_(const char* str) __attribute__((nonnull));
 #endif // __has_attribute(nonnull) || GNU C 3.3 or later
 
-extern char* xStrdup_(const char* str);
+char* xStrdup_(const char* str);
 
 #endif

configure.ac

@@ -2,7 +2,7 @@
 # Process this file with autoconf to produce a configure script.
 
 AC_PREREQ(2.65)
-AC_INIT([htop],[3.0.0],[htop@groups.io])
+AC_INIT([htop],[3.0.2],[htop@groups.io])
 
 AC_CONFIG_SRCDIR([htop.c])
 AC_CONFIG_AUX_DIR([.])
@@ -111,20 +111,12 @@ AC_SUBST(wextra_flag)
 # ----------------------------------------------------------------------
 PROCDIR=/proc
 
-AC_ARG_ENABLE(proc, [AS_HELP_STRING([--enable-proc], [use Linux-compatible proc filesystem])], enable_proc="yes", enable_proc="no")
-if test "x$enable_proc" = xyes; then
-   # An enabled proc assumes we're emulating Linux.
-   my_htop_platform=linux
-   AC_DEFINE(HAVE_PROC, 1, [Define if using a Linux-compatible proc filesystem.])
-fi
-
 AC_ARG_WITH(proc, [AS_HELP_STRING([--with-proc=DIR], [Location of a Linux-compatible proc filesystem (default=/proc).])],
-
-if test -n "$withval"; then
+  if test -n "$withval"; then
     AC_DEFINE_UNQUOTED(PROCDIR, "$withval", [Path of proc filesystem])
     PROCDIR="$withval"
-fi,
-AC_DEFINE(PROCDIR, "/proc", [Path of proc filesystem]))
+  fi,
+  AC_DEFINE(PROCDIR, "/proc", [Path of proc filesystem]))
 
 if test "x$cross_compiling" = xno; then
    if test "x$enable_proc" = xyes; then
@@ -324,7 +316,6 @@ AM_CONDITIONAL([HTOP_SOLARIS], [test "$my_htop_platform" = solaris])
 AM_CONDITIONAL([HTOP_UNSUPPORTED], [test "$my_htop_platform" = unsupported])
 AC_SUBST(my_htop_platform)
 AC_CONFIG_FILES([Makefile htop.1])
-AC_CONFIG_FILES([scripts/MakeHeader.py], [chmod +x scripts/MakeHeader.py])
 AC_OUTPUT
 
 if test "$my_htop_platform" = "unsupported"
@@ -340,3 +331,20 @@ then
    echo "****************************************************************"
    echo ""
 fi
+
+AC_MSG_RESULT([
+  ${PACKAGE_NAME} ${VERSION}
+
+  platform:                $my_htop_platform
+  proc directory:          $PROCDIR
+  openvz:                  $enable_openvz
+  cgroup:                  $enable_cgroup
+  vserver:                 $enable_vserver
+  ancient vserver:         $enable_ancient_vserver
+  taskstats:               $enable_taskstats
+  unicode:                 $enable_unicode
+  linux affinity:          $enable_linux_affinity
+  hwlock:                  $enable_hwloc
+  setuid:                  $enable_setuid
+  linux delay accounting:  $enable_delayacct
+])

darwin/Battery.h

@@ -1,9 +1,6 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_Battery
 #define HEADER_Battery
 
 void Battery_getData(double* level, ACPresence* isOnAC);
 
-
 #endif

darwin/DarwinCRT.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_DarwinCRT
 #define HEADER_DarwinCRT
 /*
@@ -11,5 +9,4 @@ in the source distribution for its full text.
 
 void CRT_handleSIGSEGV(int sgn);
 
-
 #endif

darwin/DarwinProcess.c

@@ -15,21 +15,6 @@ in the source distribution for its full text.
 
 #include <mach/mach.h>
 
-/*{
-#include "Settings.h"
-#include "DarwinProcessList.h"
-
-#include <sys/sysctl.h>
-
-typedef struct DarwinProcess_ {
-   Process super;
-
-   uint64_t utime;
-   uint64_t stime;
-   bool taskAccess;
-} DarwinProcess;
-
-}*/
 
 ProcessClass DarwinProcess_class = {
    .super = {

darwin/DarwinProcess.h

@@ -1,5 +1,3 @@
-/* Do not edit this file. It was automatically generated. */
-
 #ifndef HEADER_DarwinProcess
 #define HEADER_DarwinProcess
 /*
@@ -22,7 +20,6 @@ typedef struct DarwinProcess_ {
    bool taskAccess;
 } DarwinProcess;
 
-
 extern ProcessClass DarwinProcess_class;
 
 DarwinProcess* DarwinProcess_new(Settings* settings);