2006-03-04 18:16:49 +00:00
|
|
|
/*
|
|
|
|
htop - Process.c
|
2015-03-21 19:52:54 +00:00
|
|
|
(C) 2004-2015 Hisham H. Muhammad
|
2020-08-19 23:35:24 +00:00
|
|
|
(C) 2020 Red Hat, Inc. All Rights Reserved.
|
2020-10-05 07:51:32 +00:00
|
|
|
Released under the GNU GPLv2, see the COPYING file
|
2006-03-04 18:16:49 +00:00
|
|
|
in the source distribution for its full text.
|
|
|
|
*/
|
|
|
|
|
2020-09-19 11:55:23 +00:00
|
|
|
#include "config.h" // IWYU pragma: keep
|
|
|
|
|
2011-12-26 21:35:57 +00:00
|
|
|
#include "Process.h"
|
2015-03-17 02:01:48 +00:00
|
|
|
|
2020-09-19 11:55:23 +00:00
|
|
|
#include <assert.h>
|
|
|
|
#include <limits.h>
|
|
|
|
#include <math.h>
|
|
|
|
#include <signal.h>
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <time.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
#include <sys/resource.h>
|
2018-12-30 04:18:27 +00:00
|
|
|
|
2006-03-04 18:16:49 +00:00
|
|
|
#include "CRT.h"
|
2014-11-27 22:10:23 +00:00
|
|
|
#include "Platform.h"
|
2020-09-19 11:55:23 +00:00
|
|
|
#include "RichString.h"
|
|
|
|
#include "Settings.h"
|
2020-10-14 18:21:09 +00:00
|
|
|
#include "XUtils.h"
|
2006-03-04 18:16:49 +00:00
|
|
|
|
2020-09-19 11:55:23 +00:00
|
|
|
#if defined(MAJOR_IN_MKDEV)
|
2018-02-26 13:15:05 +00:00
|
|
|
#include <sys/mkdev.h>
|
2018-12-15 13:06:00 +00:00
|
|
|
#elif defined(MAJOR_IN_SYSMACROS)
|
2018-02-26 13:15:05 +00:00
|
|
|
#include <sys/sysmacros.h>
|
|
|
|
#endif
|
2006-03-04 18:16:49 +00:00
|
|
|
|
2020-09-19 11:55:23 +00:00
|
|
|
|
2006-07-12 01:35:59 +00:00
|
|
|
static int Process_getuid = -1;
|
|
|
|
|
2016-02-10 20:48:04 +00:00
|
|
|
char Process_pidFormat[20] = "%7d ";
|
2015-08-20 03:32:47 +00:00
|
|
|
|
|
|
|
static char Process_titleBuffer[20][20];
|
|
|
|
|
|
|
|
void Process_setupColumnWidths() {
|
|
|
|
int maxPid = Platform_getMaxPid();
|
|
|
|
if (maxPid == -1) return;
|
|
|
|
int digits = ceil(log10(maxPid));
|
|
|
|
assert(digits < 20);
|
|
|
|
for (int i = 0; Process_pidColumns[i].label; i++) {
|
|
|
|
assert(i < 20);
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(Process_titleBuffer[i], 20, "%*s ", digits, Process_pidColumns[i].label);
|
2015-08-20 03:32:47 +00:00
|
|
|
Process_fields[Process_pidColumns[i].id].title = Process_titleBuffer[i];
|
|
|
|
}
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(Process_pidFormat, sizeof(Process_pidFormat), "%%%dd ", digits);
|
2015-08-20 03:32:47 +00:00
|
|
|
}
|
|
|
|
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
void Process_humanNumber(RichString* str, unsigned long long number, bool coloring) {
|
2006-03-04 18:16:49 +00:00
|
|
|
char buffer[11];
|
|
|
|
int len;
|
2019-10-31 16:39:12 +00:00
|
|
|
|
2014-04-24 18:00:09 +00:00
|
|
|
int largeNumberColor = CRT_colors[LARGE_NUMBER];
|
|
|
|
int processMegabytesColor = CRT_colors[PROCESS_MEGABYTES];
|
2020-09-13 21:50:24 +00:00
|
|
|
int processGigabytesColor = CRT_colors[PROCESS_GIGABYTES];
|
2014-04-24 18:00:09 +00:00
|
|
|
int processColor = CRT_colors[PROCESS];
|
|
|
|
if (!coloring) {
|
|
|
|
largeNumberColor = CRT_colors[PROCESS];
|
|
|
|
processMegabytesColor = CRT_colors[PROCESS];
|
2020-09-13 21:50:24 +00:00
|
|
|
processGigabytesColor = CRT_colors[PROCESS];
|
2014-04-24 18:00:09 +00:00
|
|
|
}
|
2019-10-31 16:39:12 +00:00
|
|
|
|
2020-09-13 21:50:24 +00:00
|
|
|
if (number < 1000) {
|
|
|
|
//Plain number, no markings
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%5llu ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processColor, buffer, len);
|
|
|
|
} else if (number < 100000) {
|
|
|
|
//2 digit MB, 3 digit KB
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%2llu", number/1000);
|
2014-04-24 18:00:09 +00:00
|
|
|
RichString_appendn(str, processMegabytesColor, buffer, len);
|
2006-03-04 18:16:49 +00:00
|
|
|
number %= 1000;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%03llu ", number);
|
2014-04-24 18:00:09 +00:00
|
|
|
RichString_appendn(str, processColor, buffer, len);
|
2020-09-13 21:50:24 +00:00
|
|
|
} else if (number < 1000 * ONE_K) {
|
|
|
|
//3 digit MB
|
|
|
|
number /= ONE_K;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%4lluM ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processMegabytesColor, buffer, len);
|
|
|
|
} else if (number < 10000 * ONE_K) {
|
|
|
|
//1 digit GB, 3 digit MB
|
|
|
|
number /= ONE_K;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%1llu", number/1000);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processGigabytesColor, buffer, len);
|
|
|
|
number %= 1000;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%03lluM ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processMegabytesColor, buffer, len);
|
2020-09-20 17:54:53 +00:00
|
|
|
} else if (number < 100000 * ONE_K) {
|
2020-09-13 21:50:24 +00:00
|
|
|
//2 digit GB, 1 digit MB
|
|
|
|
number /= 100 * ONE_K;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%2llu", number/10);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processGigabytesColor, buffer, len);
|
|
|
|
number %= 10;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, ".%1lluG ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processMegabytesColor, buffer, len);
|
|
|
|
} else if (number < 1000 * ONE_M) {
|
|
|
|
//3 digit GB
|
|
|
|
number /= ONE_M;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%4lluG ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processGigabytesColor, buffer, len);
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
} else if (number < 10000ULL * ONE_M) {
|
2020-09-13 21:50:24 +00:00
|
|
|
//1 digit TB, 3 digit GB
|
|
|
|
number /= ONE_M;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%1llu", number/1000);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, largeNumberColor, buffer, len);
|
|
|
|
number %= 1000;
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
len = snprintf(buffer, 10, "%03lluG ", number);
|
2020-09-13 21:50:24 +00:00
|
|
|
RichString_appendn(str, processGigabytesColor, buffer, len);
|
|
|
|
} else {
|
|
|
|
//2 digit TB and above
|
|
|
|
len = snprintf(buffer, 10, "%4.1lfT ", (double)number/ONE_G);
|
|
|
|
RichString_appendn(str, largeNumberColor, buffer, len);
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-16 04:43:04 +00:00
|
|
|
void Process_colorNumber(RichString* str, unsigned long long number, bool coloring) {
|
2011-05-26 16:31:18 +00:00
|
|
|
char buffer[14];
|
2014-04-24 18:00:09 +00:00
|
|
|
|
|
|
|
int largeNumberColor = CRT_colors[LARGE_NUMBER];
|
|
|
|
int processMegabytesColor = CRT_colors[PROCESS_MEGABYTES];
|
|
|
|
int processColor = CRT_colors[PROCESS];
|
|
|
|
int processShadowColor = CRT_colors[PROCESS_SHADOW];
|
|
|
|
if (!coloring) {
|
|
|
|
largeNumberColor = CRT_colors[PROCESS];
|
|
|
|
processMegabytesColor = CRT_colors[PROCESS];
|
|
|
|
processShadowColor = CRT_colors[PROCESS];
|
|
|
|
}
|
|
|
|
|
Process.{h,c}: Use integer types that are more portable
When building on a 32-bit system, the compiler warned that the
following line uses a constant whose value is the overflow result
of a compile-time computation:
Process.c (line 109): } else if (number < 10000 * ONE_M) {
Namely, this constant expression:
10000 * ONE_M
was intended to produce the following value:
10485760000
However, the result overflowed to produce:
1895825408
The reason for this overflow is as follows:
o The macros are expanded:
10000 * (ONE_K * ONE_K)
10000 * (1024L * 1024L)
o The untyped constant expression "10000" is typed:
10000U * (1024L * 1024L)
o The parenthesized expression is evaluated:
10000U * (1048576L)
o The left operand ("10000U") is converted:
10000L * (1048576L)
Unbound by integer sizes, that last multiplication
would produce the following value:
10485760000
However, on a 32-bit machine, where a long is 32 bits
(really 31 bits when talking about positive numbers),
the maximum value that can be computed is 2**31-1:
2147483647
Consequently, the computation overflows.
o The compiler produces a long int value that is the
the result of overflow (10485760000 % 2**31):
1895825408L
Actually, I think this overflow is implementation-defined,
so it's not even a portable description of what happens.
The solution is to use a long long int (or, even better,
an unsigned long long int) type for the constant expression;
the C standard mandates a sufficiently large maximum value
for such types.
Hence, the following change is made to the bad line:
- } else if (number < 10000 * ONE_M) {
+ } else if (number < 10000ULL * ONE_M) {
However, the whole line is now patently silly, because the
variable "number" is typed "unsigned long", and so it will
always be less than the constant expression (the compiler
will warn about this, too).
Hence, "number" must be typed "unsigned long long"; however,
this necessitates changing all of the string formats from
something like "%lu" to something like "%llu".
Et voila! This commit is born.
Then, for the sake of completeness, the declared types of the
constant-expression macros are updated:
o ONE_K is made unsigned (a "UL" instead of "L")
o ONE_T is computed by introducing "1ULL *"
o Similar changes are made for ONE_DECIMAL_{K,T}
Also, a non-portable overflow-conversion to a signed value
has been replaced with a portable comparison:
- if ((long long) number == -1LL) {
+ if (number == ULLONG_MAX) {
It might be worth reviewing the rest of the code for other
cases where overflows are not handled correctly; even at
runtime, it's often necessary to check for overflow unless
such behavior is expected (especially for signed integer
values, for which overflow has implementation-defined
behavior).
2020-09-29 14:04:22 +00:00
|
|
|
if (number == ULLONG_MAX) {
|
2017-07-10 23:57:34 +00:00
|
|
|
int len = snprintf(buffer, 13, " no perm ");
|
|
|
|
RichString_appendn(str, CRT_colors[PROCESS_SHADOW], buffer, len);
|
2018-12-30 12:18:35 +00:00
|
|
|
} else if (number >= 100000LL * ONE_DECIMAL_T) {
|
|
|
|
xSnprintf(buffer, 13, "%11llu ", number / ONE_DECIMAL_G);
|
|
|
|
RichString_appendn(str, largeNumberColor, buffer, 12);
|
|
|
|
} else if (number >= 100LL * ONE_DECIMAL_T) {
|
|
|
|
xSnprintf(buffer, 13, "%11llu ", number / ONE_DECIMAL_M);
|
2018-12-18 13:05:09 +00:00
|
|
|
RichString_appendn(str, largeNumberColor, buffer, 8);
|
|
|
|
RichString_appendn(str, processMegabytesColor, buffer+8, 4);
|
2018-12-30 12:18:35 +00:00
|
|
|
} else if (number >= 10LL * ONE_DECIMAL_G) {
|
|
|
|
xSnprintf(buffer, 13, "%11llu ", number / ONE_DECIMAL_K);
|
2014-04-24 18:00:09 +00:00
|
|
|
RichString_appendn(str, largeNumberColor, buffer, 5);
|
|
|
|
RichString_appendn(str, processMegabytesColor, buffer+5, 3);
|
|
|
|
RichString_appendn(str, processColor, buffer+8, 4);
|
2011-05-26 16:31:18 +00:00
|
|
|
} else {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, 13, "%11llu ", number);
|
2014-04-24 18:00:09 +00:00
|
|
|
RichString_appendn(str, largeNumberColor, buffer, 2);
|
|
|
|
RichString_appendn(str, processMegabytesColor, buffer+2, 3);
|
|
|
|
RichString_appendn(str, processColor, buffer+5, 3);
|
|
|
|
RichString_appendn(str, processShadowColor, buffer+8, 4);
|
2011-05-26 16:31:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-17 02:01:48 +00:00
|
|
|
void Process_printTime(RichString* str, unsigned long long totalHundredths) {
|
|
|
|
unsigned long long totalSeconds = totalHundredths / 100;
|
2006-03-04 18:16:49 +00:00
|
|
|
|
2015-03-17 02:01:48 +00:00
|
|
|
unsigned long long hours = totalSeconds / 3600;
|
|
|
|
int minutes = (totalSeconds / 60) % 60;
|
|
|
|
int seconds = totalSeconds % 60;
|
|
|
|
int hundredths = totalHundredths - (totalSeconds * 100);
|
2006-03-04 18:16:49 +00:00
|
|
|
char buffer[11];
|
2011-12-14 23:29:07 +00:00
|
|
|
if (hours >= 100) {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, 10, "%7lluh ", hours);
|
2006-03-04 18:16:49 +00:00
|
|
|
RichString_append(str, CRT_colors[LARGE_NUMBER], buffer);
|
|
|
|
} else {
|
2011-12-14 23:29:07 +00:00
|
|
|
if (hours) {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, 10, "%2lluh", hours);
|
2011-12-14 23:29:07 +00:00
|
|
|
RichString_append(str, CRT_colors[LARGE_NUMBER], buffer);
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, 10, "%02d:%02d ", minutes, seconds);
|
2011-12-14 23:29:07 +00:00
|
|
|
} else {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, 10, "%2d:%02d.%02d ", minutes, seconds, hundredths);
|
2011-12-14 23:29:07 +00:00
|
|
|
}
|
|
|
|
RichString_append(str, CRT_colors[DEFAULT_COLOR], buffer);
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-13 12:26:40 +00:00
|
|
|
void Process_fillStarttimeBuffer(Process* this) {
|
|
|
|
struct tm date;
|
|
|
|
(void) localtime_r(&this->starttime_ctime, &date);
|
|
|
|
strftime(this->starttime_show, sizeof(this->starttime_show) - 1, (this->starttime_ctime > (time(NULL) - 86400)) ? "%R " : "%b%d ", &date);
|
|
|
|
}
|
|
|
|
|
2020-10-06 10:28:11 +00:00
|
|
|
static inline void Process_writeCommand(const Process* this, int attr, int baseattr, RichString* str) {
|
2015-07-29 19:14:29 +00:00
|
|
|
int start = RichString_size(str), finish = 0;
|
2020-10-06 10:28:11 +00:00
|
|
|
const char* comm = this->comm;
|
2015-07-29 19:14:29 +00:00
|
|
|
|
|
|
|
if (this->settings->highlightBaseName || !this->settings->showProgramPath) {
|
|
|
|
int i, basename = 0;
|
|
|
|
for (i = 0; i < this->basenameOffset; i++) {
|
|
|
|
if (comm[i] == '/') {
|
|
|
|
basename = i + 1;
|
|
|
|
} else if (comm[i] == ':') {
|
|
|
|
finish = i + 1;
|
|
|
|
break;
|
2014-02-27 20:11:23 +00:00
|
|
|
}
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
2015-07-29 19:14:29 +00:00
|
|
|
if (!finish) {
|
|
|
|
if (this->settings->showProgramPath)
|
|
|
|
start += basename;
|
|
|
|
else
|
|
|
|
comm += basename;
|
|
|
|
finish = this->basenameOffset - basename;
|
|
|
|
}
|
|
|
|
finish += start - 1;
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
2015-07-29 19:14:29 +00:00
|
|
|
|
|
|
|
RichString_append(str, attr, comm);
|
|
|
|
|
|
|
|
if (this->settings->highlightBaseName)
|
|
|
|
RichString_setAttrn(str, baseattr, start, finish);
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
|
2015-03-16 04:43:04 +00:00
|
|
|
void Process_outputRate(RichString* str, char* buffer, int n, double rate, int coloring) {
|
2015-01-22 01:27:31 +00:00
|
|
|
int largeNumberColor = CRT_colors[LARGE_NUMBER];
|
|
|
|
int processMegabytesColor = CRT_colors[PROCESS_MEGABYTES];
|
|
|
|
int processColor = CRT_colors[PROCESS];
|
|
|
|
if (!coloring) {
|
|
|
|
largeNumberColor = CRT_colors[PROCESS];
|
|
|
|
processMegabytesColor = CRT_colors[PROCESS];
|
|
|
|
}
|
2020-09-07 09:53:58 +00:00
|
|
|
if (isnan(rate)) {
|
2016-02-20 04:22:57 +00:00
|
|
|
int len = snprintf(buffer, n, " no perm ");
|
|
|
|
RichString_appendn(str, CRT_colors[PROCESS_SHADOW], buffer, len);
|
|
|
|
} else if (rate < ONE_K) {
|
2015-01-22 01:27:31 +00:00
|
|
|
int len = snprintf(buffer, n, "%7.2f B/s ", rate);
|
|
|
|
RichString_appendn(str, processColor, buffer, len);
|
2018-12-30 12:18:35 +00:00
|
|
|
} else if (rate < ONE_M) {
|
2015-01-22 01:27:31 +00:00
|
|
|
int len = snprintf(buffer, n, "%7.2f K/s ", rate / ONE_K);
|
|
|
|
RichString_appendn(str, processColor, buffer, len);
|
2018-12-30 12:18:35 +00:00
|
|
|
} else if (rate < ONE_G) {
|
|
|
|
int len = snprintf(buffer, n, "%7.2f M/s ", rate / ONE_M);
|
2015-01-22 01:27:31 +00:00
|
|
|
RichString_appendn(str, processMegabytesColor, buffer, len);
|
2018-12-30 12:18:35 +00:00
|
|
|
} else if (rate < ONE_T) {
|
|
|
|
int len = snprintf(buffer, n, "%7.2f G/s ", rate / ONE_G);
|
|
|
|
RichString_appendn(str, largeNumberColor, buffer, len);
|
2015-01-22 01:27:31 +00:00
|
|
|
} else {
|
2018-12-30 12:18:35 +00:00
|
|
|
int len = snprintf(buffer, n, "%7.2f T/s ", rate / ONE_T);
|
2015-01-22 01:27:31 +00:00
|
|
|
RichString_appendn(str, largeNumberColor, buffer, len);
|
2008-03-14 18:50:49 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-06 10:28:11 +00:00
|
|
|
void Process_writeField(const Process* this, RichString* str, ProcessField field) {
|
2014-04-24 18:08:32 +00:00
|
|
|
char buffer[256]; buffer[255] = '\0';
|
2006-03-04 18:16:49 +00:00
|
|
|
int attr = CRT_colors[DEFAULT_COLOR];
|
2008-03-08 23:39:48 +00:00
|
|
|
int baseattr = CRT_colors[PROCESS_BASENAME];
|
2010-11-22 12:40:20 +00:00
|
|
|
int n = sizeof(buffer) - 1;
|
2015-01-22 01:27:31 +00:00
|
|
|
bool coloring = this->settings->highlightMegabytes;
|
2006-03-04 18:16:49 +00:00
|
|
|
|
|
|
|
switch (field) {
|
2015-03-16 04:43:04 +00:00
|
|
|
case PERCENT_CPU: {
|
|
|
|
if (this->percent_cpu > 999.9) {
|
2019-10-31 16:39:12 +00:00
|
|
|
xSnprintf(buffer, n, "%4u ", (unsigned int)this->percent_cpu);
|
2015-03-16 04:43:04 +00:00
|
|
|
} else if (this->percent_cpu > 99.9) {
|
2019-10-31 16:39:12 +00:00
|
|
|
xSnprintf(buffer, n, "%3u. ", (unsigned int)this->percent_cpu);
|
2015-03-16 04:43:04 +00:00
|
|
|
} else {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%4.1f ", this->percent_cpu);
|
2015-03-16 04:43:04 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PERCENT_MEM: {
|
|
|
|
if (this->percent_mem > 99.9) {
|
2019-10-31 16:39:12 +00:00
|
|
|
xSnprintf(buffer, n, "100. ");
|
2015-03-16 04:43:04 +00:00
|
|
|
} else {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%4.1f ", this->percent_mem);
|
2015-03-16 04:43:04 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2006-03-04 18:16:49 +00:00
|
|
|
case COMM: {
|
2015-01-22 01:27:31 +00:00
|
|
|
if (this->settings->highlightThreads && Process_isThread(this)) {
|
2008-03-08 23:39:48 +00:00
|
|
|
attr = CRT_colors[PROCESS_THREAD];
|
|
|
|
baseattr = CRT_colors[PROCESS_THREAD_BASENAME];
|
|
|
|
}
|
2015-01-22 01:27:31 +00:00
|
|
|
if (!this->settings->treeView || this->indent == 0) {
|
2008-03-08 23:39:48 +00:00
|
|
|
Process_writeCommand(this, attr, baseattr, str);
|
2006-03-04 18:16:49 +00:00
|
|
|
return;
|
|
|
|
} else {
|
|
|
|
char* buf = buffer;
|
|
|
|
int maxIndent = 0;
|
2011-11-03 22:12:12 +00:00
|
|
|
bool lastItem = (this->indent < 0);
|
|
|
|
int indent = (this->indent < 0 ? -this->indent : this->indent);
|
|
|
|
|
2006-03-04 18:16:49 +00:00
|
|
|
for (int i = 0; i < 32; i++)
|
2016-05-04 18:34:22 +00:00
|
|
|
if (indent & (1U << i))
|
2006-03-04 18:16:49 +00:00
|
|
|
maxIndent = i+1;
|
2006-07-11 06:13:32 +00:00
|
|
|
for (int i = 0; i < maxIndent - 1; i++) {
|
2019-02-09 23:36:34 +00:00
|
|
|
int written, ret;
|
2011-11-03 22:12:12 +00:00
|
|
|
if (indent & (1 << i))
|
2019-02-09 23:36:34 +00:00
|
|
|
ret = snprintf(buf, n, "%s ", CRT_treeStr[TREE_STR_VERT]);
|
2006-03-04 18:16:49 +00:00
|
|
|
else
|
2019-02-09 23:36:34 +00:00
|
|
|
ret = snprintf(buf, n, " ");
|
|
|
|
if (ret < 0 || ret >= n) {
|
|
|
|
written = n;
|
|
|
|
} else {
|
|
|
|
written = ret;
|
|
|
|
}
|
2011-11-03 22:12:12 +00:00
|
|
|
buf += written;
|
|
|
|
n -= written;
|
2006-07-11 06:13:32 +00:00
|
|
|
}
|
2015-01-22 01:27:31 +00:00
|
|
|
const char* draw = CRT_treeStr[lastItem ? (this->settings->direction == 1 ? TREE_STR_BEND : TREE_STR_TEND) : TREE_STR_RTEE];
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buf, n, "%s%s ", draw, this->showChildren ? CRT_treeStr[TREE_STR_SHUT] : CRT_treeStr[TREE_STR_OPEN] );
|
2006-03-04 18:16:49 +00:00
|
|
|
RichString_append(str, CRT_colors[PROCESS_TREE], buffer);
|
2008-03-08 23:39:48 +00:00
|
|
|
Process_writeCommand(this, attr, baseattr, str);
|
2006-07-11 06:13:32 +00:00
|
|
|
return;
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
}
|
2015-03-16 04:43:04 +00:00
|
|
|
case MAJFLT: Process_colorNumber(str, this->majflt, coloring); return;
|
|
|
|
case MINFLT: Process_colorNumber(str, this->minflt, coloring); return;
|
2020-10-15 20:37:02 +00:00
|
|
|
case M_RESIDENT: Process_humanNumber(str, this->m_resident * CRT_pageSizeKB, coloring); return;
|
|
|
|
case M_SIZE: Process_humanNumber(str, this->m_size * CRT_pageSizeKB, coloring); return;
|
2015-03-16 04:43:04 +00:00
|
|
|
case NICE: {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%3ld ", this->nice);
|
2015-03-16 04:43:04 +00:00
|
|
|
attr = this->nice < 0 ? CRT_colors[PROCESS_HIGH_PRIORITY]
|
|
|
|
: this->nice > 0 ? CRT_colors[PROCESS_LOW_PRIORITY]
|
|
|
|
: attr;
|
|
|
|
break;
|
|
|
|
}
|
2017-07-27 19:07:50 +00:00
|
|
|
case NLWP: xSnprintf(buffer, n, "%4ld ", this->nlwp); break;
|
|
|
|
case PGRP: xSnprintf(buffer, n, Process_pidFormat, this->pgrp); break;
|
|
|
|
case PID: xSnprintf(buffer, n, Process_pidFormat, this->pid); break;
|
|
|
|
case PPID: xSnprintf(buffer, n, Process_pidFormat, this->ppid); break;
|
2015-03-16 04:43:04 +00:00
|
|
|
case PRIORITY: {
|
2016-09-06 09:22:38 +00:00
|
|
|
if(this->priority <= -100)
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, " RT ");
|
2015-03-16 04:43:04 +00:00
|
|
|
else
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%3ld ", this->priority);
|
2015-03-16 04:43:04 +00:00
|
|
|
break;
|
|
|
|
}
|
2017-07-27 19:07:50 +00:00
|
|
|
case PROCESSOR: xSnprintf(buffer, n, "%3d ", Settings_cpuId(this->settings, this->processor)); break;
|
|
|
|
case SESSION: xSnprintf(buffer, n, Process_pidFormat, this->session); break;
|
|
|
|
case STARTTIME: xSnprintf(buffer, n, "%s", this->starttime_show); break;
|
2006-03-04 18:16:49 +00:00
|
|
|
case STATE: {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%c ", this->state);
|
2014-10-14 01:30:17 +00:00
|
|
|
switch(this->state) {
|
|
|
|
case 'R':
|
|
|
|
attr = CRT_colors[PROCESS_R_STATE];
|
|
|
|
break;
|
|
|
|
case 'D':
|
|
|
|
attr = CRT_colors[PROCESS_D_STATE];
|
|
|
|
break;
|
|
|
|
}
|
2006-03-04 18:16:49 +00:00
|
|
|
break;
|
|
|
|
}
|
2018-10-07 09:16:12 +00:00
|
|
|
case ST_UID: xSnprintf(buffer, n, "%5d ", this->st_uid); break;
|
2015-03-16 04:43:04 +00:00
|
|
|
case TIME: Process_printTime(str, this->time); return;
|
2017-07-27 19:07:50 +00:00
|
|
|
case TGID: xSnprintf(buffer, n, Process_pidFormat, this->tgid); break;
|
|
|
|
case TPGID: xSnprintf(buffer, n, Process_pidFormat, this->tpgid); break;
|
|
|
|
case TTY_NR: xSnprintf(buffer, n, "%3u:%3u ", major(this->tty_nr), minor(this->tty_nr)); break;
|
2006-03-04 18:16:49 +00:00
|
|
|
case USER: {
|
2010-02-25 01:43:18 +00:00
|
|
|
if (Process_getuid != (int) this->st_uid)
|
2006-03-04 18:16:49 +00:00
|
|
|
attr = CRT_colors[PROCESS_SHADOW];
|
2006-07-12 01:35:59 +00:00
|
|
|
if (this->user) {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%-9s ", this->user);
|
2006-07-12 01:35:59 +00:00
|
|
|
} else {
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "%-9d ", this->st_uid);
|
2006-07-12 01:35:59 +00:00
|
|
|
}
|
2011-05-26 16:31:18 +00:00
|
|
|
if (buffer[9] != '\0') {
|
|
|
|
buffer[9] = ' ';
|
|
|
|
buffer[10] = '\0';
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
2017-07-27 19:07:50 +00:00
|
|
|
xSnprintf(buffer, n, "- ");
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
RichString_append(str, attr, buffer);
|
|
|
|
}
|
|
|
|
|
2020-10-06 10:28:11 +00:00
|
|
|
void Process_display(const Object* cast, RichString* out) {
|
|
|
|
const Process* this = (const Process*) cast;
|
|
|
|
const ProcessField* fields = this->settings->fields;
|
2010-11-22 12:40:20 +00:00
|
|
|
RichString_prune(out);
|
2008-03-09 08:58:38 +00:00
|
|
|
for (int i = 0; fields[i]; i++)
|
2015-04-01 02:23:10 +00:00
|
|
|
As_Process(this)->writeField(this, out, fields[i]);
|
2015-01-22 01:27:31 +00:00
|
|
|
if (this->settings->shadowOtherUsers && (int)this->st_uid != Process_getuid)
|
2008-03-09 08:58:38 +00:00
|
|
|
RichString_setAttr(out, CRT_colors[PROCESS_SHADOW]);
|
|
|
|
if (this->tag == true)
|
|
|
|
RichString_setAttr(out, CRT_colors[PROCESS_TAG]);
|
2020-10-31 01:56:16 +00:00
|
|
|
if (this->settings->highlightChanges) {
|
|
|
|
if (Process_isTomb(this))
|
|
|
|
out->highlightAttr = CRT_colors[PROCESS_TOMB];
|
2020-11-01 00:36:53 +00:00
|
|
|
else if (Process_isNew(this))
|
|
|
|
out->highlightAttr = CRT_colors[PROCESS_NEW];
|
2020-10-31 01:56:16 +00:00
|
|
|
}
|
2011-03-22 20:37:08 +00:00
|
|
|
assert(out->chlen > 0);
|
2008-03-09 08:58:38 +00:00
|
|
|
}
|
|
|
|
|
2015-02-20 16:52:10 +00:00
|
|
|
void Process_done(Process* this) {
|
2008-03-09 08:58:38 +00:00
|
|
|
assert (this != NULL);
|
2014-05-03 20:49:05 +00:00
|
|
|
free(this->comm);
|
2008-03-09 08:58:38 +00:00
|
|
|
}
|
|
|
|
|
2020-10-05 11:19:50 +00:00
|
|
|
const ProcessClass Process_class = {
|
2015-04-01 02:23:10 +00:00
|
|
|
.super = {
|
|
|
|
.extends = Class(Object),
|
|
|
|
.display = Process_display,
|
|
|
|
.delete = Process_delete,
|
|
|
|
.compare = Process_compare
|
|
|
|
},
|
|
|
|
.writeField = Process_writeField,
|
2012-12-05 15:12:20 +00:00
|
|
|
};
|
|
|
|
|
2020-10-21 19:26:05 +00:00
|
|
|
void Process_init(Process* this, const struct Settings_* settings) {
|
2015-01-22 01:27:31 +00:00
|
|
|
this->settings = settings;
|
2008-03-09 08:58:38 +00:00
|
|
|
this->tag = false;
|
2010-06-17 19:02:03 +00:00
|
|
|
this->showChildren = true;
|
2010-11-22 12:40:20 +00:00
|
|
|
this->show = true;
|
2008-03-09 08:58:38 +00:00
|
|
|
this->updated = false;
|
2014-04-09 20:43:54 +00:00
|
|
|
this->basenameOffset = -1;
|
2008-03-09 08:58:38 +00:00
|
|
|
if (Process_getuid == -1) Process_getuid = getuid();
|
|
|
|
}
|
|
|
|
|
|
|
|
void Process_toggleTag(Process* this) {
|
|
|
|
this->tag = this->tag == true ? false : true;
|
|
|
|
}
|
|
|
|
|
2020-10-31 01:56:16 +00:00
|
|
|
bool Process_isNew(const Process* this) {
|
2020-11-01 00:36:53 +00:00
|
|
|
assert(this->processList);
|
|
|
|
if (this->processList->scanTs >= this->seenTs)
|
|
|
|
return this->processList->scanTs - this->seenTs <= this->processList->settings->highlightDelaySecs;
|
2020-10-31 01:56:16 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Process_isTomb(const Process* this) {
|
2020-11-01 00:36:53 +00:00
|
|
|
return this->tombTs > 0;
|
2020-10-31 01:56:16 +00:00
|
|
|
}
|
|
|
|
|
2008-03-09 08:58:38 +00:00
|
|
|
bool Process_setPriority(Process* this, int priority) {
|
2017-07-26 18:40:55 +00:00
|
|
|
CRT_dropPrivileges();
|
2015-12-07 19:10:09 +00:00
|
|
|
int old_prio = getpriority(PRIO_PROCESS, this->pid);
|
|
|
|
int err = setpriority(PRIO_PROCESS, this->pid, priority);
|
2017-07-26 18:40:55 +00:00
|
|
|
CRT_restorePrivileges();
|
2015-12-07 19:10:09 +00:00
|
|
|
if (err == 0 && old_prio != getpriority(PRIO_PROCESS, this->pid)) {
|
|
|
|
this->nice = priority;
|
2008-03-09 08:58:38 +00:00
|
|
|
}
|
2015-12-07 19:10:09 +00:00
|
|
|
return (err == 0);
|
2008-03-09 08:58:38 +00:00
|
|
|
}
|
|
|
|
|
2020-08-19 23:35:24 +00:00
|
|
|
bool Process_changePriorityBy(Process* this, Arg delta) {
|
|
|
|
return Process_setPriority(this, this->nice + delta.i);
|
2012-10-04 23:59:45 +00:00
|
|
|
}
|
|
|
|
|
2020-08-19 23:35:24 +00:00
|
|
|
bool Process_sendSignal(Process* this, Arg sgn) {
|
2017-07-26 18:40:55 +00:00
|
|
|
CRT_dropPrivileges();
|
2020-08-19 23:35:24 +00:00
|
|
|
bool ok = (kill(this->pid, sgn.i) == 0);
|
2017-07-26 18:40:55 +00:00
|
|
|
CRT_restorePrivileges();
|
2020-08-19 23:35:24 +00:00
|
|
|
return ok;
|
2008-03-09 08:58:38 +00:00
|
|
|
}
|
|
|
|
|
2014-04-25 22:41:23 +00:00
|
|
|
long Process_pidCompare(const void* v1, const void* v2) {
|
2020-09-23 12:15:51 +00:00
|
|
|
const Process* p1 = (const Process*)v1;
|
|
|
|
const Process* p2 = (const Process*)v2;
|
2006-07-11 06:13:32 +00:00
|
|
|
return (p1->pid - p2->pid);
|
|
|
|
}
|
|
|
|
|
2014-04-25 22:41:23 +00:00
|
|
|
long Process_compare(const void* v1, const void* v2) {
|
2020-09-23 12:15:51 +00:00
|
|
|
const Process *p1, *p2;
|
|
|
|
const Settings *settings = ((const Process*)v1)->settings;
|
2015-01-22 01:27:31 +00:00
|
|
|
if (settings->direction == 1) {
|
2020-09-23 12:15:51 +00:00
|
|
|
p1 = (const Process*)v1;
|
|
|
|
p2 = (const Process*)v2;
|
2006-07-11 06:13:32 +00:00
|
|
|
} else {
|
2020-09-23 12:15:51 +00:00
|
|
|
p2 = (const Process*)v1;
|
|
|
|
p1 = (const Process*)v2;
|
2006-07-11 06:13:32 +00:00
|
|
|
}
|
2015-01-22 01:27:31 +00:00
|
|
|
switch (settings->sortKey) {
|
2006-03-04 18:16:49 +00:00
|
|
|
case PERCENT_CPU:
|
2006-07-11 06:13:32 +00:00
|
|
|
return (p2->percent_cpu > p1->percent_cpu ? 1 : -1);
|
2006-03-04 18:16:49 +00:00
|
|
|
case PERCENT_MEM:
|
2006-07-11 06:13:32 +00:00
|
|
|
return (p2->m_resident - p1->m_resident);
|
2006-03-04 18:16:49 +00:00
|
|
|
case COMM:
|
2006-07-11 06:13:32 +00:00
|
|
|
return strcmp(p1->comm, p2->comm);
|
2015-03-16 04:43:04 +00:00
|
|
|
case MAJFLT:
|
|
|
|
return (p2->majflt - p1->majflt);
|
|
|
|
case MINFLT:
|
|
|
|
return (p2->minflt - p1->minflt);
|
|
|
|
case M_RESIDENT:
|
|
|
|
return (p2->m_resident - p1->m_resident);
|
|
|
|
case M_SIZE:
|
|
|
|
return (p2->m_size - p1->m_size);
|
|
|
|
case NICE:
|
|
|
|
return (p1->nice - p2->nice);
|
2007-05-21 19:10:53 +00:00
|
|
|
case NLWP:
|
|
|
|
return (p1->nlwp - p2->nlwp);
|
2015-03-16 04:43:04 +00:00
|
|
|
case PGRP:
|
|
|
|
return (p1->pgrp - p2->pgrp);
|
|
|
|
case PID:
|
|
|
|
return (p1->pid - p2->pid);
|
|
|
|
case PPID:
|
|
|
|
return (p1->ppid - p2->ppid);
|
|
|
|
case PRIORITY:
|
|
|
|
return (p1->priority - p2->priority);
|
2015-03-17 02:01:48 +00:00
|
|
|
case PROCESSOR:
|
|
|
|
return (p1->processor - p2->processor);
|
2015-03-16 04:43:04 +00:00
|
|
|
case SESSION:
|
|
|
|
return (p1->session - p2->session);
|
2010-03-29 18:44:14 +00:00
|
|
|
case STARTTIME: {
|
|
|
|
if (p1->starttime_ctime == p2->starttime_ctime)
|
|
|
|
return (p1->pid - p2->pid);
|
|
|
|
else
|
|
|
|
return (p1->starttime_ctime - p2->starttime_ctime);
|
|
|
|
}
|
2015-03-16 04:43:04 +00:00
|
|
|
case STATE:
|
2018-01-14 09:08:20 +00:00
|
|
|
return (Process_sortState(p1->state) - Process_sortState(p2->state));
|
2015-03-16 04:43:04 +00:00
|
|
|
case ST_UID:
|
|
|
|
return (p1->st_uid - p2->st_uid);
|
|
|
|
case TIME:
|
|
|
|
return ((p2->time) - (p1->time));
|
|
|
|
case TGID:
|
|
|
|
return (p1->tgid - p2->tgid);
|
|
|
|
case TPGID:
|
|
|
|
return (p1->tpgid - p2->tpgid);
|
|
|
|
case TTY_NR:
|
|
|
|
return (p1->tty_nr - p2->tty_nr);
|
|
|
|
case USER:
|
|
|
|
return strcmp(p1->user ? p1->user : "", p2->user ? p2->user : "");
|
2006-03-04 18:16:49 +00:00
|
|
|
default:
|
2006-07-11 06:13:32 +00:00
|
|
|
return (p1->pid - p2->pid);
|
2006-03-04 18:16:49 +00:00
|
|
|
}
|
|
|
|
}
|