zeldon
/
htop
mirror of https://github.com/xzeldon/htop.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,215 Commits 1 Branch 38 Tags 5.9 MiB
Commit Graph

2215 Commits

Author SHA1 Message Date
Benny Baumann 30dc4a2812 Add a section on PRs for the styleguide 2021-06-26 11:11:13 +02:00
Benny Baumann 07170aee4c Unsupported: Remark on expectation of username field update 2021-06-22 09:32:11 +02:00
Benny Baumann 4dce2db832 Solaris: Always update username 2021-06-22 09:32:11 +02:00
Benny Baumann 1c0bd5155f PCP: Always update username 2021-06-22 09:32:11 +02:00
Benny Baumann d2a476cddb OpenBSD: Always update username 2021-06-22 09:32:11 +02:00
Benny Baumann 6a6b09b431 Darwin: Always update username 2021-06-22 09:32:11 +02:00
Daniel Lange 8aca6fbfbd Change 3.0.6-dev -> 3.1.0-dev 2021-06-18 07:52:44 +02:00
BenBE ad1ca7ee57
Update IRC channel (Part 2) 2021-06-16 14:57:49 +02:00
BenBE 78793c5584
Update IRC channel 
The development channel on IRC moved to libera.chat
 2021-06-16 14:54:20 +02:00
Benny Baumann 92324d3461 Minor whitespace issue in configure.ac 2021-06-13 19:51:00 +02:00
Nathan Scott e3d0fc1a5a Fix a PCP diagnostics typo, add missing pmFreeResult null check. 2021-06-13 19:51:00 +02:00
Nathan Scott 6f9b161b24 Use the PACKAGE macro rather than htop directly, for overriding 
Allow other projects (PCP) to be able to ship an htop binary
which uses the custom name (pcp-htop) in several diagnostics
so that its clear which (if any!) binary failed.
 2021-06-13 19:51:00 +02:00
Nathan Scott 0bd1025e94 Resolve a couple of recent memory leaks in pcp-htop 
Makes the pcp-htop binary valgrind-clean once more.
 2021-06-13 19:51:00 +02:00
Christian Göttsche df752dd189 Do not override Linux process library size 
The library size in statm is unused and always 0 since Linux 2.6.

Fixes: 8154125d4b
 2021-06-12 20:44:33 +02:00
Christian Göttsche 45ab05c56a Limit deleted library check 
Reading and parsing /proc/<pid>/maps is quite expensive.

Do not check for deleted libraries if the main binary has been deleted;
in this case the deleted binary takes precedence.

Do not check in threads.  The check is void for kernel threads and user-
land threads can just inherit the state from the main process structure.
 2021-06-12 16:02:23 +02:00
Benny Baumann 7a8a6dd828 Do not install recommended packages by default for the CI 
This ensures, the minimal dependencies we specify are sufficient.
Also this reduces fallout from broken recommendations.
 2021-06-12 15:27:52 +02:00
Benny Baumann de1d06300d Apply stale lib highlighting for EXE too 2021-06-11 09:04:23 +02:00
Christian Göttsche 9114cf6ea3 Linux: update process uid on change 
Always check if the user of a process changed, e.g. by using setuid(2).
 2021-06-09 22:52:18 +02:00
Christian Göttsche faabbaa71e Linux: drop O_PATH usage 
O_PATH is available since Linux 2.6.39, but we are using fstat(2) on the
returned file descriptor in LinuxProcessList_statProcessDir(), which
is only supported since Linux 3.6.

Fixes #534
 2021-06-09 22:52:18 +02:00
Christian Göttsche 8154125d4b Check processes for using deleted shared libraries 
Shared libraries can be replaced by an upgrade, highlight processes
using deleted shared libraries.

Link with highlightDeletedExe setting, enabled by default.

Currently only checked on Linux.
 2021-06-09 14:40:04 +02:00
Nathan Scott 94d37989b4 Use macros to PCPProcessList value extraction, tweak configure.ac 
Resolves a couple of remaining review notes from @BenBE.
 2021-06-09 17:09:29 +10:00
Nathan Scott 144fd0a8d7 Update platform-specific header includes to use pcp paths. 
Resolves a couple of remaining review notes from @BenBE.
 2021-06-09 17:09:29 +10:00
Nathan Scott 4bcb5d116b Update the PCP platform to use common Process fields and code 
Remove code now that we have common platform-independent command
line wrangling (thanks BenBE!).  Add PCP platform support for a
handful of other recently arriving odds and ends - ELAPSED time,
CWD, and so on.
 2021-06-09 17:09:29 +10:00
Nathan Scott 4d7cee56f0 Rework TTY column for the PCP platform 2021-06-09 17:09:29 +10:00
Nathan Scott 9ce9557e69 Various code tidyups based on review commentary from BenBE 2021-06-09 17:09:29 +10:00
Nathan Scott b232119e4b Resolve some Coverity scan misfires in PCP platform code 2021-06-09 17:09:29 +10:00
Nathan Scott da454997bf Remove dynamic allocation of PCP metric atomvalues expansion 
This is no longer used and confuses Coverity scans, drop it.
 2021-06-09 17:09:29 +10:00
Nathan Scott 5abd7f2198 Drop CI distcheck on pcp build as pcp-htop.c now contains main 2021-06-09 17:09:29 +10:00
Nathan Scott d4a2587568 Add time handling interfaces for the pcp platform 
Related to https://github.com/htop-dev/htop/pull/574
 2021-06-09 17:09:29 +10:00
Nathan Scott 5dfb524237 Implement command line and environment handling for pcp htop. 2021-06-09 17:09:29 +10:00
Nathan Scott b424a5b137 Implement shared memory support on the PCP platform 
Uses the mem.util.shared metric (Shmem from meminfo).
 2021-06-09 17:09:29 +10:00
Nathan Scott d3af4e670d Update PCP platform to use the old hostname API call 
Fixes CI builds which are on an old version of PCP.
 2021-06-09 17:09:29 +10:00
Nathan Scott 956b2ae70c Update PCP platform to match latest API changes 
Updates for recent NetworkIO Meter changes, adds support
for the SysArch and HostName Meters.  The SysArch change
is based on work originally by Sohaib Mohamed.
 2021-06-09 17:09:29 +10:00
Nathan Scott c6f20fbcc6 Fixes and cleanups for ZFS Meters and metrics 2021-06-09 17:09:29 +10:00
Nathan Scott 0e7ae9a592 Ensure PCP platform ZramMeter always uses initialized data 2021-06-09 17:09:29 +10:00
Sohaib 407d32e121 Fix PCP ZramMeter in presense of missing zram metrics 2021-06-09 17:09:29 +10:00
Sohaib e1d1a5cec6 Add ZFS ARC statistics and meters to the PCP platform 2021-06-09 17:09:29 +10:00
Nathan Scott 6bb59f8881 Fix cut+paste typo in --enable-pcp error message 2021-06-09 17:09:29 +10:00
Nathan Scott 5ef8706d72 Add new CI workflow to check pcp-enabled builds 2021-06-09 17:09:29 +10:00
Nathan Scott c14a45ba35 Add a platform for Performance Co-Pilot (PCP) metrics 
This introduces an initial platform for extracting metrics
using the PCP performance metrics API - PMAPI(3).  It can
be used via the --enable-pcp=yes configure option.

So far I've added support for live localhost metrics only,
and only using pre-defined metrics already found in htop.
If available, all sampling is performed by pmcd(1) - else,
we fallback to htop doing the metric sampling itself (all
below the PMAPI).  When pmcd is used, it may be configured
to run children with elevated privileges, so htop does not
need to be setuid (authentication with pmcd is available).

Additionally, the PMAPI allows us to support archives (for
historical analysis and for automated regression tests in
htop).  We'll need platform-specific command line argument
additions, which isn't yet feasible in htop (not difficult
to add though).

The goal of this first version is minimal impact in terms
of modifying the htop codebase, to introduce key ideas in
PCP (metric namespace, metadata, APIs and so on) and give
us something to discuss, experiment with and build on.
 2021-06-09 17:09:29 +10:00
Varik Valefor d075d49a0c htop.1.in: Some grammatical errors are fixed. 2021-05-30 11:15:45 +02:00
Varik Valefor f171e360e0 htop.1.in: A grammatical error is fixed. 2021-05-30 11:15:45 +02:00
Benny Baumann c752c542fe Unsupported: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann 8420df62eb Solaris: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann 5e92956abc OpenBSD: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann 90f42695d2 FreeBSD: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann c2e2556403 DragonFlyBSD: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann 06073699ba Darwin: Implement CWD column 2021-05-25 21:55:04 +02:00
Benny Baumann b6ff5c8a2e Move CWD field handling to platform-neutral code 2021-05-25 21:55:04 +02:00
Christian Göttsche c408add108 Linux: add reset to heuristic 
On hard to parse command lines tokenStart might be computed to be bigger
than tokenEnd.
Reset both values in such cases.
 2021-05-25 18:20:09 +02:00