Benny Baumann
32414dace7
Remove unused define on Solaris
2021-07-04 19:32:47 +02:00
Benny Baumann
874fb773a7
Fix typo in Generic_gettime_realtime on old Mac
...
Fixes #673
2021-07-01 23:27:54 +02:00
Sohaib Mohamed
ecb6a8da78
PCP: Fix minor cut+paste typo
2021-06-30 07:45:47 +02:00
BenBE
3bed682b1e
Always update proc->st_uid
+ proc->user
...
Avoids issue #661 .
2021-06-26 12:18:37 +02:00
fraggerfox
686309e34c
Redo the memory values based on the other BSD implementations.
2021-06-26 12:18:37 +02:00
fraggerfox
5fe9bcb21c
Adds support for counting user and kernel threads.
2021-06-26 12:18:37 +02:00
fraggerfox
336acb0309
Adds support for PROC_EXE and CWD.
2021-06-26 12:18:37 +02:00
fraggerfox
612462e33d
Adds the ELAPSED column for NetBSD.
...
Additional details regarding ELAPSED column can be found in #627 .
2021-06-26 12:18:37 +02:00
fraggerfox
58a895e54c
Fixes minor whitespace issues and re-arrange headers to conform to style guide.
2021-06-26 12:18:37 +02:00
fraggerfox
9de463e756
Implements the NetBSD specific changes for makeCommandStr refactor.
...
Refer to #388 PR for more details.
2021-06-26 12:18:37 +02:00
fraggerfox
fa65c30976
Sets a non-NULL process state in case of kvm_getlwps(3) returns NULL. Thanks @cgzone.
2021-06-26 12:18:37 +02:00
fraggerfox
3770769ed1
Replaces WRAP_SUBTRACT with saturatingSub inline function to reduce code duplication.
2021-06-26 12:18:37 +02:00
fraggerfox
2f5b3ef733
Refactor saturatingSub() to be part of Macros.h
2021-06-26 12:18:37 +02:00
fraggerfox
e42ae55d69
Renames variable from opl to npl for consistency.
2021-06-26 12:18:37 +02:00
fraggerfox
497f468ed0
Fix include paths and minor whitespace issues
2021-06-26 12:18:37 +02:00
fraggerfox
9b6cecfede
Replace strlcpy() by safer String_safeStrncpy()
2021-06-26 12:18:37 +02:00
fraggerfox
3414d3b2d4
Replace maximum_PID value with INT32_MAX
...
Thank you @niacat.
2021-06-26 12:18:37 +02:00
fraggerfox
9e3b7c439c
Update README for NetBSD
2021-06-26 12:18:37 +02:00
fraggerfox
ddcfb179b4
Remove unwanted code, updates the comments
2021-06-26 12:18:37 +02:00
Benny Baumann
b900e70e80
Update copyright notices
2021-06-26 12:18:37 +02:00
fraggerfox
440bb87058
Minor code clean up and corrections.
2021-06-26 12:18:37 +02:00
fraggerfox
db98623684
Sync changes from master and fix minor warnings
2021-06-26 12:18:37 +02:00
fraggerfox
4b49de44a8
Add NetBSD platform support without procfs dependency
...
- TODO, clean up the code base and update comments in code.
2021-06-26 12:18:37 +02:00
Benny Baumann
30dc4a2812
Add a section on PRs for the styleguide
2021-06-26 11:11:13 +02:00
Benny Baumann
07170aee4c
Unsupported: Remark on expectation of username field update
2021-06-22 09:32:11 +02:00
Benny Baumann
4dce2db832
Solaris: Always update username
2021-06-22 09:32:11 +02:00
Benny Baumann
1c0bd5155f
PCP: Always update username
2021-06-22 09:32:11 +02:00
Benny Baumann
d2a476cddb
OpenBSD: Always update username
2021-06-22 09:32:11 +02:00
Benny Baumann
6a6b09b431
Darwin: Always update username
2021-06-22 09:32:11 +02:00
Daniel Lange
8aca6fbfbd
Change 3.0.6-dev -> 3.1.0-dev
2021-06-18 07:52:44 +02:00
BenBE
ad1ca7ee57
Update IRC channel (Part 2)
2021-06-16 14:57:49 +02:00
BenBE
78793c5584
Update IRC channel
...
The development channel on IRC moved to libera.chat
2021-06-16 14:54:20 +02:00
Benny Baumann
92324d3461
Minor whitespace issue in configure.ac
2021-06-13 19:51:00 +02:00
Nathan Scott
e3d0fc1a5a
Fix a PCP diagnostics typo, add missing pmFreeResult null check.
2021-06-13 19:51:00 +02:00
Nathan Scott
6f9b161b24
Use the PACKAGE macro rather than htop directly, for overriding
...
Allow other projects (PCP) to be able to ship an htop binary
which uses the custom name (pcp-htop) in several diagnostics
so that its clear which (if any!) binary failed.
2021-06-13 19:51:00 +02:00
Nathan Scott
0bd1025e94
Resolve a couple of recent memory leaks in pcp-htop
...
Makes the pcp-htop binary valgrind-clean once more.
2021-06-13 19:51:00 +02:00
Christian Göttsche
df752dd189
Do not override Linux process library size
...
The library size in statm is unused and always 0 since Linux 2.6.
Fixes: 8154125d4b
2021-06-12 20:44:33 +02:00
Christian Göttsche
45ab05c56a
Limit deleted library check
...
Reading and parsing /proc/<pid>/maps is quite expensive.
Do not check for deleted libraries if the main binary has been deleted;
in this case the deleted binary takes precedence.
Do not check in threads. The check is void for kernel threads and user-
land threads can just inherit the state from the main process structure.
2021-06-12 16:02:23 +02:00
Benny Baumann
7a8a6dd828
Do not install recommended packages by default for the CI
...
This ensures, the minimal dependencies we specify are sufficient.
Also this reduces fallout from broken recommendations.
2021-06-12 15:27:52 +02:00
Benny Baumann
de1d06300d
Apply stale lib highlighting for EXE too
2021-06-11 09:04:23 +02:00
Christian Göttsche
9114cf6ea3
Linux: update process uid on change
...
Always check if the user of a process changed, e.g. by using setuid(2).
2021-06-09 22:52:18 +02:00
Christian Göttsche
faabbaa71e
Linux: drop O_PATH usage
...
O_PATH is available since Linux 2.6.39, but we are using fstat(2) on the
returned file descriptor in LinuxProcessList_statProcessDir(), which
is only supported since Linux 3.6.
Fixes #534
2021-06-09 22:52:18 +02:00
Christian Göttsche
8154125d4b
Check processes for using deleted shared libraries
...
Shared libraries can be replaced by an upgrade, highlight processes
using deleted shared libraries.
Link with highlightDeletedExe setting, enabled by default.
Currently only checked on Linux.
2021-06-09 14:40:04 +02:00
Nathan Scott
94d37989b4
Use macros to PCPProcessList value extraction, tweak configure.ac
...
Resolves a couple of remaining review notes from @BenBE.
2021-06-09 17:09:29 +10:00
Nathan Scott
144fd0a8d7
Update platform-specific header includes to use pcp paths.
...
Resolves a couple of remaining review notes from @BenBE.
2021-06-09 17:09:29 +10:00
Nathan Scott
4bcb5d116b
Update the PCP platform to use common Process fields and code
...
Remove code now that we have common platform-independent command
line wrangling (thanks BenBE!). Add PCP platform support for a
handful of other recently arriving odds and ends - ELAPSED time,
CWD, and so on.
2021-06-09 17:09:29 +10:00
Nathan Scott
4d7cee56f0
Rework TTY column for the PCP platform
2021-06-09 17:09:29 +10:00
Nathan Scott
9ce9557e69
Various code tidyups based on review commentary from BenBE
2021-06-09 17:09:29 +10:00
Nathan Scott
b232119e4b
Resolve some Coverity scan misfires in PCP platform code
2021-06-09 17:09:29 +10:00
Nathan Scott
da454997bf
Remove dynamic allocation of PCP metric atomvalues expansion
...
This is no longer used and confuses Coverity scans, drop it.
2021-06-09 17:09:29 +10:00