Benny Baumann
5fe2a88c08
Use common handling for scrolling
2020-12-03 22:41:31 +01:00
Benny Baumann
a7955c4966
Reduce code duplication
2020-12-03 22:41:31 +01:00
Christian Göttsche
19b5141685
Hide process selection on ESC
...
Do not highlight the current process line after pressing ESC in the main
screen.
Restore after pressing any key.
2020-11-28 19:49:38 +01:00
Daniel Lange
0951090fa4
Merge branch 'hili-new-old' of adsr/htop into highlight-new-old-processes
2020-11-16 12:55:07 +01:00
Benny Baumann
45869513bf
Embracing branches
2020-11-02 22:15:01 +01:00
Benny Baumann
61e14d4bb2
Spacing around operators
2020-11-02 22:15:01 +01:00
Benny Baumann
b23f8235e2
Whitespace and indentation issues
2020-11-02 22:15:01 +01:00
Benny Baumann
adf797c295
Spacing after keywords (for)
2020-11-02 22:15:01 +01:00
Christian Göttsche
0806a7958b
Assert Vector_get returns an object
...
It is generally assumed Vector_get returns a non-NULL object.
Use a generic assert in Vector_get instead of in callers.
2020-11-02 19:24:28 +01:00
Adam Saponara
dde71c6637
Highlight new and old processes ( #74 )
2020-10-30 21:56:16 -04:00
Christian Göttsche
ac2b07eddd
Avoid some unnecessary casts and mark some not changing variables const
2020-10-27 18:00:43 +01:00
Benny Baumann
0f5262917f
Make all required includes explicit
...
Information as seen by IWYU 0.12 + clang 9 on Linux
2020-10-18 20:09:05 +02:00
Benny Baumann
872e542f4e
Rename StringUtils.[ch] to XUtils.[ch]
2020-10-16 20:30:21 +02:00
Christian Göttsche
ba282cfe19
Mark Object instances const
2020-10-07 13:01:53 +02:00
Christian Göttsche
08d85e6143
Mark Object classes and Object class fields const
2020-10-07 13:01:53 +02:00
Daniel Lange
079c2abf8e
Update License consistently to GPLv2 as per COPYING file
2020-10-05 10:13:12 +02:00
Christian Göttsche
8a849bc85a
Call character checking function with unsigned char
...
See https://wiki.sei.cmu.edu/confluence/display/c/STR37-C.+Arguments+to+character-handling+functions+must+be+representable+as+an+unsigned+char
2020-09-17 22:03:24 +02:00
Hugo Musso Gualandi
9207401f97
Clean up some code duplication in the header files
...
PR htop-dev/htop#70 got rid of the infrastructure for generating header
files, but it left behind some code duplication.
Some of cases are things that belong in the header file and don't need
to be repeated in the C file. Other cases are things that belong in the
C file and don't need to be in the header file.
In this commit I tried to fix all of these that I could find. When given
a choice I preferred keeping things out of the header file, unless they
were being used by someone else.
2020-09-12 19:20:44 -03:00
Nathan Scott
c5808c56db
Consolidate repeated macro definitions into one header
...
The MIN, MAX, CLAMP, MINIMUM, and MAXIMUM macros appear
throughout the codebase with many re-definitions. Make
a single copy of each in a common header file, and use
the BSD variants of MINIMUM/MAXIMUM due to conflicts in
the system <sys/param.h> headers.
2020-09-09 16:56:04 +10:00
Nathan Scott
8ec5d4a3a0
Further, minor cleanups to headers post-MakeHeaders
...
Remove leftover empty ifdef/endif pairs, whitespace.
The generated htop.h file was also unused - removed.
2020-09-08 17:33:50 +10:00
Zev Weiss
a1a027b9bd
Axe automated header generation.
...
Reasoning:
- implementation was unsound -- broke down when I added a fairly
basic macro definition expanding to a struct initializer in a *.c
file.
- made it way too easy (e.g. via otherwise totally innocuous git
commands) to end up with timestamps such that it always ran
MakeHeader.py but never used its output, leading to overbuild noise
when running what should be a null 'make'.
- but mostly: it's just an awkward way of dealing with C code.
2020-09-03 11:58:58 -05:00
Nathan Scott
728b04bbb5
Merge branch 'ci-hwloc-job' of https://github.com/bertwesarg/htop into bertwesarg-ci-hwloc-job
2020-08-26 10:39:43 +10:00
Daniel Flanagan
dd33444f7e
Clean up existing whitespace
2019-10-31 11:39:12 -05:00
Hisham Muhammad
03f17688ad
Handle unexpected values for character passed to isalnum
...
It seems that certain negative integer values can crash isalnum().
Let's protect against those.
Fixes #711 .
2018-02-05 10:59:20 +01:00
Explorer09
3d9868833e
Fix scrolling behavior change caused by 759caf0f
...
Commit "Make PgDown behavior more usual." 759caf0f8f
silently changes the PageDown scrolling behavior that, instead of
scrolling one window down until the end of the window touches the end
of the list, the window simply repositions itself in a way that the
selected item always become the last item in the new window.
The commit reverts the behavior, and also fixes sanity conditionals
so that the scrollV variable will _never_ become negative or out-of-
bound.
Fixes issue #532 . Also keep the problem #480 addressed.
Signed-off-by: Kang-Che Sung <explorer09 @ gmail.com>
2016-08-07 07:49:37 +08:00
Hisham
b139671cbd
Moving left and right needs a full redraw.
2016-06-19 18:05:18 -03:00
Hisham
0128d222b9
Added Ctrl+A and Ctrl+E to go to beginning and end of line.
...
(Also, '^' and '$')
Closes #508 .
2016-06-15 12:45:23 -03:00
Hisham
759caf0f8f
Make PgDown behavior more usual.
...
Closes #480 .
2016-05-04 22:41:52 -03:00
Hisham
48254f92e4
Fix behavior of Panel on empty lists.
...
Closes #370 .
2016-02-18 17:45:04 -02:00
Hisham
b54d2dde40
Check for failure in allocations.
2016-02-02 15:53:02 +01:00
Hisham Muhammad
f187be9296
Fix moving of meters
2015-11-02 10:33:22 -05:00
Christian Hesse
e8970b6f32
fix calloc() calls
...
* size_t nmemb (number of elements) first, then size_t size
* do not assume char is size 1 but use sizeof()
* allocate for char, not pointer to char (found by Michael McConville,
fixes #261 )
2015-09-07 07:52:39 +02:00
Hisham Muhammad
3c4326b450
Don't select last item when clicking past the end of the panel.
2015-08-27 19:14:25 -03:00
Hisham Muhammad
b003636958
Support for NCurses 6.0 and mouse wheel
2015-08-19 18:55:24 -03:00
David Hunt
5e602f18d5
Rename String to StringUtils.
...
Fixes building on case-insensitive filesystems where String.h gets confused with <string.h>.
From d734dacea0a10d0465dad4e95b3421511e7da112 Mon Sep 17 00:00:00 2001
From: David Hunt <dhunt@iolanthe.attlocal.net>
Date: Sat, 11 Jul 2015 20:56:31 -0500
Subject: [PATCH 1/8] Rename String to StringUtils
2015-08-19 13:45:20 -03:00
Hisham Muhammad
b1f934c5d5
Visual tweaks: change color when following, add Broken Gray theme.
2015-04-09 15:17:20 -03:00
Hisham Muhammad
d880def0e9
Merge branch 'master' into wip
...
Conflicts:
Process.c
Process.h
htop.c
linux/LinuxProcess.c
linux/LinuxProcess.h
test_spec.lua
2015-04-02 01:57:37 -03:00
Hisham Muhammad
5320bab202
Cleanup unused field.
2015-03-31 22:31:06 -03:00
Hisham Muhammad
a93db5234c
handle clicks on panel header line
2015-03-24 23:12:43 -03:00
Hisham Muhammad
54f8d8154b
Do not trust isalpha(c) for values > 255.
...
Fixes #174 .
Conflicts:
Panel.c
2015-03-23 18:14:35 -03:00
Hisham Muhammad
ade7993fcb
incremental search and filter reintegrated!
2015-03-23 17:04:53 -03:00
Hisham Muhammad
d0c72c3fb2
Move FunctionBar inside Panel
2015-03-23 15:26:56 -03:00
Hisham Muhammad
442a0d33e4
Do not trust isalpha(c) for values > 255.
...
Fixes #174 .
2015-03-22 22:56:28 -03:00
Hisham Muhammad
09c7152990
Refactor state control variables.
2015-03-22 02:50:40 -03:00
Hisham Muhammad
d7c843c23b
Complete cursor-based movement of headers.
2015-02-03 22:32:07 +01:00
Hisham Muhammad
c2108e5a48
Another mega-patch for the refactoring process.
...
Kinda runs, but functionality from the original main loop
is still missing. Patience.
2015-01-23 03:08:21 -02:00
Hisham Muhammad
3383d8e556
Sorry about the mega-patch.
...
This is a work-in-progress, code is currently broken.
(Some actions, and notably, the header, are missing.)
2015-01-21 23:27:31 -02:00
Hisham Muhammad
4939468df0
Fix crash when scrolling in a filter view with no processes. Closes #76 .
2014-05-03 18:08:46 -03:00
Hisham Muhammad
6d90e58c01
alignment improvements
2014-02-27 16:35:22 -03:00
Hisham Muhammad
43a7231615
Remove explicit calls to curses.h in other files
2013-02-26 16:50:21 +00:00