V
bfcb8ca019
InfoScreen: fix uncontrolled format string
...
mvwprintw takes a format string as its fourth argument, and title is
user-controlled. This results in e.g. crashing when trying to trace a
process with a format specifier in its command line.
2021-01-08 11:06:38 +01:00
Christian Göttsche
ce9e7fd14f
Panel_new: reorder arguments
...
Reorder owner and type so they match the order of Panel_init
2021-01-04 23:12:43 +01:00
Christian Göttsche
a3cced9fb6
Add option to hide the Function Bar
...
Support three settings:
- Always show Function Bar
- Always hide the Function Bar, except in Infoscreens (Env/Locks...)
and when editing the search and filter mode
- Hide the Function Bar on ESC until the next user input
Closes : #439
2021-01-04 23:12:43 +01:00
Christian Göttsche
e3862aa67e
Rework drawing of FunctionBar
...
Draw the FunctionBar within Panel_draw instead of manually throughout
the code.
Add an optional PanelClass function drawFunctionBar, to allow specific
panels to override the default FunctionBar_draw call.
Rework the code on color change, to really change all colors (selection
markers and panel headers).
Closes : #402
2020-12-20 17:01:50 +01:00
Christian Göttsche
7e7a53c415
Mark event arrays const
2020-12-20 16:58:37 +01:00
Benny Baumann
c49ca61dd9
Common order for ESC/q/F10
2020-12-03 22:41:31 +01:00
Christian Göttsche
19b5141685
Hide process selection on ESC
...
Do not highlight the current process line after pressing ESC in the main
screen.
Restore after pressing any key.
2020-11-28 19:49:38 +01:00
Benny Baumann
45869513bf
Embracing branches
2020-11-02 22:15:01 +01:00
Benny Baumann
61e14d4bb2
Spacing around operators
2020-11-02 22:15:01 +01:00
Christian Göttsche
f8208f2173
Drop tabs in source indentions
2020-10-20 21:43:36 +02:00
Benny Baumann
0f5262917f
Make all required includes explicit
...
Information as seen by IWYU 0.12 + clang 9 on Linux
2020-10-18 20:09:05 +02:00
Benny Baumann
872e542f4e
Rename StringUtils.[ch] to XUtils.[ch]
2020-10-16 20:30:21 +02:00
Christian Göttsche
41eea8a355
Mark process argument of Process_isThread const
2020-10-09 10:18:40 +02:00
ryenus
ff455b0004
limit max screen title length to window width
...
Applies screen title truncating to all InfoScreen classes.
2020-10-05 12:18:05 +02:00
Christian Göttsche
8efc88593a
InfoScreen: update content on resize
2020-10-02 14:40:15 +02:00
Christian Göttsche
843949131a
Drop redundant casts to the same type
2020-09-29 10:44:42 +02:00
Zev Weiss
a1a027b9bd
Axe automated header generation.
...
Reasoning:
- implementation was unsound -- broke down when I added a fairly
basic macro definition expanding to a struct initializer in a *.c
file.
- made it way too easy (e.g. via otherwise totally innocuous git
commands) to end up with timestamps such that it always ran
MakeHeader.py but never used its output, leading to overbuild noise
when running what should be a null 'make'.
- but mostly: it's just an awkward way of dealing with C code.
2020-09-03 11:58:58 -05:00
Christian Göttsche
df41979afc
Ignore wmove return value
...
Found by Coverity
2020-08-28 16:46:50 +02:00
Christian Göttsche
11f558f934
Avoid discarding const qualifiers
2020-08-25 12:00:03 +02:00
Nathan Scott
9aa816873f
Merge branch 'hishamhm-pull-1010'
2020-08-20 15:16:47 +10:00
Nathan Scott
a82fd262d7
Merge branch 'hishamhm-pull-960'
2020-08-20 14:19:53 +10:00
Nathan Scott
36ef4d4fb6
Resolve compilation warning relating to dangling else in InfoScreen_run
2020-08-19 18:10:16 +10:00
Jorge Pereira
8de04986cf
Fix misleading indentation
2020-06-11 13:42:41 -03:00
Daniel Flanagan
dd33444f7e
Clean up existing whitespace
2019-10-31 11:39:12 -05:00
wurongxin
a360a80d16
fix a bug about use of unitialised variable. refer to https://github.com/hishamhm/htop/issues/882
2019-01-29 12:45:30 +08:00
Hisham Muhammad
8c653212c0
Replace size_t with int/void* union
...
I was occasionally passing negative values to size_t.
Plus, this better reflects the intent of the variant argument.
Reported by Coverity:
https://scan8.coverity.com/reports.htm#v13253/p10402/fileInstanceId=22093891&defectInstanceId=7543346&mergedDefectId=174179&fileStart=251&fileEnd=500
2018-02-18 10:38:49 -03:00
Richard
d5faf64374
Mark some things as const
...
Several string pointer arrays pointed to const strings
but were not const themselves.
A few various structures and arrays were also marked const.
2017-07-22 22:34:30 -05:00
Hisham
7f9c82f28d
Refresh whole panel on Ctrl+L in infoscreen.
...
Closes #520 .
2016-06-23 13:25:58 -03:00
Hisham
645057d81a
Use set_escdelay() to avoid problems with ESCDELAY as a macro.
2016-05-19 16:09:47 -03:00
Hisham
c23d4f12d1
Fix behavior of ESC key, getting rid of the annoying delay.
...
Thank you @Explorer09 for the push!
Closes #417 .
2016-02-19 13:38:02 -02:00
Hisham Muhammad
466d4da0c6
refactor *Screen classes, add InfoScreen superclass
2016-01-12 06:00:58 -02:00