zeldon
/
mineping
mirror of https://github.com/minescope/mineping.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1 from romanalexander/fixes/bedrock-ping 

Fix ping never firing an error when timeout occurs.
This commit is contained in:
Timofey Gelazoniya 2023-10-09 02:21:00 +03:00 committed by GitHub
parent 72041aa3f9 af78a184db
commit 7cd3444a4f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/bedrock.js
View File

@ -132,7 +132,7 @@ function ping(host, port = 19132, cb, timeout = 5000) {
// Close the socket and clear the timeout task
// This is a general cleanup for success conditions
closeSocket();
cb(null, clientData);
cb(clientData, null);
break;
}
@ -160,9 +160,9 @@ export function pingBedrock(host, options = {}) {
const { port = 19132, timeout = 5000 } = options;
return new Promise((resilve, reject) => {
ping(host, port, (err, res) => {
err ? reject(err) : resilve(res);
return new Promise((resolve, reject) => {
ping(host, port, (res, err) => {
err ? reject(err) : resolve(res);
}, timeout);
});
}