mirror of https://github.com/xzeldon/htop.git
Use 0 as no-match value for sortkey
Field numbers start at 1, and using -1 as no-match special value triggers static analyzers using a potential negative array access.
This commit is contained in:
parent
f38af725c2
commit
b3b890f546
4
htop.c
4
htop.c
|
@ -139,7 +139,7 @@ static CommandLineSettings parseArguments(int argc, char** argv) {
|
|||
}
|
||||
exit(0);
|
||||
}
|
||||
flags.sortKey = -1;
|
||||
flags.sortKey = 0;
|
||||
for (int j = 1; j < Platform_numberOfFields; j++) {
|
||||
if (Process_fields[j].name == NULL)
|
||||
continue;
|
||||
|
@ -148,7 +148,7 @@ static CommandLineSettings parseArguments(int argc, char** argv) {
|
|||
break;
|
||||
}
|
||||
}
|
||||
if (flags.sortKey == -1) {
|
||||
if (flags.sortKey == 0) {
|
||||
fprintf(stderr, "Error: invalid column \"%s\".\n", optarg);
|
||||
exit(1);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue