zeldon
/
htop
mirror of https://github.com/xzeldon/htop.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,686 Commits 1 Branch 38 Tags 5.9 MiB
Commit Graph

2686 Commits

Author SHA1 Message Date
Timofey Gelazoniya eebd5e8517
add rpi model 3b+ to tested list 2022-06-10 20:19:39 +03:00
Timofey Gelazoniya 7044d546ea
rename ui names for cpu freq/temp 2022-06-10 20:14:06 +03:00
Timofey Gelazoniya 765e3de1e7
fix temp meter duplication 2022-06-10 20:12:16 +03:00
Timofey Gelazoniya 637550ed51
disclaimer 2022-06-07 20:14:57 +03:00
Timofey Gelazoniya fc016ae780
new screenshot 2022-06-07 22:36:05 +03:00
Timofey Gelazoniya 36260b5814
CPU Temperature and Frequency meter for Linux platform 2022-06-07 22:16:47 +03:00
Tobias Stoeckmann 611ea4606f Prevent null pointer dereference on early error 
If a fatal error occurs before CRT_init has been called, CRT_done
dereferences NULL in CRT_colors.

Simply check if CRT_crashSettings is not NULL, which is eventually
set when CRT_init has been called.

If it is not set, then do not try to disable ncurses.

Proof of Concept (on Linux):

$ ./configure --with-proc=/var/empty
$ make
$ ./htop
 2022-06-03 20:11:24 +02:00
Nathan Scott 4e6ec4a087 Update changelog in preparation for htop-3.2.1 release 2022-06-03 10:54:39 +10:00
Daniel Lange abaec509e6 Merge branch 'cmdline-render-cache-rework' of BenBE/htop 2022-06-01 08:00:55 +02:00
Tobias Stoeckmann f156dfecd5 Fix typo 2022-05-31 22:21:52 +02:00
Benny Baumann 2999fff88e Refactor code for rendering command line cache 
Fixes #1008
 2022-05-31 13:55:43 +02:00
Daniel Lange 2613db4b0d Merge branch 'fix-strip-exe-from-cmdline' of benbe/htop 2022-05-31 09:29:11 +02:00
Benny Baumann 9eed30949b Restore functionality of stripExeFromCmdline setting 
This was accidentally lost in fbec3e4005
 2022-05-30 22:38:59 +02:00
Daniel Lange ce50095323 Merge branch 'fix-allBranchesCollapsed' of tanriol/htop 2022-05-30 10:37:19 +02:00
Denis Lisov 17e28d5264 actionExpandOrCollapseAllBranches: NOP in flat mode 
This shortcut does not have any visible effect in flat mode, so disable
it completely to avoid possible confusion.
 2022-05-30 10:52:12 +03:00
Denis Lisov da97d2625a ProcessList_collapseAllBranches: actually build tree 
As the loop checks `tree_depth`, a tree build is needed to ensure
they're filled in correctly. Note that this breaks the display list sort
order in case it's non-tree-based (either startup in flat mode, or `*`
hotkey in flat mode), so the display list will need to be sorted again.
 2022-05-30 10:52:12 +03:00
Benny Baumann 7694dbc821 Implement PCP support for minimum ZFS ARC size 2022-05-30 07:50:57 +02:00
Benny Baumann c0a9e92eea Implement FreeBSD support for minimum ZFS ARC size 2022-05-30 07:50:57 +02:00
ilyam8 491c6f1044 consider only shrinkable ZFS ARC as cache on Linux 2022-05-30 07:50:57 +02:00
Explorer09 98cbdc6dca Correct PROCESS_MAX_UID_DIGITS constant 
The PROCESS_MAX_UID_DIGITS=19 introduced in
696f79fe50 doesn't make sense.
The `uid_t` type does not require to be signed in POSIX. If we are to
support 64 bits as the maximum size of `uid_t`, then
PROCESS_MAX_UID_DIGITS should be 20. (= floor(log10(UINT64_MAX)) + 1).

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
 2022-05-30 07:50:32 +02:00
Explorer09 9ed9d73ab5 Correct titleBuffer size and share it in alignedProcessFieldTitle() 
* The size of titleBuffer should be 257 bytes, not 256.

* Remove redundant `static char titleBuffer[]` delarations within
  `alignedProcessFieldTitle()` and let the subroutine use one shared
  buffer for printing field title. This reduces code size.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
 2022-05-30 07:50:32 +02:00
Daniel Lange 999801464a Add some headers in the Setup -> Display options panel 2022-05-27 19:47:06 +02:00
Christian Göttsche 0e29174211 Do not scan new processes for deleted libs 2022-05-26 15:38:24 +02:00
WHR efe09a5e39 Fix process time scaling error on Solaris 2022-05-26 15:31:30 +02:00
Kumar 038f2ae777 Linux: Increase field width of CPUD% and SWAPD% to 5 
Title width of "CPUD%" and "SWAPD%" is 5 and there value cannot go
beyond "100.0%", so increase their field width to 5.

"IOD%" is similar to "MEM%" column, title width is 4 and maximum value
cannot go beyond "100.0%". So in case of "IOD%" column, there is no need
to increase title width to "5". "Process_printPercentage()" function
will handle the maximum value case, it will display value beyond "99.9%"
as "100" instead of "100.0".
 2022-05-26 15:03:39 +02:00
Kumar 0af08bcfc9 Process: Display single digit precision for CPU% greater than 99.9% 
Since commit edf319e[1], we're dynamically adjusting column width of
"CPU%", showing single digit precision also for values greater than
"99.9%" makes "CPU%" column consistent with all other values.

[1]: edf319e53d

Change "Process_printPercentage()" function's logic to always display
value (i.e. "val") with single precision. Except when value is greater
than "99.9%" for columns like "MEM%", whose width is fixed to "4" and
value cannot go beyond "100%".

Credits: @Explorer09, thanks for the patch[2] to fix title alignment
         issue.

[2]: https://github.com/htop-dev/htop/pull/959#issuecomment-1092480951

Closes: #957
 2022-05-26 15:03:39 +02:00
Benny Baumann e053446cbd Fix typo, thx Explorer09 2022-05-21 10:24:42 +02:00
WHR 3d8fa0b926 Mark item separator in default color on help screen 
Closes: #1014
 2022-05-20 21:54:19 +02:00
Christian Hesse d73cc70566 fix typo (dist -> disk) 
This was changed in commit 37e01cbe33,
probably unintentional.
 2022-05-20 12:58:12 +02:00
Benny Baumann 37e01cbe33 Colorize process state characters in help screen 
Thanks to @Low-power for the idea
Closes #1010
 2022-05-20 12:30:37 +02:00
WHR d22667725a Call mousemask(3X) to truly enable or disable mouse control 2022-05-19 20:23:22 +02:00
Benny Baumann ef4cbae5ea Minor code style update 2022-05-19 18:13:46 +02:00
Explorer09 44091705db Use of NULL in execlp() must have a pointer cast. 
Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
 2022-05-19 18:42:44 +08:00
Daniel Lange 87793b8555 Merge branch 'lxc-cpu-count-fix' of fasterit/htop 2022-05-17 19:10:40 +02:00
Daniel Lange fe7f238e2c Increasing niceness is also disabled by --readonly mode 2022-05-13 09:43:56 +02:00
Benny Baumann c24681a078 Fix heap buffer overflow in Vector_compact 
Fixes: #1006
 2022-05-10 12:12:46 +02:00
Daniel Lange 2da8f71209 Merge branch 'fix_running_containerized_for_lxc' of ilyam8/htop 2022-05-09 12:21:15 +02:00
ilyam8 51228b6239 fix container detection for LXC 2022-05-08 21:46:53 +03:00
Daniel Lange 33973f7e40 Limit active CPU count under LXC as well 
Fixes the initial htoprc not being configured to amount for the host CPU count
 2022-05-07 16:05:11 +02:00
Daniel Lange 79db69c48d Fix Solaris / OmniOS build 2022-05-06 15:22:08 +02:00
Benny Baumann 9fc72c1e9c Ensure buffer for environment is large enough on Solaris 2022-05-06 14:35:50 +02:00
Benny Baumann db93268968 Ensure buffer for environment is large enough on OpenBSD 2022-05-06 14:35:50 +02:00
Benny Baumann 4f1269cc9f Ensure buffer for environment is large enough on NetBSD 2022-05-06 14:35:50 +02:00
Charlie Vieth 0388b30077 Hashtable: fix handling of NULL pointer in Hashtable_dump 
This fixes an issus in Hashtable_dump where `"(nil"` is passed as an
argument to `%p` in fprintf. This prints the static address of `"(nil)"`
not "(nil)". This commit changes the code to just pass the NULL pointer
to fprintf, which will consistently print "0x0".
 2022-05-06 06:34:17 +02:00
Denis Lisov 4b8b61fe18 ProcessList.h: remove `ProcessList_remove` 
As the "highlight dying processes" option has to keep processes in the
list when they disappear, no code except the cleanup loop in
`ProcessList_scan` should remove processes from the list directly.
Remove the export to prevent random process removals from being
reintroduced accidentally.
 2022-05-05 10:00:34 +02:00
Denis Lisov fae7ff6f03 LinuxProcessList_recurseProcTree: keep on read error 
If a process goes away while reading its fields, but we already have
that process in the list, we should keep it in case the "highlight dying
processes" mode is active. Not only is that expected in this mode, but
this should also ensure parents are in the list when their children are
(wanted for tree mode consistency).
 2022-05-05 10:00:34 +02:00
Denis Lisov e07fce7014 LinuxProcessList_recurseProcTree: open dirfd first 
A process can die between reading the directory listing and opening the
directory FD (if HAVE_OPENAT) or /proc files (otherwise) for reading the
process data. This race would cause LinuxProcessList_recurseProcTree to
remove it from the list immediately, which is unexpected in the
"highlight dying processes" mode and can break the tree structure.
This patch closes this race in the HAVE_OPENAT case by only accessing
the process entry after the directory FD has been opened.
 2022-05-05 10:00:34 +02:00
Daniel Lange e08eec813c Remove redundant sscanf calls (in (s)scanf a blank validates _zero_ or more whitespace) 
man sscanf(3):
A sequence of white-space characters (space, tab, newline, etc.; see isspace(3)).
This directive matches any amount of white space, including none, in the input.
 2022-05-05 09:34:25 +02:00
Christian Göttsche 549fcb6bb8 Always abort on overflow in String_cat 
Not only in debug mode.
 2022-05-05 09:19:14 +02:00
Charlie Vieth 08166b27b1 ProcessList: fix quadratic process removal when scanning 
This commit changes ProcessList_scan to lazily remove Processes by
index, which is known, instead of performing a brute-force search by
pid and immediately reclaiming the lost vector space via compaction.

Searching by pid is potentially quadratic in ProcessList_scan because
the process we are searching for is always at the back of the vector
(the scan starts from the back of the vector). Additionally, removal
via Vector_remove immediately reclaims space (by sliding elements
down).

With these changes process removal in ProcessList_scan is now linear.

Changes:
  * ProcessList: add new ProcessList_removeIndex function to remove
    by index
  * Vector: add Vector_softRemove and Vector_compact functions to
    support lazy removal/deletion of entries Vector_softRemove
    Vector_compact
  * Vector: replace Vector_count with Vector_countEquals since it only
    used for consistency assertions.
 2022-05-05 09:17:51 +02:00