d0e71cb75f
Reorder field initialization to group fields by task
2020-12-02 23:50:05 +01:00
e3b6049043
Code style cleanup and documentation/comments
2020-12-02 23:50:05 +01:00
b4b952d78d
Use common values for initial size estimates for Hashtables
2020-12-02 23:50:05 +01:00
4907d90cff
Fix issue with inconsistent displayTreeSet
2020-12-02 23:50:05 +01:00
cf306ff86e
Implement sorting in tree mode
2020-12-02 23:50:05 +01:00
4f7d48aa24
Set locale only once and do not override it later
2020-12-02 22:08:25 +01:00
b76eaf187a
Dynamically load libsensors at runtime
2020-12-02 21:03:24 +01:00
f7a8952933
Add xReadfile wrapper for reading small to medium size files
...
Inspired by proposed Linux syscall
Avoid file descriptor leaks like 4af8c63f
2020-12-02 20:39:36 +01:00
1d8192c10b
PressureStallMeter: improve display strings
...
- Shorten name for header setup menu
- Improve caption in bar mode
2020-12-02 19:51:43 +01:00
472f0124cd
Meter: document MeterClass string fields
2020-12-02 19:51:43 +01:00
c0b50164dd
Use String_eq for readability and consistency
2020-12-02 19:14:22 +01:00
7975cd2ca3
Add cast to unsigned char to avoid signed char misuse
2020-12-02 19:14:22 +01:00
9029cc83ad
Merge identical conditional branches
2020-12-02 19:14:22 +01:00
43ee295c23
Drop redundant return statements
2020-12-02 19:14:22 +01:00
ec0f5d0ba9
Compare indices not index with pair
...
Fixes always true condition.
Found by LGTM.com
2020-12-02 17:54:53 +01:00
bbac4c2a62
Use enum element name instead of magic number
2020-12-02 17:52:16 +01:00
65866c69d6
Fix a little typo (spelling) in the styleguide
2020-12-01 14:15:16 +11:00
f59af39684
Merge branch 'styleguide-tweak' of https://github.com/natoscott/htop into natoscott-styleguide-tweak
2020-12-01 14:11:19 +11:00
6ab1e468ef
Update docs/styleguide.md
...
Co-authored-by: BenBE <BenBE@geshi.org >
2020-12-01 14:05:46 +11:00
cd305b4325
Print G in gigabyte color
...
When printing a size like 27.2G print the G like the 27 in the gigabyte color.
2020-11-29 15:06:08 +01:00
c1563337ae
Implement Hashtable_clear to empty an existing Hashtable
2020-11-29 14:54:10 +01:00
9549ca8c88
Linux: fix process parsing for hidden pid directories
2020-11-29 12:46:25 +01:00
b2a8b2426e
Tweak style guide wording around single code statements
...
There was wording about brace-enclosing single code statements
being 'strongly encouraged' - this isn't consistently used and
IMO it introduces unnecessary noise in otherwise neat, concise
code.
I've reworded (dropped) this section and also fixed a handful
of minor typos while reading this doc a little more carefully.
2020-11-28 23:47:13 +01:00
5ee6875f73
Typo
2020-11-28 20:53:49 +01:00
a7cf6c67d6
Typo fix in docs
2020-11-28 20:47:36 +01:00
0380d0bfd5
Include documentation for COMM and EXE
2020-11-28 20:23:33 +01:00
19b5141685
Hide process selection on ESC
...
Do not highlight the current process line after pressing ESC in the main
screen.
Restore after pressing any key.
2020-11-28 19:49:38 +01:00
ea4f33409a
Update even more snprintfs
...
Use size of actual buffers instead of magic numbers
2020-11-28 19:33:07 +01:00
7899ae2eb1
Replace more snprintfs, reduce buffer sizes to what is printed
2020-11-28 17:57:51 +01:00
0b29e5074c
Use 'N/A' instead of 'no perm' for more consistency
2020-11-28 17:43:08 +01:00
6c306315c8
Fix reading of device nodes > 2 chars from memory maps
2020-11-28 17:06:06 +01:00
a41e5c0a80
configure: do not check functions we are using unconditionally
2020-11-28 12:35:34 +01:00
2ff2859c23
Add compat mode for systems without openat(2)
2020-11-28 12:35:34 +01:00
638207a2ff
LinuxProcessList: use openat instead of building path strings
...
openat() is available since Linux 2.6.16
2020-11-28 12:35:34 +01:00
f704baeb82
Drop unused global ProcessList memory fields
...
The global ProcessList structure contains a couple of unused
fields. 'sharedMem' has never been used by any Meter, since
its not been anything other than zero in Linux /proc/meminfo
for many, many years. The freeMem field is only used in the
usedMem calculation, so it can reside on the stack like some
other memory variables used within-calculations-only and not
exposed to the user via a Meter.
2020-11-27 07:55:58 +01:00
fee217551c
Drop unneeded parameters to the ScreenManager constructor
...
All calls to ScreenManager_new always pass the same first
five values, the orientation is always HORIZONTAL and the
y1 parameter is always the height of the passed-in header
struct pointer. I think its safe to assert at this point
that no VERTICAL orientation will arrive (if it does, its
no harm in re-adding this then) - so we can remove unused
conditionals (and TODOs) based on orientation too.
2020-11-26 23:55:53 +01:00
83bf8cfad6
Make casing of N/A consistent (majority was N/A)
2020-11-26 22:58:34 +01:00
2c27f1d9ab
Randomly refresh M_LRS calculation, but latest after 2s
2020-11-26 22:58:34 +01:00
08d6e25301
Distinguish display of no permissions for reading M_LRS
2020-11-26 22:58:34 +01:00
31044d1729
Roll our own strtoull implementation specialized to handle the parsing requirements
2020-11-26 22:58:34 +01:00
cceab5f803
Hardcode actual conversions to read the maps file data
2020-11-26 22:58:34 +01:00
721d9112d9
Only calculate M_LRS size every 5 seconds
2020-11-26 22:58:34 +01:00
7f18b352b0
Calculate library size (M_LRS column) from maps file
2020-11-26 22:58:34 +01:00
46a2e8ac63
IOPriorityPanel: drop unnecessary buffer size decrement
...
xSnprintf guarantees null-termination within the passed size.
2020-11-26 20:42:38 +01:00
15fe8717b1
configure: create typedefs for fixed-sized integers if needed
...
If not defined in stdint.h or inttypes.h
See https://www.gnu.org/software/autoconf/manual/autoconf-2.62/html_node/Particular-Types.html
2020-11-26 20:28:38 +01:00
748f3eb7d8
Fix crash when getCommandStr not overloaded for a platform process
...
Closes : #343
2020-11-26 15:21:01 +01:00
d62c2e9cca
LinuxProcessList_recurseProcTree: compute time only once and mark parent const
2020-11-25 22:14:35 +01:00
a6a5686388
Track file descriptors in valgrind script
2020-11-25 22:09:39 +01:00
9b31ee5b63
Drop taskstats conditional
...
taskstats is only checked on runtime if the column RCHAR, WCHAR, SYSCR,
SYSCW, RBYTES, WBYTES, CNCLWB, IO_READ_RATE, IO_WRITE_RATE or IO_RATE is
selected.
taskstats is currently enabled by default.
Drop the taskstats configuration switch, to reduce the maintenance cost.
2020-11-25 20:49:39 +01:00
c88c80e3bd
Drop cgroup conditional
...
cgroup is only checked on runtime if the column CGROUP is selected.
cgroup is currently disabled by default, but most distributions do
enable it.
Drop the cgroup configuration switch, to reduce the maintenance cost.
2020-11-25 20:49:39 +01:00
