03f9a86918
Reduce scope of local variables
2020-11-22 10:08:27 +01:00
ddda739cb2
Simplify code flow by inlining declarations where they are used
...
Note that xStrdup always returns non-NULL, thus the one error case cannot be reached.
2020-11-22 10:07:01 +01:00
3cb96f1a36
No need to check for change when no action is required
2020-11-22 10:04:54 +01:00
98943d595e
Reduce scope of totaltime
2020-11-22 10:04:18 +01:00
51be2d5415
Fix NULL pointer dereference on kstat_lookup failure
2020-11-22 10:03:55 +01:00
d2c64c16e6
Fix build for custom make targets
2020-11-21 22:31:10 +01:00
0f4e3ebc95
Simplify page size related calculations
2020-11-21 19:39:45 +01:00
fa002c0ba9
Rename virtual memory column from M_SIZE to M_VIRT
...
Closes : #325
2020-11-21 19:39:45 +01:00
3e5cba91ce
LinuxProcess: mark LinuxProcess_printDelay static
2020-11-21 19:26:55 +01:00
4fb82e301d
fix indent
2020-11-21 19:26:42 +01:00
f752c6e2d1
Remove unnecessary parens
2020-11-21 16:07:19 +01:00
f5c3349bdb
IWYU update (FreeBSD)
2020-11-19 23:51:50 +01:00
7cf5277594
IWYU update (Linux)
2020-11-19 23:51:50 +01:00
329011bb98
Add missing OpenBSD battery function declaration
2020-11-19 12:00:56 +11:00
0a2105eb22
Spelling corrections
2020-11-18 13:59:55 +01:00
f720868998
Align command line argument descriptions in help output
...
Also drop #link comment
2020-11-18 13:59:36 +01:00
0eb3c7589d
Merge individual Battery.[ch] files into Platform.[ch]
...
Small changes from review - keep headers sorted and keep local
variable declarations at the top of source files.
2020-11-18 10:17:33 +11:00
ea9622b8c9
Merge individual Battery.[ch] files into Platform.[ch]
...
Consistent with everything else involving platform-specific
calls from core htop code.
2020-11-18 10:17:33 +11:00
e3af8d0d08
DarwinProcessList: mark local functions static and sort includes
2020-11-17 21:50:38 +01:00
ba2d59020d
DarwinProcess: mark local function static and sort includes
2020-11-17 21:50:38 +01:00
b3b890f546
Use 0 as no-match value for sortkey
...
Field numbers start at 1, and using -1 as no-match special value triggers
static analyzers using a potential negative array access.
2020-11-17 13:06:31 +01:00
f38af725c2
Silence theoretical memory leak
...
In practice systemctl should never return multiple SystemState= lines.
2020-11-17 13:06:31 +01:00
fec9af4e6f
Merge branch 'temperature_v2' of cgzones/htop
...
Closes #111 , closes #49
Closes #93 - thank you for leading the way @DX37 (Maxim Kurnosenko)!
2020-11-17 11:05:15 +01:00
a94fd87b05
Avoid calling Object_isA from inside Vector_isConsistent
2020-11-17 08:06:02 +01:00
307c34b028
Hashtable: use dynamic growth and use primes as size
...
Dynamically increase the hashmap size to not exceed the load factor and
avoid too long chains.
Switch from Separate Chaining to Robin Hood linear probing to improve
cache locality.
Use primes as size to further avoid collisions.
E.g. on a standard kde system the number of entries in the ProcessTable
might be around 650.
2020-11-17 02:01:02 +01:00
7914ec201e
Hashtable update
...
- use consistent type for key by introducing a new typedef
- use unsigned types for sizes
- name parameters in foreach function typedef
2020-11-17 02:01:02 +01:00
15eab2012d
Add process column for normalized CPU usage
...
Shows the process CPU usage divided by the number of CPU cores
2020-11-16 18:14:06 +01:00
a8a723ffe9
Add debug state to the configure report (thanks @benbe for the idea)
2020-11-16 17:01:51 +01:00
1b225cd7a0
Show CPU temperature in CPU meter
...
Show the CPU temperature in the CPU meter, like CPU frequency, instead
of using an extra Meter.
2020-11-16 16:38:54 +01:00
309f1d7282
hwloc = (portable) HardWare LOCality, not related to lock
2020-11-16 13:29:37 +01:00
8bc083c6c6
Merge branch 'highlight-new-old-processes'
...
Thanks to @adsr for the great work
Closes #241 , closes #74
Massive rebase, so #keepfingerscrossed
2020-11-16 13:19:31 +01:00
19868a3c29
Fix whitespace before comma in the new color definitions
2020-11-16 13:18:29 +01:00
8f2d129dce
Apply patch from BenBE as per https://github.com/htop-dev/htop/pull/241#issuecomment-720081138
2020-11-16 12:55:32 +01:00
0951090fa4
Merge branch 'hili-new-old' of adsr/htop into highlight-new-old-processes
2020-11-16 12:55:07 +01:00
0411fdbcef
Use spaceship comparison for TTYs
2020-11-15 22:54:14 +01:00
f856fe6463
Early skip non-directories when searching for process information
2020-11-15 22:54:14 +01:00
ad72b747fa
Drop hideThreads Setting
...
It is only used to read process directories on RedHat beginning with a dot.
Unconditionally accept directories with a starting dot.
2020-11-15 22:54:14 +01:00
9f67b95308
Mark local functions static
2020-11-15 18:35:30 +01:00
91317322fe
Mark ProcessList_keyAt argument const
2020-11-15 18:35:30 +01:00
42073babb9
Use uid_t type for Process_getuid
2020-11-15 18:35:30 +01:00
397b5c4bd0
Introduce spaceship comparison for Processes
...
If currently two unsigned values are compared via `a - b`, in the case b
is actually bigger than a, the result will not be an negative number (as
-1 is expected) but a huge positive number as the subtraction is an
unsigned subtraction.
Avoid over-/underflow affected operations; use comparisons.
Modern compilers will generate sane code, like:
xor eax, eax
cmp rdi, rsi
seta al
sbb eax, 0
ret
2020-11-15 18:25:21 +01:00
d785b1bbc3
Fixup of SystemdMeter merge
2020-11-15 17:53:31 +01:00
f2b2735e07
Resolve merge conflicts, merge #229 "Add SystemdMeter" from @cgzones
2020-11-15 14:52:25 +01:00
bb908f3dc4
Resolve merge conflicts, merge #298 "Macro cleanup" from @BenBE
2020-11-15 14:33:09 +01:00
da2dcf9505
Remove duplicate test for NUL
...
Fixes #308 , thanks @qarmin (Rafał Mikrut)
2020-11-15 14:16:23 +01:00
9e976b899b
Merge pull request #239 from StoneBam/list-locks
2020-11-14 16:03:17 +01:00
d431786fca
Split data array for file lock information into separate fields
2020-11-14 15:51:26 +01:00
18763051a2
Split platform dependent parts for file locks screen
2020-11-14 15:51:26 +01:00
2d6da2e520
Add compat wrapper for readlinkat
2020-11-09 19:17:57 +01:00
84dad4c38e
Implement screen for active file locks
2020-11-09 19:17:57 +01:00
