Benny Baumann
f6613db5cd
Additional code simplification
...
Additional correction for #375
2020-12-08 21:24:19 +01:00
Christian Göttsche
157086e750
Split RichString_(append|appendn|write) into wide and ascii
...
RichString_writeFrom takes a top spot during performance analysis due to the
calls to mbstowcs() and iswprint().
Most of the time we know in advance that we are only going to print regular
ASCII characters.
2020-12-08 20:58:40 +01:00
Christian Göttsche
7ba25aa3c4
IWYU update
2020-12-06 15:32:16 +01:00
Christian Göttsche
3695cbd5d8
Silence possible NULL dereference
...
Found by compiling with LTO
ProcessList.c: In function ‘ProcessList_updateTreeSetLayer’:
ProcessList.c:195:15: error: potential null pointer dereference [-Werror=null-dereference]
195 | if (proc->tree_depth == deep && proc->tree_left > left && proc->tree_right < right) {
| ^
ProcessList.c:195:15: error: potential null pointer dereference [-Werror=null-dereference]
ProcessList.c:195:15: error: potential null pointer dereference [-Werror=null-dereference]
2020-12-03 12:32:54 +01:00
Benny Baumann
c6b66a75ea
Minor code streamlining
2020-12-02 23:50:05 +01:00
Benny Baumann
709821ff55
Some minor spelling issues
2020-12-02 23:50:05 +01:00
Benny Baumann
2d874177bc
Avoid expensive build of tree when not using it
2020-12-02 23:50:05 +01:00
Benny Baumann
bd24664fc2
Avoid useless search for pid 0
2020-12-02 23:50:05 +01:00
Benny Baumann
d0e71cb75f
Reorder field initialization to group fields by task
2020-12-02 23:50:05 +01:00
Benny Baumann
e3b6049043
Code style cleanup and documentation/comments
2020-12-02 23:50:05 +01:00
Benny Baumann
b4b952d78d
Use common values for initial size estimates for Hashtables
2020-12-02 23:50:05 +01:00
Maxim Zhiburt
4907d90cff
Fix issue with inconsistent displayTreeSet
2020-12-02 23:50:05 +01:00
Maxim Zhiburt
cf306ff86e
Implement sorting in tree mode
2020-12-02 23:50:05 +01:00
Narendran Gopalakrishnan
e33d4d9460
Include merge status with column title when enabled
2020-11-24 19:05:48 +01:00
Narendran Gopalakrishnan
09fe94da18
Improving Command display/sort
2020-11-24 19:05:48 +01:00
Christian Göttsche
4fb82e301d
fix indent
2020-11-21 19:26:42 +01:00
Daniel Lange
8f2d129dce
Apply patch from BenBE as per https://github.com/htop-dev/htop/pull/241#issuecomment-720081138
2020-11-16 12:55:32 +01:00
Daniel Lange
0951090fa4
Merge branch 'hili-new-old' of adsr/htop into highlight-new-old-processes
2020-11-16 12:55:07 +01:00
Christian Göttsche
91317322fe
Mark ProcessList_keyAt argument const
2020-11-15 18:35:30 +01:00
Benny Baumann
45869513bf
Embracing branches
2020-11-02 22:15:01 +01:00
Benny Baumann
61e14d4bb2
Spacing around operators
2020-11-02 22:15:01 +01:00
Adam Saponara
a83f515f0f
Address items from review
2020-10-31 20:36:53 -04:00
Adam Saponara
dde71c6637
Highlight new and old processes ( #74 )
2020-10-30 21:56:16 -04:00
Christian Göttsche
a3bb7cbe64
Hold only a const version of Settings in ProcessList
2020-10-26 19:30:38 +01:00
Christian Göttsche
96e2a4259e
Continue to update generic data in paused mode
...
Generic data, as CPU and memory usage, are used by Meters.
In paused mode they would stop receiving updates and especially Graph
Meters would stop showing continuous data.
Improves: #214
Closes : #253
2020-10-19 14:45:39 +02:00
Benny Baumann
0f5262917f
Make all required includes explicit
...
Information as seen by IWYU 0.12 + clang 9 on Linux
2020-10-18 20:09:05 +02:00
Benny Baumann
872e542f4e
Rename StringUtils.[ch] to XUtils.[ch]
2020-10-16 20:30:21 +02:00
Christian Göttsche
e9246abff8
Misc Vector updates
...
- Move swap() macro to source file and implement as function
- Implement Vector_get() and Vector_size() as inline functions
to make them type safe and avoid lhs usage
- Comment comparison statistics, they are only needed for performance
testing
2020-10-16 19:47:34 +02:00
Christian Göttsche
08d85e6143
Mark Object classes and Object class fields const
2020-10-07 13:01:53 +02:00
Daniel Lange
079c2abf8e
Update License consistently to GPLv2 as per COPYING file
2020-10-05 10:13:12 +02:00
Nathan Scott
4597332959
Switch variable/field naming from WhiteList to MatchList
2020-09-09 19:38:15 +10:00
Zev Weiss
a1a027b9bd
Axe automated header generation.
...
Reasoning:
- implementation was unsound -- broke down when I added a fairly
basic macro definition expanding to a struct initializer in a *.c
file.
- made it way too easy (e.g. via otherwise totally innocuous git
commands) to end up with timestamps such that it always ran
MakeHeader.py but never used its output, leading to overbuild noise
when running what should be a null 'make'.
- but mostly: it's just an awkward way of dealing with C code.
2020-09-03 11:58:58 -05:00
Nathan Scott
728b04bbb5
Merge branch 'ci-hwloc-job' of https://github.com/bertwesarg/htop into bertwesarg-ci-hwloc-job
2020-08-26 10:39:43 +10:00
Daniel Flanagan
dd33444f7e
Clean up existing whitespace
2019-10-31 11:39:12 -05:00
Hisham Muhammad
0dbedf95a8
Collapse current subtree pressing Backspace
2018-04-05 19:38:13 -03:00
Wataru Ashihara
b34d76cd41
Fix: infinite loop in tree view on macOS
...
Fixes #688 , the bug regressed on 584a9bc
.
On Mac OS X 10.11.6, all processes have their parents since there's a
special process named "kernel_task", whose PID and PPID are 0. As a
result, `this->processes` is never changed causing infinite `while`.
2018-02-04 16:51:06 +01:00
Hisham Muhammad
e3f65c8ec2
Make 'c' key work with threads as well.
2017-09-14 17:10:39 -03:00
Hisham Muhammad
b9934ffa08
minor style tweak
2017-09-04 13:53:03 -03:00
wangqr
584a9bceab
Find roots when constructing process tree, fix #587
2017-09-01 21:34:05 +08:00
Hisham
84a69b1ea4
Release resource when using hwloc
2016-02-29 21:57:27 -03:00
Hisham Muhammad
c18309466d
Pre-reset 'show' for process.
...
This simplifies the protocol between the platform-independent
and platform-specific parts. The platform-specific parts
were supposed to re-determine the value of process->show
on each iteration, and the Darwin subsystem wasn't doing that.
Instead of adding the code to the Darwin part, I lifted the
burden of the OS-specific of resetting process->show: now
they can choose to hide a process if they want to (e.g.
detecting kernel threads) but are not required to
(e.g. on Darwin where we're not listing threads separately (yet?)).
Fixes tree view collapsing/expanding on OSX. Closes #416 .
2016-02-18 14:32:49 -02:00
Hisham
474d26cea8
Portable affinity using hwloc
2016-02-14 19:57:29 -02:00
Hisham Muhammad
0507cd38f7
Merge pull request #43 from ErkiDerLoony/master
...
Fix tree view if userland threads are hidden.
2015-08-20 02:15:04 -03:00
Hisham Muhammad
ea18a50091
Merge pull request #134 from jeffgarrett/pid-selection
...
Interpret command line PIDs as PIDs, not TIDs
2015-08-20 01:20:21 -03:00
David Hunt
5e602f18d5
Rename String to StringUtils.
...
Fixes building on case-insensitive filesystems where String.h gets confused with <string.h>.
From d734dacea0a10d0465dad4e95b3421511e7da112 Mon Sep 17 00:00:00 2001
From: David Hunt <dhunt@iolanthe.attlocal.net>
Date: Sat, 11 Jul 2015 20:56:31 -0500
Subject: [PATCH 1/8] Rename String to StringUtils
2015-08-19 13:45:20 -03:00
Hisham Muhammad
b291fba02b
Fixes to use platform-specific compare routines.
2015-04-09 15:40:46 -03:00
Hisham Muhammad
b1f934c5d5
Visual tweaks: change color when following, add Broken Gray theme.
2015-04-09 15:17:20 -03:00
Hisham Muhammad
d880def0e9
Merge branch 'master' into wip
...
Conflicts:
Process.c
Process.h
htop.c
linux/LinuxProcess.c
linux/LinuxProcess.h
test_spec.lua
2015-04-02 01:57:37 -03:00
Hisham Muhammad
272e2d9b34
Major advances in FreeBSD port.
2015-03-16 23:02:03 -03:00
Hisham Muhammad
adbfe3c3f1
Get FreeBSD tree to compile again with latest changes.
2015-03-16 03:14:20 -03:00